* [PATCH] dm-raid1.c: Conditionally ignore kcopyd errors depending on whether mirror handles them
@ 2008-07-25 15:18 Jonathan Brassow
0 siblings, 0 replies; only message in thread
From: Jonathan Brassow @ 2008-07-25 15:18 UTC (permalink / raw)
To: dm-devel
brassow
dm-raid1 is setting the flag to ignore errors in kcopyd. Now that
mirroring is capable of handling errors, it should. So, we make
the setting of the 'ignore errors' flag conditional on whether
mirror is handling errors or not.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Index: linux-2.6.26-rc8/drivers/md/dm-raid1.c
===================================================================
--- linux-2.6.26-rc8.orig/drivers/md/dm-raid1.c
+++ linux-2.6.26-rc8/drivers/md/dm-raid1.c
@@ -842,7 +842,9 @@ static int recover(struct mirror_set *ms
}
/* hand to kcopyd */
- set_bit(DM_KCOPYD_IGNORE_ERROR, &flags);
+ if (!errors_handled(ms))
+ set_bit(DM_KCOPYD_IGNORE_ERROR, &flags);
+
r = dm_kcopyd_copy(ms->kcopyd_client, &from, ms->nr_mirrors - 1, to,
flags, recovery_complete, reg);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-07-25 15:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25 15:18 [PATCH] dm-raid1.c: Conditionally ignore kcopyd errors depending on whether mirror handles them Jonathan Brassow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox