* [PATCH 0/3] Debian packaging fixes for multipath-tools
@ 2013-01-09 10:05 Ritesh Raj Sarraf
2013-01-09 10:05 ` [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Ritesh Raj Sarraf @ 2013-01-09 10:05 UTC (permalink / raw)
To: christophe.varoqui; +Cc: Ritesh Raj Sarraf, dm-devel
Re-sending patches.
Guido Günther (1):
explicitly include posix_types.h
Ritesh Raj Sarraf (2):
Minor spelling error fixes for Debian's lintian cleanliness
Drop useless link to curses library
kpartx/kpartx.8 | 8 ++++----
kpartx/lopart.c | 13 +------------
multipath/main.c | 2 +-
multipath/multipath.conf.5 | 8 ++++----
multipathd/Makefile | 2 +-
multipathd/multipathd.8 | 4 ++--
6 files changed, 13 insertions(+), 24 deletions(-)
--
1.7.10.4
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/3] explicitly include posix_types.h 2013-01-09 10:05 [PATCH 0/3] Debian packaging fixes for multipath-tools Ritesh Raj Sarraf @ 2013-01-09 10:05 ` Ritesh Raj Sarraf 2013-01-12 13:14 ` Christophe Varoqui 2013-01-09 10:05 ` [PATCH 2/3] Minor spelling error fixes for Debian's lintian cleanliness Ritesh Raj Sarraf 2013-01-09 10:05 ` [PATCH 3/3] Drop useless link to curses library Ritesh Raj Sarraf 2 siblings, 1 reply; 8+ messages in thread From: Ritesh Raj Sarraf @ 2013-01-09 10:05 UTC (permalink / raw) To: christophe.varoqui; +Cc: Ritesh Raj Sarraf, dm-devel, Guido Günther From: Guido Günther <agx@sigxcpu.org> to get the correct type for __kernel_old_dev_t Closes: #558990 Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> --- kpartx/lopart.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/kpartx/lopart.c b/kpartx/lopart.c index 79d8328..570c8ad 100644 --- a/kpartx/lopart.c +++ b/kpartx/lopart.c @@ -26,18 +26,7 @@ #include <sys/stat.h> #include <sys/mman.h> #include <sysmacros.h> - -#if defined(__hppa__) || defined(__powerpc64__) || defined (__alpha__) \ - || defined (__x86_64__) -typedef unsigned long __kernel_old_dev_t; -#elif defined(__powerpc__) || defined(__ia64__) || (defined(__sparc__) && defined (__arch64__)) -typedef unsigned int __kernel_old_dev_t; -#else -typedef unsigned short __kernel_old_dev_t; -#endif - -#define dev_t __kernel_old_dev_t - +#include <asm/posix_types.h> #include <linux/loop.h> #include "lopart.h" -- 1.7.10.4 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] explicitly include posix_types.h 2013-01-09 10:05 ` [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf @ 2013-01-12 13:14 ` Christophe Varoqui 0 siblings, 0 replies; 8+ messages in thread From: Christophe Varoqui @ 2013-01-12 13:14 UTC (permalink / raw) To: Ritesh Raj Sarraf; +Cc: dm-devel, Guido Günther On mer., 2013-01-09 at 15:35 +0530, Ritesh Raj Sarraf wrote: > From: Guido Günther <agx@sigxcpu.org> > > to get the correct type for __kernel_old_dev_t > > Closes: #558990 > Merged. > Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> > --- > kpartx/lopart.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/kpartx/lopart.c b/kpartx/lopart.c > index 79d8328..570c8ad 100644 > --- a/kpartx/lopart.c > +++ b/kpartx/lopart.c > @@ -26,18 +26,7 @@ > #include <sys/stat.h> > #include <sys/mman.h> > #include <sysmacros.h> > - > -#if defined(__hppa__) || defined(__powerpc64__) || defined (__alpha__) \ > - || defined (__x86_64__) > -typedef unsigned long __kernel_old_dev_t; > -#elif defined(__powerpc__) || defined(__ia64__) || (defined(__sparc__) && defined (__arch64__)) > -typedef unsigned int __kernel_old_dev_t; > -#else > -typedef unsigned short __kernel_old_dev_t; > -#endif > - > -#define dev_t __kernel_old_dev_t > - > +#include <asm/posix_types.h> > #include <linux/loop.h> > > #include "lopart.h" -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] Minor spelling error fixes for Debian's lintian cleanliness 2013-01-09 10:05 [PATCH 0/3] Debian packaging fixes for multipath-tools Ritesh Raj Sarraf 2013-01-09 10:05 ` [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf @ 2013-01-09 10:05 ` Ritesh Raj Sarraf 2013-01-12 13:14 ` Christophe Varoqui 2013-01-09 10:05 ` [PATCH 3/3] Drop useless link to curses library Ritesh Raj Sarraf 2 siblings, 1 reply; 8+ messages in thread From: Ritesh Raj Sarraf @ 2013-01-09 10:05 UTC (permalink / raw) To: christophe.varoqui; +Cc: Ritesh Raj Sarraf, dm-devel fix missed-out hyphen Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> --- kpartx/kpartx.8 | 8 ++++---- multipath/main.c | 2 +- multipath/multipath.conf.5 | 8 ++++---- multipathd/multipathd.8 | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/kpartx/kpartx.8 b/kpartx/kpartx.8 index 8a37d4f..021ddc0 100644 --- a/kpartx/kpartx.8 +++ b/kpartx/kpartx.8 @@ -18,7 +18,7 @@ creation and deletion. Add partition mappings .TP .B \-r -Readonly partition mappings +Read-only partition mappings .TP .B \-d Delete partition mappings @@ -27,7 +27,7 @@ Delete partition mappings Update partition mappings .TP .B \-l -List partition mappings that would be added -a +List partition mappings that would be added \-a .TP .B \-p set device name-partition number delimiter @@ -46,7 +46,7 @@ Sync mode. Don't return until the partitions are created .SH EXAMPLE To mount all the partitions in a raw disk image: .IP -kpartx -av disk.img +kpartx \-av disk.img .PP This will output lines such as: .IP @@ -62,7 +62,7 @@ fsck /dev/mapper/loop3p1 .PP When you're done, you need to remove the devices: .IP -kpartx -d disk.img +kpartx \-d disk.img .SH "SEE ALSO" .BR multipath (8) .BR multipathd (8) diff --git a/multipath/main.c b/multipath/main.c index 396c4b9..0083ef4 100644 --- a/multipath/main.c +++ b/multipath/main.c @@ -504,7 +504,7 @@ main (int argc, char *argv[]) usage(argv[0]); exit(0); case ':': - fprintf(stderr, "Missing option arguement\n"); + fprintf(stderr, "Missing option argument\n"); usage(argv[0]); exit(1); case '?': diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index 92fb0c1..eb96c61 100644 --- a/multipath/multipath.conf.5 +++ b/multipath/multipath.conf.5 @@ -301,7 +301,7 @@ to assign a persistent and unique alias to the multipath, in the form of mpath<n If set to .I no use the WWID as the alias. In either case this be will -be overriden by any specific aliases in the \fImultipaths\fR section. +be overridden by any specific aliases in the \fImultipaths\fR section. Default is .I no .TP @@ -314,7 +314,7 @@ deleted. Default is .TP .B max_fds Specify the maximum number of file descriptors that can be opened by multipath -and multipathd. This is equivalent to ulimit -n. A value of \fImax\fR will set +and multipathd. This is equivalent to ulimit \-n. A value of \fImax\fR will set this to the system limit from /proc/sys/fs/nr_open. If this is not set, the maximum number of open fds is taken from the calling process. It is usually 1024. To be safe, this should be set to the maximum number of paths plus 32, @@ -322,7 +322,7 @@ if that number is greated than 1024. .TP .B checker_timeout Specify the timeout to user for path checkers that issue scsi commands with an -explict timeout, in seconds; default taken from +explicit timeout, in seconds; default taken from .I /sys/block/sd<x>/device/timeout .TP .B fast_io_fail_tmo @@ -405,7 +405,7 @@ The section is used to revert the actions of the .I blacklist section, ie to include specific device in the -multipath topology. This allows to selectively include devices which +multipath topology. This allows one to selectively include devices which would normally be excluded via the .I blacklist section. diff --git a/multipathd/multipathd.8 b/multipathd/multipathd.8 index cbc40a4..ccc5f54 100644 --- a/multipathd/multipathd.8 +++ b/multipathd/multipathd.8 @@ -53,10 +53,10 @@ Show the status of all multipath devices that the multipathd is monitoring. Show some statistics of all multipath devices that the multipathd is monitoring. .TP .B list|show maps|multipaths topology -Show the current multipath topology. Same as "multipath -ll". +Show the current multipath topology. Same as "multipath \-ll". .TP .B list|show topology -Show the current multipath topology. Same as "multipath -ll". +Show the current multipath topology. Same as "multipath \-ll". .TP .B list|show map|multipath $map topology Show topology of a single multipath device specified by $map, e.g. 36005076303ffc56200000000000010aa. -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] Minor spelling error fixes for Debian's lintian cleanliness 2013-01-09 10:05 ` [PATCH 2/3] Minor spelling error fixes for Debian's lintian cleanliness Ritesh Raj Sarraf @ 2013-01-12 13:14 ` Christophe Varoqui 0 siblings, 0 replies; 8+ messages in thread From: Christophe Varoqui @ 2013-01-12 13:14 UTC (permalink / raw) To: Ritesh Raj Sarraf; +Cc: dm-devel On mer., 2013-01-09 at 15:35 +0530, Ritesh Raj Sarraf wrote: > fix missed-out hyphen > Merged. > Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> > --- > kpartx/kpartx.8 | 8 ++++---- > multipath/main.c | 2 +- > multipath/multipath.conf.5 | 8 ++++---- > multipathd/multipathd.8 | 4 ++-- > 4 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/kpartx/kpartx.8 b/kpartx/kpartx.8 > index 8a37d4f..021ddc0 100644 > --- a/kpartx/kpartx.8 > +++ b/kpartx/kpartx.8 > @@ -18,7 +18,7 @@ creation and deletion. > Add partition mappings > .TP > .B \-r > -Readonly partition mappings > +Read-only partition mappings > .TP > .B \-d > Delete partition mappings > @@ -27,7 +27,7 @@ Delete partition mappings > Update partition mappings > .TP > .B \-l > -List partition mappings that would be added -a > +List partition mappings that would be added \-a > .TP > .B \-p > set device name-partition number delimiter > @@ -46,7 +46,7 @@ Sync mode. Don't return until the partitions are created > .SH EXAMPLE > To mount all the partitions in a raw disk image: > .IP > -kpartx -av disk.img > +kpartx \-av disk.img > .PP > This will output lines such as: > .IP > @@ -62,7 +62,7 @@ fsck /dev/mapper/loop3p1 > .PP > When you're done, you need to remove the devices: > .IP > -kpartx -d disk.img > +kpartx \-d disk.img > .SH "SEE ALSO" > .BR multipath (8) > .BR multipathd (8) > diff --git a/multipath/main.c b/multipath/main.c > index 396c4b9..0083ef4 100644 > --- a/multipath/main.c > +++ b/multipath/main.c > @@ -504,7 +504,7 @@ main (int argc, char *argv[]) > usage(argv[0]); > exit(0); > case ':': > - fprintf(stderr, "Missing option arguement\n"); > + fprintf(stderr, "Missing option argument\n"); > usage(argv[0]); > exit(1); > case '?': > diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 > index 92fb0c1..eb96c61 100644 > --- a/multipath/multipath.conf.5 > +++ b/multipath/multipath.conf.5 > @@ -301,7 +301,7 @@ to assign a persistent and unique alias to the multipath, in the form of mpath<n > If set to > .I no > use the WWID as the alias. In either case this be will > -be overriden by any specific aliases in the \fImultipaths\fR section. > +be overridden by any specific aliases in the \fImultipaths\fR section. > Default is > .I no > .TP > @@ -314,7 +314,7 @@ deleted. Default is > .TP > .B max_fds > Specify the maximum number of file descriptors that can be opened by multipath > -and multipathd. This is equivalent to ulimit -n. A value of \fImax\fR will set > +and multipathd. This is equivalent to ulimit \-n. A value of \fImax\fR will set > this to the system limit from /proc/sys/fs/nr_open. If this is not set, the > maximum number of open fds is taken from the calling process. It is usually > 1024. To be safe, this should be set to the maximum number of paths plus 32, > @@ -322,7 +322,7 @@ if that number is greated than 1024. > .TP > .B checker_timeout > Specify the timeout to user for path checkers that issue scsi commands with an > -explict timeout, in seconds; default taken from > +explicit timeout, in seconds; default taken from > .I /sys/block/sd<x>/device/timeout > .TP > .B fast_io_fail_tmo > @@ -405,7 +405,7 @@ The > section is used to revert the actions of the > .I blacklist > section, ie to include specific device in the > -multipath topology. This allows to selectively include devices which > +multipath topology. This allows one to selectively include devices which > would normally be excluded via the > .I blacklist > section. > diff --git a/multipathd/multipathd.8 b/multipathd/multipathd.8 > index cbc40a4..ccc5f54 100644 > --- a/multipathd/multipathd.8 > +++ b/multipathd/multipathd.8 > @@ -53,10 +53,10 @@ Show the status of all multipath devices that the multipathd is monitoring. > Show some statistics of all multipath devices that the multipathd is monitoring. > .TP > .B list|show maps|multipaths topology > -Show the current multipath topology. Same as "multipath -ll". > +Show the current multipath topology. Same as "multipath \-ll". > .TP > .B list|show topology > -Show the current multipath topology. Same as "multipath -ll". > +Show the current multipath topology. Same as "multipath \-ll". > .TP > .B list|show map|multipath $map topology > Show topology of a single multipath device specified by $map, e.g. 36005076303ffc56200000000000010aa. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] Drop useless link to curses library 2013-01-09 10:05 [PATCH 0/3] Debian packaging fixes for multipath-tools Ritesh Raj Sarraf 2013-01-09 10:05 ` [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf 2013-01-09 10:05 ` [PATCH 2/3] Minor spelling error fixes for Debian's lintian cleanliness Ritesh Raj Sarraf @ 2013-01-09 10:05 ` Ritesh Raj Sarraf 2013-01-12 13:14 ` Christophe Varoqui 2 siblings, 1 reply; 8+ messages in thread From: Ritesh Raj Sarraf @ 2013-01-09 10:05 UTC (permalink / raw) To: christophe.varoqui; +Cc: Ritesh Raj Sarraf, dm-devel Description: Do not link against ncurses unnecessarily Author: Sven Joachim <svenjoac@gmx.de> Bug-Debian: http://bugs.debian.org/646148 Last-Update: <2011-11-05> Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> --- multipathd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipathd/Makefile b/multipathd/Makefile index 9553251..b490c1d 100644 --- a/multipathd/Makefile +++ b/multipathd/Makefile @@ -6,7 +6,7 @@ include ../Makefile.inc # basic flags setting # CFLAGS += -I$(multipathdir) -I$(mpathpersistdir) -LDFLAGS += -lpthread -ldevmapper -lreadline -lncurses -ludev -ldl \ +LDFLAGS += -lpthread -ldevmapper -lreadline -ludev -ldl \ -L$(multipathdir) -lmultipath -L$(mpathpersistdir) -lmpathpersist # -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] Drop useless link to curses library 2013-01-09 10:05 ` [PATCH 3/3] Drop useless link to curses library Ritesh Raj Sarraf @ 2013-01-12 13:14 ` Christophe Varoqui 0 siblings, 0 replies; 8+ messages in thread From: Christophe Varoqui @ 2013-01-12 13:14 UTC (permalink / raw) To: Ritesh Raj Sarraf; +Cc: dm-devel On mer., 2013-01-09 at 15:35 +0530, Ritesh Raj Sarraf wrote: > Description: Do not link against ncurses unnecessarily > Author: Sven Joachim <svenjoac@gmx.de> > Bug-Debian: http://bugs.debian.org/646148 > Last-Update: <2011-11-05> > Merged. > Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> > --- > multipathd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/multipathd/Makefile b/multipathd/Makefile > index 9553251..b490c1d 100644 > --- a/multipathd/Makefile > +++ b/multipathd/Makefile > @@ -6,7 +6,7 @@ include ../Makefile.inc > # basic flags setting > # > CFLAGS += -I$(multipathdir) -I$(mpathpersistdir) > -LDFLAGS += -lpthread -ldevmapper -lreadline -lncurses -ludev -ldl \ > +LDFLAGS += -lpthread -ldevmapper -lreadline -ludev -ldl \ > -L$(multipathdir) -lmultipath -L$(mpathpersistdir) -lmpathpersist > > # ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] explicitly include posix_types.h @ 2013-01-09 8:32 Ritesh Raj Sarraf 2013-01-09 8:32 ` [PATCH 3/3] Drop useless link to curses library Ritesh Raj Sarraf 0 siblings, 1 reply; 8+ messages in thread From: Ritesh Raj Sarraf @ 2013-01-09 8:32 UTC (permalink / raw) To: christophe.varoqui; +Cc: Ritesh Raj Sarraf, dm-devel, Guido Günther From: Guido Günther <agx@sigxcpu.org> to get the correct type for __kernel_old_dev_t Closes: #558990 Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> Signed-off-by: Guido Gunther <agx@sigxcpu.org> --- kpartx/lopart.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/kpartx/lopart.c b/kpartx/lopart.c index 79d8328..570c8ad 100644 --- a/kpartx/lopart.c +++ b/kpartx/lopart.c @@ -26,18 +26,7 @@ #include <sys/stat.h> #include <sys/mman.h> #include <sysmacros.h> - -#if defined(__hppa__) || defined(__powerpc64__) || defined (__alpha__) \ - || defined (__x86_64__) -typedef unsigned long __kernel_old_dev_t; -#elif defined(__powerpc__) || defined(__ia64__) || (defined(__sparc__) && defined (__arch64__)) -typedef unsigned int __kernel_old_dev_t; -#else -typedef unsigned short __kernel_old_dev_t; -#endif - -#define dev_t __kernel_old_dev_t - +#include <asm/posix_types.h> #include <linux/loop.h> #include "lopart.h" -- 1.7.10.4 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] Drop useless link to curses library 2013-01-09 8:32 [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf @ 2013-01-09 8:32 ` Ritesh Raj Sarraf 0 siblings, 0 replies; 8+ messages in thread From: Ritesh Raj Sarraf @ 2013-01-09 8:32 UTC (permalink / raw) To: christophe.varoqui; +Cc: Ritesh Raj Sarraf, dm-devel Description: Do not link against ncurses unnecessarily Author: Sven Joachim <svenjoac@gmx.de> Bug-Debian: http://bugs.debian.org/646148 Last-Update: <2011-11-05> Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> --- multipathd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipathd/Makefile b/multipathd/Makefile index 9553251..b490c1d 100644 --- a/multipathd/Makefile +++ b/multipathd/Makefile @@ -6,7 +6,7 @@ include ../Makefile.inc # basic flags setting # CFLAGS += -I$(multipathdir) -I$(mpathpersistdir) -LDFLAGS += -lpthread -ldevmapper -lreadline -lncurses -ludev -ldl \ +LDFLAGS += -lpthread -ldevmapper -lreadline -ludev -ldl \ -L$(multipathdir) -lmultipath -L$(mpathpersistdir) -lmpathpersist # -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-01-12 13:14 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-09 10:05 [PATCH 0/3] Debian packaging fixes for multipath-tools Ritesh Raj Sarraf 2013-01-09 10:05 ` [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf 2013-01-12 13:14 ` Christophe Varoqui 2013-01-09 10:05 ` [PATCH 2/3] Minor spelling error fixes for Debian's lintian cleanliness Ritesh Raj Sarraf 2013-01-12 13:14 ` Christophe Varoqui 2013-01-09 10:05 ` [PATCH 3/3] Drop useless link to curses library Ritesh Raj Sarraf 2013-01-12 13:14 ` Christophe Varoqui -- strict thread matches above, loose matches on Subject: below -- 2013-01-09 8:32 [PATCH 1/3] explicitly include posix_types.h Ritesh Raj Sarraf 2013-01-09 8:32 ` [PATCH 3/3] Drop useless link to curses library Ritesh Raj Sarraf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox