From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>,
"snitzer@redhat.com" <snitzer@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"loberman@redhat.com" <loberman@redhat.com>
Subject: Re: dm-mpath: return DM_MAPIO_REQUEUE in case of rq allocation failure
Date: Tue, 26 Sep 2017 13:55:13 +0000 [thread overview]
Message-ID: <1506434112.3787.4.camel@wdc.com> (raw)
In-Reply-To: <20170926085007.GD518@ming.t460p>
On Tue, 2017-09-26 at 16:50 +0800, Ming Lei wrote:
> If you don't consider to change mpath into block in .queue_rq() now,
> please take this patch first, and I am sure this way is correct, and
> even it can be thought as a fix.
As I explained earlier, it would be wrong to take this patch upstream without
having tested and measured the alternative I had proposed first
(https://www.spinics.net/lists/dm-devel/msg32282.html). My alternative handles
SCSI hosts with multiple LUNs properly but the patch at the start of this
e-mail thread not.
Bart.
prev parent reply other threads:[~2017-09-26 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 1:35 [PATCH] dm-mpath: return DM_MAPIO_REQUEUE in case of rq allocation failure Ming Lei
2017-09-22 15:06 ` Bart Van Assche
2017-09-22 17:44 ` Ming Lei
2017-09-22 17:54 ` Bart Van Assche
2017-09-25 3:06 ` Ming Lei
2017-09-25 15:23 ` Bart Van Assche
2017-09-25 16:10 ` Ming Lei
2017-09-25 16:17 ` Mike Snitzer
2017-09-26 8:50 ` Ming Lei
2017-09-26 13:55 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506434112.3787.4.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox