Re: Bcache upstreaming

[Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>]

On Thu, Jan 17, 2013 at 03:41:04AM -0800, Kent Overstreet wrote:
> On Wed, Jan 16, 2013 at 09:27:28PM -0500, Mike Snitzer wrote:
> > On Mon, Jan 14 2013 at  5:53pm -0500,
> > Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > 
> > > On Mon, Jan 14 2013 at  5:37pm -0500,
> > > Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> > > 
> > > > Want to try again with the latest bcache-for-upstream branch? I fixed
> > > > all that sysfs stuff, but I wasn't seeing the original build error so
> > > > I'd appreciate if you verify I did in fact fix that issue.
> > > 
> > > Will do, thanks Kent.
> > 
> > I hit the crash below if I do this in a script:
> > 
> > echo 1 > /sys/block/bcache0/bcache/cache/unregister
> > echo 1 > /sys/block/bcache0/bcache/stop
> 
> Thanks - I reproduced it, trying to figure out the sanest way to fix it.
> This is not the prettiest area of the code :P

And, I finally have a fix for it up.

Fixed a bunch of other bugs today too... notably the bug where it'd
crash if you enabled discards. Was there anything else you or anyone
else was hitting?