* [PATCH] multipath-tools: fix misspellings
@ 2016-11-26 1:33 Xose Vazquez Perez
2016-11-26 9:11 ` Christophe Varoqui
0 siblings, 1 reply; 7+ messages in thread
From: Xose Vazquez Perez @ 2016-11-26 1:33 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Done with https://github.com/lucasdemarchi/codespell
multipath-tools/kpartx/dasd.c:263: formated ==> formatted
multipath-tools/libmultipath/discovery.c:1808: unuseable ==> unusable
multipath-tools/libmultipath/discovery.h:20: exerpt ==> excerpt
multipath-tools/libmultipath/memory.c:150: formated ==> formatted
multipath-tools/libmultipath/checkers/directio.c:84: Sucessfully ==> Successfully
multipath-tools/libmultipath/prioritizers/hds.c:9: pathes ==> paths
multipath-tools/libmultipath/prioritizers/hds.c:14: pathes ==> paths
multipath-tools/libmultipath/prioritizers/ontap.c:119: Retuns ==> Returns
multipath-tools/third-party/valgrind/valgrind.h:6828: arbitary ==> arbitrary
multipath-tools/multipath/02_multipath:11: dynamicaly ==> dynamically
multipath-tools/multipath/multipath.conf.5:793: remeber ==> remember
multipath-tools/libmpathpersist/mpath_persist.h:15: lenght ==> length
-------8<-------
SUMMARY:
arbitary 1
dynamicaly 1
exerpt 1
formated 2
lenght 1
pathes 2
remeber 1
retuns 1
sucessfully 1
unuseable 1
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
kpartx/dasd.c | 2 +-
libmpathpersist/mpath_persist.h | 2 +-
libmultipath/checkers/directio.c | 2 +-
libmultipath/discovery.c | 2 +-
libmultipath/discovery.h | 2 +-
libmultipath/memory.c | 2 +-
libmultipath/prioritizers/hds.c | 4 ++--
libmultipath/prioritizers/ontap.c | 2 +-
multipath/02_multipath | 2 +-
multipath/multipath.conf.5 | 2 +-
10 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/kpartx/dasd.c b/kpartx/dasd.c
index faf5e2e..1206e45 100644
--- a/kpartx/dasd.c
+++ b/kpartx/dasd.c
@@ -261,7 +261,7 @@ read_dasd_pt(int fd, struct slice all, struct slice *sp, int ns)
fmt_size = sectors512(vlabel.formatted_blocks,
blocksize);
} else if (!strcmp(info.type, "ECKD")) {
- /* formated w/o large volume support */
+ /* formatted w/o large volume support */
fmt_size = geo.cylinders * geo.heads
* geo.sectors * (blocksize >> 9);
} else {
diff --git a/libmpathpersist/mpath_persist.h b/libmpathpersist/mpath_persist.h
index fde0416..79de5b5 100644
--- a/libmpathpersist/mpath_persist.h
+++ b/libmpathpersist/mpath_persist.h
@@ -13,7 +13,7 @@ extern "C" {
#define MPATH_MAX_PARAM_LEN 8192
#define MPATH_MX_TIDS 32 /* Max number of transport ids"*/
-#define MPATH_MX_TID_LEN 256 /* Max lenght of transport id */
+#define MPATH_MX_TID_LEN 256 /* Max length of transport id */
/* PRIN Service Actions */
#define MPATH_PRIN_RKEY_SA 0x00 /* READ KEYS SA*/
diff --git a/libmultipath/checkers/directio.c b/libmultipath/checkers/directio.c
index eec12d5..ce60e4c 100644
--- a/libmultipath/checkers/directio.c
+++ b/libmultipath/checkers/directio.c
@@ -82,7 +82,7 @@ int libcheck_init (struct checker * c)
ct->ptr = (unsigned char *) (((unsigned long)ct->buf + pgsize - 1) &
(~(pgsize - 1)));
- /* Sucessfully initialized, return the context. */
+ /* Successfully initialized, return the context. */
c->context = (void *) ct;
return 0;
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index aaa915c..0f912ba 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1806,7 +1806,7 @@ int pathinfo(struct path *pp, struct config *conf, int mask)
pp->state = PATH_DOWN;
if (pp->state == PATH_UP && !pp->size) {
condlog(3, "%s: device size is 0, "
- "path unuseable", pp->dev);
+ "path unusable", pp->dev);
pp->state = PATH_GHOST;
}
} else {
diff --git a/libmultipath/discovery.h b/libmultipath/discovery.h
index 97e5a32..3039268 100644
--- a/libmultipath/discovery.h
+++ b/libmultipath/discovery.h
@@ -18,7 +18,7 @@
#endif
/*
- * exerpt from sg_err.h
+ * excerpt from sg_err.h
*/
#define SCSI_CHECK_CONDITION 0x2
#define SCSI_COMMAND_TERMINATED 0x22
diff --git a/libmultipath/memory.c b/libmultipath/memory.c
index 293a688..ff5a030 100644
--- a/libmultipath/memory.c
+++ b/libmultipath/memory.c
@@ -148,7 +148,7 @@ dbg_strdup(char *str, char *file, char *function, int line)
-/* Display a buffer into a HEXA formated output */
+/* Display a buffer into a HEXA formatted output */
static void
dump_buffer(char *buff, int count)
{
diff --git a/libmultipath/prioritizers/hds.c b/libmultipath/prioritizers/hds.c
index d161e68..70fb5d1 100644
--- a/libmultipath/prioritizers/hds.c
+++ b/libmultipath/prioritizers/hds.c
@@ -7,12 +7,12 @@
* Prioritizer for Device Mapper Multipath and HDS Storage
*
* Hitachis Modular Storage contains two controllers for redundancy. The
- * Storage internal LUN (LDEV) will normally allocated via two pathes to the
+ * Storage internal LUN (LDEV) will normally allocated via two paths to the
* server (one path per controller). For performance reasons should the server
* access to a LDEV only via one controller. The other path to the other
* controller is stand-by. It is also possible to allocate more as one path
* for a LDEV per controller. Here is active/active access allowed. The other
- * pathes via the other controller are stand-by.
+ * paths via the other controller are stand-by.
*
* This prioritizer checks with inquiry command the represented LDEV and
* Controller number and gives back a priority followed by this scheme:
diff --git a/libmultipath/prioritizers/ontap.c b/libmultipath/prioritizers/ontap.c
index 38495cd..ca06d6c 100644
--- a/libmultipath/prioritizers/ontap.c
+++ b/libmultipath/prioritizers/ontap.c
@@ -117,7 +117,7 @@ out:
}
/*
- * Retuns:
+ * Returns:
* -1: Unable to obtain proxy info
* 0: Device _not_ proxy path
* 1: Device _is_ proxy path
diff --git a/multipath/02_multipath b/multipath/02_multipath
index 523f0ef..de6e247 100755
--- a/multipath/02_multipath
+++ b/multipath/02_multipath
@@ -9,7 +9,7 @@ cp /sbin/kpartx $INITRDDIR/sbin
#
# feed the dependencies too
-# scsi_id is dynamicaly linked, so store the libs too
+# scsi_id is dynamically linked, so store the libs too
#
cp /lib/udev/scsi_id $INITRDDIR/lib/udev/
cp /bin/mountpoint $INITRDDIR/bin
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 8f5447d..c272dd6 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -791,7 +791,7 @@ a path has the same WWID as a multipath device that was previously created
while find_multipaths was set (even if that multipath device doesn't currently
exist).
Whenever a multipath device is created with find_multipaths set, multipath will
-remeber the WWID of the device, so that it will automatically create the
+remember the WWID of the device, so that it will automatically create the
device again, as soon as it sees a path with that WWID. This should allow most
users to have multipath automatically choose the correct paths to make into
multipath devices, without having to edit the blacklist.
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: fix misspellings
2016-11-26 1:33 [PATCH] multipath-tools: fix misspellings Xose Vazquez Perez
@ 2016-11-26 9:11 ` Christophe Varoqui
0 siblings, 0 replies; 7+ messages in thread
From: Christophe Varoqui @ 2016-11-26 9:11 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 8080 bytes --]
Applied, thanks.
On Sat, Nov 26, 2016 at 2:33 AM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:
> Done with https://github.com/lucasdemarchi/codespell
>
>
> multipath-tools/kpartx/dasd.c:263: formated ==> formatted
> multipath-tools/libmultipath/discovery.c:1808: unuseable ==> unusable
> multipath-tools/libmultipath/discovery.h:20: exerpt ==> excerpt
> multipath-tools/libmultipath/memory.c:150: formated ==> formatted
> multipath-tools/libmultipath/checkers/directio.c:84: Sucessfully ==>
> Successfully
> multipath-tools/libmultipath/prioritizers/hds.c:9: pathes ==> paths
> multipath-tools/libmultipath/prioritizers/hds.c:14: pathes ==> paths
> multipath-tools/libmultipath/prioritizers/ontap.c:119: Retuns ==> Returns
> multipath-tools/third-party/valgrind/valgrind.h:6828: arbitary ==>
> arbitrary
> multipath-tools/multipath/02_multipath:11: dynamicaly ==> dynamically
> multipath-tools/multipath/multipath.conf.5:793: remeber ==> remember
> multipath-tools/libmpathpersist/mpath_persist.h:15: lenght ==> length
>
> -------8<-------
> SUMMARY:
> arbitary 1
> dynamicaly 1
> exerpt 1
> formated 2
> lenght 1
> pathes 2
> remeber 1
> retuns 1
> sucessfully 1
> unuseable 1
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> kpartx/dasd.c | 2 +-
> libmpathpersist/mpath_persist.h | 2 +-
> libmultipath/checkers/directio.c | 2 +-
> libmultipath/discovery.c | 2 +-
> libmultipath/discovery.h | 2 +-
> libmultipath/memory.c | 2 +-
> libmultipath/prioritizers/hds.c | 4 ++--
> libmultipath/prioritizers/ontap.c | 2 +-
> multipath/02_multipath | 2 +-
> multipath/multipath.conf.5 | 2 +-
> 10 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/kpartx/dasd.c b/kpartx/dasd.c
> index faf5e2e..1206e45 100644
> --- a/kpartx/dasd.c
> +++ b/kpartx/dasd.c
> @@ -261,7 +261,7 @@ read_dasd_pt(int fd, struct slice all, struct slice
> *sp, int ns)
> fmt_size = sectors512(vlabel.formatted_
> blocks,
> blocksize);
> } else if (!strcmp(info.type, "ECKD")) {
> - /* formated w/o large volume support */
> + /* formatted w/o large volume support */
> fmt_size = geo.cylinders * geo.heads
> * geo.sectors * (blocksize >> 9);
> } else {
> diff --git a/libmpathpersist/mpath_persist.h b/libmpathpersist/mpath_
> persist.h
> index fde0416..79de5b5 100644
> --- a/libmpathpersist/mpath_persist.h
> +++ b/libmpathpersist/mpath_persist.h
> @@ -13,7 +13,7 @@ extern "C" {
> #define MPATH_MAX_PARAM_LEN 8192
>
> #define MPATH_MX_TIDS 32 /* Max number of transport ids"*/
> -#define MPATH_MX_TID_LEN 256 /* Max lenght of transport id */
> +#define MPATH_MX_TID_LEN 256 /* Max length of transport id */
>
> /* PRIN Service Actions */
> #define MPATH_PRIN_RKEY_SA 0x00 /* READ KEYS SA*/
> diff --git a/libmultipath/checkers/directio.c b/libmultipath/checkers/
> directio.c
> index eec12d5..ce60e4c 100644
> --- a/libmultipath/checkers/directio.c
> +++ b/libmultipath/checkers/directio.c
> @@ -82,7 +82,7 @@ int libcheck_init (struct checker * c)
> ct->ptr = (unsigned char *) (((unsigned long)ct->buf + pgsize - 1)
> &
> (~(pgsize - 1)));
>
> - /* Sucessfully initialized, return the context. */
> + /* Successfully initialized, return the context. */
> c->context = (void *) ct;
> return 0;
>
> diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
> index aaa915c..0f912ba 100644
> --- a/libmultipath/discovery.c
> +++ b/libmultipath/discovery.c
> @@ -1806,7 +1806,7 @@ int pathinfo(struct path *pp, struct config *conf,
> int mask)
> pp->state = PATH_DOWN;
> if (pp->state == PATH_UP && !pp->size) {
> condlog(3, "%s: device size is 0, "
> - "path unuseable", pp->dev);
> + "path unusable", pp->dev);
> pp->state = PATH_GHOST;
> }
> } else {
> diff --git a/libmultipath/discovery.h b/libmultipath/discovery.h
> index 97e5a32..3039268 100644
> --- a/libmultipath/discovery.h
> +++ b/libmultipath/discovery.h
> @@ -18,7 +18,7 @@
> #endif
>
> /*
> - * exerpt from sg_err.h
> + * excerpt from sg_err.h
> */
> #define SCSI_CHECK_CONDITION 0x2
> #define SCSI_COMMAND_TERMINATED 0x22
> diff --git a/libmultipath/memory.c b/libmultipath/memory.c
> index 293a688..ff5a030 100644
> --- a/libmultipath/memory.c
> +++ b/libmultipath/memory.c
> @@ -148,7 +148,7 @@ dbg_strdup(char *str, char *file, char *function, int
> line)
>
>
>
> -/* Display a buffer into a HEXA formated output */
> +/* Display a buffer into a HEXA formatted output */
> static void
> dump_buffer(char *buff, int count)
> {
> diff --git a/libmultipath/prioritizers/hds.c b/libmultipath/prioritizers/
> hds.c
> index d161e68..70fb5d1 100644
> --- a/libmultipath/prioritizers/hds.c
> +++ b/libmultipath/prioritizers/hds.c
> @@ -7,12 +7,12 @@
> * Prioritizer for Device Mapper Multipath and HDS Storage
> *
> * Hitachis Modular Storage contains two controllers for redundancy. The
> - * Storage internal LUN (LDEV) will normally allocated via two pathes to
> the
> + * Storage internal LUN (LDEV) will normally allocated via two paths to
> the
> * server (one path per controller). For performance reasons should the
> server
> * access to a LDEV only via one controller. The other path to the other
> * controller is stand-by. It is also possible to allocate more as one
> path
> * for a LDEV per controller. Here is active/active access allowed. The
> other
> - * pathes via the other controller are stand-by.
> + * paths via the other controller are stand-by.
> *
> * This prioritizer checks with inquiry command the represented LDEV and
> * Controller number and gives back a priority followed by this scheme:
> diff --git a/libmultipath/prioritizers/ontap.c
> b/libmultipath/prioritizers/ontap.c
> index 38495cd..ca06d6c 100644
> --- a/libmultipath/prioritizers/ontap.c
> +++ b/libmultipath/prioritizers/ontap.c
> @@ -117,7 +117,7 @@ out:
> }
>
> /*
> - * Retuns:
> + * Returns:
> * -1: Unable to obtain proxy info
> * 0: Device _not_ proxy path
> * 1: Device _is_ proxy path
> diff --git a/multipath/02_multipath b/multipath/02_multipath
> index 523f0ef..de6e247 100755
> --- a/multipath/02_multipath
> +++ b/multipath/02_multipath
> @@ -9,7 +9,7 @@ cp /sbin/kpartx $INITRDDIR/sbin
>
> #
> # feed the dependencies too
> -# scsi_id is dynamicaly linked, so store the libs too
> +# scsi_id is dynamically linked, so store the libs too
> #
> cp /lib/udev/scsi_id $INITRDDIR/lib/udev/
> cp /bin/mountpoint $INITRDDIR/bin
> diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
> index 8f5447d..c272dd6 100644
> --- a/multipath/multipath.conf.5
> +++ b/multipath/multipath.conf.5
> @@ -791,7 +791,7 @@ a path has the same WWID as a multipath device that
> was previously created
> while find_multipaths was set (even if that multipath device doesn't
> currently
> exist).
> Whenever a multipath device is created with find_multipaths set,
> multipath will
> -remeber the WWID of the device, so that it will automatically create the
> +remember the WWID of the device, so that it will automatically create the
> device again, as soon as it sees a path with that WWID. This should allow
> most
> users to have multipath automatically choose the correct paths to make
> into
> multipath devices, without having to edit the blacklist.
> --
> 2.10.2
>
>
[-- Attachment #1.2: Type: text/html, Size: 9981 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] multipath-tools: fix misspellings
2017-02-16 19:23 [PATCH] multipath-tools: git should ignore rej and orig files Xose Vazquez Perez
@ 2017-02-16 19:23 ` Xose Vazquez Perez
2017-02-27 5:35 ` Christophe Varoqui
0 siblings, 1 reply; 7+ messages in thread
From: Xose Vazquez Perez @ 2017-02-16 19:23 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
debuging->debugging
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
multipathd/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/multipathd/Makefile b/multipathd/Makefile
index ae06f9e..d57f6d5 100644
--- a/multipathd/Makefile
+++ b/multipathd/Makefile
@@ -1,7 +1,7 @@
include ../Makefile.inc
#
-# debuging stuff
+# debugging stuff
#
#CFLAGS += -DLCKDBG
#CFLAGS += -D_DEBUG_
--
2.11.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: fix misspellings
2017-02-16 19:23 ` [PATCH] multipath-tools: fix misspellings Xose Vazquez Perez
@ 2017-02-27 5:35 ` Christophe Varoqui
0 siblings, 0 replies; 7+ messages in thread
From: Christophe Varoqui @ 2017-02-27 5:35 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 687 bytes --]
Applied.
On Thu, Feb 16, 2017 at 8:23 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:
> debuging->debugging
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> multipathd/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/multipathd/Makefile b/multipathd/Makefile
> index ae06f9e..d57f6d5 100644
> --- a/multipathd/Makefile
> +++ b/multipathd/Makefile
> @@ -1,7 +1,7 @@
> include ../Makefile.inc
>
> #
> -# debuging stuff
> +# debugging stuff
> #
> #CFLAGS += -DLCKDBG
> #CFLAGS += -D_DEBUG_
> --
> 2.11.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 1288 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] multipath-tools: fix misspellings
@ 2018-03-08 23:08 Xose Vazquez Perez
0 siblings, 0 replies; 7+ messages in thread
From: Xose Vazquez Perez @ 2018-03-08 23:08 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Done with https://github.com/lucasdemarchi/codespell
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
kpartx/devmapper.c | 2 +-
kpartx/solaris.c | 2 +-
kpartx/test-kpartx | 2 +-
libdmmp/DEV_NOTES | 2 +-
libdmmp/libdmmp.c | 2 +-
libmpathpersist/mpath_persist.c | 2 +-
libmultipath/foreign.h | 16 ++++++++--------
libmultipath/memory.c | 2 +-
libmultipath/parser.c | 2 +-
libmultipath/prioritizers/alua_spc3.h | 4 ++--
libmultipath/uevent.c | 2 +-
multipathd/cli.c | 2 +-
multipathd/main.c | 4 ++--
13 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/kpartx/devmapper.c b/kpartx/devmapper.c
index eb9dac6..8f68a24 100644
--- a/kpartx/devmapper.c
+++ b/kpartx/devmapper.c
@@ -302,7 +302,7 @@ out:
/*
* dm_get_first_dep
*
- * Return the device number of the first dependend device
+ * Return the device number of the first dependent device
* for a given target.
*/
dev_t dm_get_first_dep(char *devname)
diff --git a/kpartx/solaris.c b/kpartx/solaris.c
index 01da379..8c1a971 100644
--- a/kpartx/solaris.c
+++ b/kpartx/solaris.c
@@ -10,7 +10,7 @@
struct solaris_x86_slice {
unsigned short s_tag; /* ID tag of partition */
- unsigned short s_flag; /* permision flags */
+ unsigned short s_flag; /* permission flags */
long s_start; /* start sector no of partition */
long s_size; /* # of blocks in partition */
};
diff --git a/kpartx/test-kpartx b/kpartx/test-kpartx
index 09d15a9..9cee20f 100755
--- a/kpartx/test-kpartx
+++ b/kpartx/test-kpartx
@@ -22,7 +22,7 @@
# stale DM or loop devices may keep lurking around.
# Set WORKDIR in environment to existing dir to for persistence
-# WARNING: exisiting files will be truncated.
+# WARNING: existing files will be truncated.
# If empty, test will be done in temporary dir
: ${WORKDIR:=}
# Set this environment variable to test an alternative kpartx executable
diff --git a/libdmmp/DEV_NOTES b/libdmmp/DEV_NOTES
index 220a9f4..3460cdf 100644
--- a/libdmmp/DEV_NOTES
+++ b/libdmmp/DEV_NOTES
@@ -1,4 +1,4 @@
-== Planed features ==
+== Planned features ==
* Expose all properties used by /usr/bin/multipath
== Code style ==
diff --git a/libdmmp/libdmmp.c b/libdmmp/libdmmp.c
index 944cecd..aafd509 100644
--- a/libdmmp/libdmmp.c
+++ b/libdmmp/libdmmp.c
@@ -304,7 +304,7 @@ static int _process_cmd(struct dmmp_context *ctx, int fd, const char *cmd,
ipc_tmo = _DEFAULT_UXSOCK_TIMEOUT;
invoke:
- _debug(ctx, "Invoking IPC command '%s' with IPC tmo %u miliseconds",
+ _debug(ctx, "Invoking IPC command '%s' with IPC tmo %u milliseconds",
cmd, ipc_tmo);
flag_check_tmo = false;
if (mpath_process_cmd(fd, cmd, output, ipc_tmo) != 0) {
diff --git a/libmpathpersist/mpath_persist.c b/libmpathpersist/mpath_persist.c
index 84ab293..5199e42 100644
--- a/libmpathpersist/mpath_persist.c
+++ b/libmpathpersist/mpath_persist.c
@@ -493,7 +493,7 @@ int mpath_prout_reg(struct multipath *mpp,int rq_servact, int rq_scope,
thread[i].param.noisy = noisy;
thread[i].param.status = MPATH_PR_SKIP;
- condlog (3, "THRED ID [%d] INFO]", i);
+ condlog (3, "THREAD ID [%d] INFO]", i);
condlog (3, "rq_servact=%d ", thread[i].param.rq_servact);
condlog (3, "rq_scope=%d ", thread[i].param.rq_scope);
condlog (3, "rq_type=%d ", thread[i].param.rq_type);
diff --git a/libmultipath/foreign.h b/libmultipath/foreign.h
index 0ade2d7..973f368 100644
--- a/libmultipath/foreign.h
+++ b/libmultipath/foreign.h
@@ -74,7 +74,7 @@ struct foreign {
* @retval FOREIGN_CLAIMED: device newly claimed
* @retval FOREIGN_OK: device already registered, no action taken
* @retval FOREIGN_IGNORED: device is ignored, no action taken
- * @retval FOREIGN_ERR: an error occured (e.g. out-of-memory)
+ * @retval FOREIGN_ERR: an error occurred (e.g. out-of-memory)
*/
int (*add)(struct context *, struct udev_device *);
@@ -87,7 +87,7 @@ struct foreign {
* @returns status code
* @retval FOREIGN_OK: event processed
* @retval FOREIGN_IGNORED: the device is ignored
- * @retval FOREIGN_ERR: an error occured (e.g. out-of-memory)
+ * @retval FOREIGN_ERR: an error occurred (e.g. out-of-memory)
*
* Note: theoretically it can happen that the status of a foreign device
* (claimed vs. not claimed) changes in a change event.
@@ -107,7 +107,7 @@ struct foreign {
* @returns status code
* @retval FOREIGN_OK: processed correctly (device deleted)
* @retval FOREIGN_IGNORED: device wasn't registered internally
- * @retval FOREIGN_ERR: error occured.
+ * @retval FOREIGN_ERR: error occurred.
*/
int (*delete)(struct context *, struct udev_device *);
@@ -120,7 +120,7 @@ struct foreign {
* @returns status code
* @retval FOREIGN_OK: processed correctly
* @retval FOREIGN_IGNORED: nothing to delete
- * @retval FOREIGN_ERR: error occured
+ * @retval FOREIGN_ERR: error occurred
*/
int (*delete_all)(struct context*);
@@ -135,13 +135,13 @@ struct foreign {
void (*check)(struct context *);
/**
- * lock internal data stuctures.
+ * lock internal data structures.
* @param[in] ctx: foreign context
*/
void (*lock)(struct context *ctx);
/**
- * unlock internal data stuctures.
+ * unlock internal data structures.
* @param[in] ctx: foreign context (void* in order to use the function
* as argument to pthread_cleanup_push())
*/
@@ -217,7 +217,7 @@ void cleanup_foreign(void);
* @retval FOREIGN_CLAIMED: newly claimed by a foreign lib
* @retval FOREIGN_OK: already claimed by a foreign lib
* @retval FOREIGN_IGNORED: ignored by all foreign libs
- * @retval FOREIGN_ERR: an error occured
+ * @retval FOREIGN_ERR: an error occurred
*/
int add_foreign(struct udev_device *);
@@ -309,7 +309,7 @@ void print_foreign_topology(int verbosity);
/**
* is_claimed_by_foreign(ud)
* @param udev: udev device
- * @returns: true iff device is (newly or already) claimed by a foreign lib
+ * @returns: true if device is (newly or already) claimed by a foreign lib
*/
static inline bool
is_claimed_by_foreign(struct udev_device *ud)
diff --git a/libmultipath/memory.c b/libmultipath/memory.c
index ff5a030..7514642 100644
--- a/libmultipath/memory.c
+++ b/libmultipath/memory.c
@@ -38,7 +38,7 @@
* ! 9 ! Allocated !
* +----+-----------------------+
*
- * global variabel debug bit 9 ( 512 ) used to
+ * global variable debug bit 9 ( 512 ) used to
* flag some memory error.
*
*/
diff --git a/libmultipath/parser.c b/libmultipath/parser.c
index 5caa201..d3f6a91 100644
--- a/libmultipath/parser.c
+++ b/libmultipath/parser.c
@@ -550,7 +550,7 @@ process_file(struct config *conf, char *file)
FILE *stream;
if (!conf->keywords) {
- condlog(0, "No keywords alocated");
+ condlog(0, "No keywords allocated");
return 1;
}
stream = fopen(file, "r");
diff --git a/libmultipath/prioritizers/alua_spc3.h b/libmultipath/prioritizers/alua_spc3.h
index 13a0924..6790db9 100644
--- a/libmultipath/prioritizers/alua_spc3.h
+++ b/libmultipath/prioritizers/alua_spc3.h
@@ -119,7 +119,7 @@ struct inquiry_data {
unsigned char b0; /* xxx..... = peripheral_qualifier */
/* ...xxxxx = peripheral_device_type */
unsigned char b1; /* x....... = removable medium */
- /* .xxxxxxx = reserverd */
+ /* .xxxxxxx = reserved */
unsigned char version;
unsigned char b3; /* xx...... = obsolete */
/* ..x..... = normal aca supported */
@@ -238,7 +238,7 @@ struct vpd83_data {
)
/*=============================================================================
- * The following stuctures and macros are used to call the report target port
+ * The following structures and macros are used to call the report target port
* groups command defined in SPC-3.
* This command is used to get information about the target port groups (which
* states are supported, which ports belong to this group, and so on) and the
diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c
index 685ef33..ac4fa0f 100644
--- a/libmultipath/uevent.c
+++ b/libmultipath/uevent.c
@@ -259,7 +259,7 @@ merge_need_stop(struct uevent *earlier, struct uevent *later)
if (!earlier->wwid || !later->wwid)
return true;
/*
- * uevents merging stoped
+ * uevents merging stopped
* when we meet an opposite action uevent from the same LUN to AVOID
* "add path1 |remove path1 |add path2 |remove path2 |add path3"
* to merge as "remove path1, path2" and "add path1, path2, path3"
diff --git a/multipathd/cli.c b/multipathd/cli.c
index f10f862..6d86e81 100644
--- a/multipathd/cli.c
+++ b/multipathd/cli.c
@@ -621,7 +621,7 @@ key_generator (const char * str, int state)
len = strlen(str);
int r = get_cmdvec(rl_line_buffer, &v);
/*
- * If a word completion is in progess, we don't want
+ * If a word completion is in progress, we don't want
* to take an exact keyword match in the fingerprint.
* For ex "show map[tab]" would validate "map" and discard
* "maps" as a valid candidate.
diff --git a/multipathd/main.c b/multipathd/main.c
index 327cc19..6c8df84 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -826,7 +826,7 @@ ev_remove_path (struct path *pp, struct vectors * vecs, int need_do_map)
vector_del_slot(mpp->paths, i);
/*
- * remove the map IFF removing the last path
+ * remove the map IF removing the last path
*/
if (VECTOR_SIZE(mpp->paths) == 0) {
char alias[WWID_SIZE];
@@ -1435,7 +1435,7 @@ defered_failback_tick (vector mpvec)
vector_foreach_slot (mpvec, mpp, i) {
/*
- * defered failback getting sooner
+ * deferred failback getting sooner
*/
if (mpp->pgfailback > 0 && mpp->failback_tick > 0) {
mpp->failback_tick--;
--
2.14.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] multipath-tools: fix misspellings
@ 2025-05-09 12:54 Xose Vazquez Perez
2025-05-09 14:19 ` Martin Wilck
0 siblings, 1 reply; 7+ messages in thread
From: Xose Vazquez Perez @ 2025-05-09 12:54 UTC (permalink / raw)
Cc: Xose Vazquez Perez, Martin Wilck, Benjamin Marzinski,
Christophe Varoqui, DM-DEVEL ML
codespell:
./tests/mapinfo.c:964: ouput ==> output
./libmultipath/devmapper.h:118: paramters ==> parameters
./libmpathutil/uxsock.c:69: everone ==> everyone
===============
SUMMARY:
everone 1
ouput 1
paramters 1
Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmpathutil/uxsock.c | 2 +-
libmultipath/devmapper.h | 2 +-
tests/mapinfo.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libmpathutil/uxsock.c b/libmpathutil/uxsock.c
index 59c47170..02b387d0 100644
--- a/libmpathutil/uxsock.c
+++ b/libmpathutil/uxsock.c
@@ -66,7 +66,7 @@ int ux_socket_listen(const char *name)
}
/*
- * Socket needs to have rw permissions for everone.
+ * Socket needs to have rw permissions for everyone.
* SO_PEERCRED makes sure that only root can modify things.
*/
if (name[0] != '@' &&
diff --git a/libmultipath/devmapper.h b/libmultipath/devmapper.h
index 4aeefad1..c0f7aa0d 100644
--- a/libmultipath/devmapper.h
+++ b/libmultipath/devmapper.h
@@ -115,7 +115,7 @@ typedef struct libmp_map_info {
*
* This function obtains the requested information for the device-mapper map
* identified by the input parameters.
- * If non-NULL, the name, uuid, and dmi output paramters may be filled in for
+ * If non-NULL, the name, uuid, and dmi output parameters may be filled in for
* any return value besides DMP_NOT_FOUND and will always be filled in for
* return values other than DMP_NOT_FOUND and DMP_ERR.
* The other parameters are only filled in if the return value is DMP_OK.
diff --git a/tests/mapinfo.c b/tests/mapinfo.c
index 36511607..399e16e7 100644
--- a/tests/mapinfo.c
+++ b/tests/mapinfo.c
@@ -961,7 +961,7 @@ static void test_mapinfo_bad_target_type_03(void **state)
(mapid_t) { .str = "foo", },
(mapinfo_t) { .dmi = &dmi, .name = name, .uuid = uuid });
assert_int_equal(rc, DMP_NO_MATCH);
- /* make sure that the ouput was filled in */
+ /* make sure that the output was filled in */
assert_memory_equal(&dmi, &MPATH_DMI_01, sizeof(dmi));
assert_true(!strcmp(name, MPATH_NAME_01));
assert_true(!strcmp(uuid, MPATH_UUID_01));
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: fix misspellings
2025-05-09 12:54 Xose Vazquez Perez
@ 2025-05-09 14:19 ` Martin Wilck
0 siblings, 0 replies; 7+ messages in thread
From: Martin Wilck @ 2025-05-09 14:19 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: Benjamin Marzinski, Christophe Varoqui, DM-DEVEL ML
Hello Xose,
On Fri, 2025-05-09 at 14:54 +0200, Xose Vazquez Perez wrote:
> codespell:
> ./tests/mapinfo.c:964: ouput ==> output
> ./libmultipath/devmapper.h:118: paramters ==> parameters
> ./libmpathutil/uxsock.c:69: everone ==> everyone
As you may know, a spell checker is part of our regular GitHub CI [1].
This checker has found a large amount of spelling errors in our code
base when we first tried it. We therefore decided to restrict it to
user-visible parts of the code, i.e. error messages, man pages, READMEs
etc.
While there's nothing wrong with your patch per se, I am hesitant to
apply it, because if we start fixing spelling errors in comments, we
should be consequent and eliminate all spelling mistakes, which would
cause a large number of code changes that are irrelevant to
functionality. That, in turn, would make it more difficult to assess
future code changes for regressions and bug fixes.
I'd like to continue following a policy of small changes. That means
that we fix things like indentation, formatting, whitespace, and
spelling only in those places of the code which we actually make
changes for.
This is just my personal preference of course. I'm open for discussion.
Regards
Martin
[1] https://github.com/opensvc/multipath-tools/actions/workflows/spelling.yml
>
> ===============
> SUMMARY:
> everone 1
> ouput 1
> paramters 1
>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmpathutil/uxsock.c | 2 +-
> libmultipath/devmapper.h | 2 +-
> tests/mapinfo.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libmpathutil/uxsock.c b/libmpathutil/uxsock.c
> index 59c47170..02b387d0 100644
> --- a/libmpathutil/uxsock.c
> +++ b/libmpathutil/uxsock.c
> @@ -66,7 +66,7 @@ int ux_socket_listen(const char *name)
> }
>
> /*
> - * Socket needs to have rw permissions for everone.
> + * Socket needs to have rw permissions for everyone.
> * SO_PEERCRED makes sure that only root can modify things.
> */
> if (name[0] != '@' &&
> diff --git a/libmultipath/devmapper.h b/libmultipath/devmapper.h
> index 4aeefad1..c0f7aa0d 100644
> --- a/libmultipath/devmapper.h
> +++ b/libmultipath/devmapper.h
> @@ -115,7 +115,7 @@ typedef struct libmp_map_info {
> *
> * This function obtains the requested information for the device-
> mapper map
> * identified by the input parameters.
> - * If non-NULL, the name, uuid, and dmi output paramters may be
> filled in for
> + * If non-NULL, the name, uuid, and dmi output parameters may be
> filled in for
> * any return value besides DMP_NOT_FOUND and will always be filled
> in for
> * return values other than DMP_NOT_FOUND and DMP_ERR.
> * The other parameters are only filled in if the return value is
> DMP_OK.
> diff --git a/tests/mapinfo.c b/tests/mapinfo.c
> index 36511607..399e16e7 100644
> --- a/tests/mapinfo.c
> +++ b/tests/mapinfo.c
> @@ -961,7 +961,7 @@ static void test_mapinfo_bad_target_type_03(void
> **state)
> (mapid_t) { .str = "foo", },
> (mapinfo_t) { .dmi = &dmi, .name = name,
> .uuid = uuid });
> assert_int_equal(rc, DMP_NO_MATCH);
> - /* make sure that the ouput was filled in */
> + /* make sure that the output was filled in */
> assert_memory_equal(&dmi, &MPATH_DMI_01, sizeof(dmi));
> assert_true(!strcmp(name, MPATH_NAME_01));
> assert_true(!strcmp(uuid, MPATH_UUID_01));
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-05-09 14:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-26 1:33 [PATCH] multipath-tools: fix misspellings Xose Vazquez Perez
2016-11-26 9:11 ` Christophe Varoqui
-- strict thread matches above, loose matches on Subject: below --
2017-02-16 19:23 [PATCH] multipath-tools: git should ignore rej and orig files Xose Vazquez Perez
2017-02-16 19:23 ` [PATCH] multipath-tools: fix misspellings Xose Vazquez Perez
2017-02-27 5:35 ` Christophe Varoqui
2018-03-08 23:08 Xose Vazquez Perez
2025-05-09 12:54 Xose Vazquez Perez
2025-05-09 14:19 ` Martin Wilck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox