From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>,
dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH 3/6] libmultipath: config parser: don't strip whitepace between quotes
Date: Tue, 6 Mar 2018 23:56:30 +0100 [thread overview]
Message-ID: <20180306225633.12028-4-mwilck@suse.com> (raw)
In-Reply-To: <20180306225633.12028-1-mwilck@suse.com>
Between double quotes, the parser currently strips leading (but not
trailing) whitespace. That's inconsistent and unexpected. Fix it.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/parser.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libmultipath/parser.c b/libmultipath/parser.c
index 5caa2019a1a4..3d9656f47945 100644
--- a/libmultipath/parser.c
+++ b/libmultipath/parser.c
@@ -262,7 +262,8 @@ alloc_strvec(char *string)
}
vector_set_slot(strvec, token);
- while ((isspace((int) *cp) || !isascii((int) *cp))
+ while ((!in_string &&
+ (isspace((int) *cp) || !isascii((int) *cp)))
&& *cp != '\0')
cp++;
if (*cp == '\0' || *cp == '!' || *cp == '#')
--
2.16.1
next prev parent reply other threads:[~2018-03-06 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 22:56 [PATCH 0/6] Fixes for config file parsing Martin Wilck
2018-03-06 22:56 ` [PATCH 1/6] tests/uevent: fix -Wcast-qual errors Martin Wilck
2018-03-06 22:56 ` [PATCH 2/6] tests: add unit tests for config file parser Martin Wilck
2018-03-06 22:56 ` Martin Wilck [this message]
2018-03-06 22:56 ` [PATCH 4/6] libmultipath: config parser: Allow '"' in strings Martin Wilck
2018-03-06 22:56 ` [PATCH 5/6] libmultipath: config parser: fix corner case for double quotes Martin Wilck
2018-03-06 22:56 ` [PATCH 6/6] multipath.conf(5): improve syntax documentation Martin Wilck
2018-03-06 23:06 ` [PATCH 0/6] Fixes for config file parsing Martin Wilck
2018-03-07 18:25 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306225633.12028-4-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox