From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>,
dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH 4/6] libmultipath: config parser: Allow '"' in strings
Date: Tue, 6 Mar 2018 23:56:31 +0100 [thread overview]
Message-ID: <20180306225633.12028-5-mwilck@suse.com> (raw)
In-Reply-To: <20180306225633.12028-1-mwilck@suse.com>
We have seen model strings lile '2.5" SSD' which can't be parsed
by the current config parser. This patch fixes this by allowing
'""' to represent a double quote character inside a a string.
The above model string could now be entered in the config file like this:
blacklist {
vendor SomeCorp
product "2.5"" SSD"
}
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/parser.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/libmultipath/parser.c b/libmultipath/parser.c
index 3d9656f47945..592269a9b5b1 100644
--- a/libmultipath/parser.c
+++ b/libmultipath/parser.c
@@ -223,7 +223,7 @@ alloc_strvec(char *string)
goto out;
start = cp;
- if (*cp == '"') {
+ if (!in_string && *cp == '"') {
cp++;
token = MALLOC(2);
@@ -246,11 +246,25 @@ alloc_strvec(char *string)
*(token + 1) = '\0';
cp++;
} else {
+ int two_quotes = 0;
+
+ move_on:
while ((in_string ||
(!isspace((int) *cp) && isascii((int) *cp) &&
*cp != '!' && *cp != '#' && *cp != '{' &&
*cp != '}')) && *cp != '\0' && *cp != '"')
cp++;
+
+ /* Two consecutive double quotes - don't end string */
+ if (in_string && *cp == '"') {
+ if (*(cp + 1) == '"') {
+ two_quotes = 1;
+ cp += 2;
+ goto move_on;
+ } else
+ in_string = 0;
+ }
+
strlen = cp - start;
token = MALLOC(strlen + 1);
@@ -259,6 +273,16 @@ alloc_strvec(char *string)
memcpy(token, start, strlen);
*(token + strlen) = '\0';
+
+ /* Replace "" by " */
+ if (two_quotes) {
+ char *qq = strstr(token, "\"\"");
+ while (qq != NULL) {
+ memmove(qq + 1, qq + 2,
+ strlen + 1 - (qq + 2 - token));
+ qq = strstr(qq + 1, "\"\"");
+ }
+ }
}
vector_set_slot(strvec, token);
--
2.16.1
next prev parent reply other threads:[~2018-03-06 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 22:56 [PATCH 0/6] Fixes for config file parsing Martin Wilck
2018-03-06 22:56 ` [PATCH 1/6] tests/uevent: fix -Wcast-qual errors Martin Wilck
2018-03-06 22:56 ` [PATCH 2/6] tests: add unit tests for config file parser Martin Wilck
2018-03-06 22:56 ` [PATCH 3/6] libmultipath: config parser: don't strip whitepace between quotes Martin Wilck
2018-03-06 22:56 ` Martin Wilck [this message]
2018-03-06 22:56 ` [PATCH 5/6] libmultipath: config parser: fix corner case for double quotes Martin Wilck
2018-03-06 22:56 ` [PATCH 6/6] multipath.conf(5): improve syntax documentation Martin Wilck
2018-03-06 23:06 ` [PATCH 0/6] Fixes for config file parsing Martin Wilck
2018-03-07 18:25 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306225633.12028-5-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox