From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH] libmultipath: Fix logic in should_multipath
Date: Fri, 13 Apr 2018 19:20:42 +0200 [thread overview]
Message-ID: <20180413172042.11820-1-mwilck@suse.com> (raw)
Commit d3b71498 missed a negation.
Fixes: d3b71498 "multipath: fix rcu thread cancellation hang"
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/wwids.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
index 0ec9f25b..8c21b33f 100644
--- a/libmultipath/wwids.c
+++ b/libmultipath/wwids.c
@@ -284,7 +284,7 @@ should_multipath(struct path *pp1, vector pathvec)
ignore_new_devs = conf->ignore_new_devs;
find_multipaths = conf->find_multipaths;
put_multipath_config(conf);
- if (find_multipaths && !ignore_new_devs)
+ if (!find_multipaths && !ignore_new_devs)
return 1;
condlog(4, "checking if %s should be multipathed", pp1->dev);
--
2.16.1
next reply other threads:[~2018-04-13 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 17:20 Martin Wilck [this message]
2018-04-13 17:28 ` [PATCH] libmultipath: Fix logic in should_multipath Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413172042.11820-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox