Re: [PATCH] libmultipath: Fix logic in should_multipath

["Benjamin Marzinski" <bmarzins@redhat.com>]

On Fri, Apr 13, 2018 at 07:20:42PM +0200, Martin Wilck wrote:
> Commit d3b71498 missed a negation.

Oops. Thanks for the catch.

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> 
> Fixes: d3b71498 "multipath: fix rcu thread cancellation hang"
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  libmultipath/wwids.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
> index 0ec9f25b..8c21b33f 100644
> --- a/libmultipath/wwids.c
> +++ b/libmultipath/wwids.c
> @@ -284,7 +284,7 @@ should_multipath(struct path *pp1, vector pathvec)
>  	ignore_new_devs = conf->ignore_new_devs;
>  	find_multipaths = conf->find_multipaths;
>  	put_multipath_config(conf);
> -	if (find_multipaths && !ignore_new_devs)
> +	if (!find_multipaths && !ignore_new_devs)
>  		return 1;
>  
>  	condlog(4, "checking if %s should be multipathed", pp1->dev);
> -- 
> 2.16.1