* [PATCH] libmultipath: Fix logic in should_multipath
@ 2018-04-13 17:20 Martin Wilck
2018-04-13 17:28 ` Benjamin Marzinski
0 siblings, 1 reply; 2+ messages in thread
From: Martin Wilck @ 2018-04-13 17:20 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
Commit d3b71498 missed a negation.
Fixes: d3b71498 "multipath: fix rcu thread cancellation hang"
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/wwids.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
index 0ec9f25b..8c21b33f 100644
--- a/libmultipath/wwids.c
+++ b/libmultipath/wwids.c
@@ -284,7 +284,7 @@ should_multipath(struct path *pp1, vector pathvec)
ignore_new_devs = conf->ignore_new_devs;
find_multipaths = conf->find_multipaths;
put_multipath_config(conf);
- if (find_multipaths && !ignore_new_devs)
+ if (!find_multipaths && !ignore_new_devs)
return 1;
condlog(4, "checking if %s should be multipathed", pp1->dev);
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libmultipath: Fix logic in should_multipath
2018-04-13 17:20 [PATCH] libmultipath: Fix logic in should_multipath Martin Wilck
@ 2018-04-13 17:28 ` Benjamin Marzinski
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Marzinski @ 2018-04-13 17:28 UTC (permalink / raw)
To: Martin Wilck; +Cc: dm-devel
On Fri, Apr 13, 2018 at 07:20:42PM +0200, Martin Wilck wrote:
> Commit d3b71498 missed a negation.
Oops. Thanks for the catch.
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
>
> Fixes: d3b71498 "multipath: fix rcu thread cancellation hang"
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> libmultipath/wwids.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/wwids.c b/libmultipath/wwids.c
> index 0ec9f25b..8c21b33f 100644
> --- a/libmultipath/wwids.c
> +++ b/libmultipath/wwids.c
> @@ -284,7 +284,7 @@ should_multipath(struct path *pp1, vector pathvec)
> ignore_new_devs = conf->ignore_new_devs;
> find_multipaths = conf->find_multipaths;
> put_multipath_config(conf);
> - if (find_multipaths && !ignore_new_devs)
> + if (!find_multipaths && !ignore_new_devs)
> return 1;
>
> condlog(4, "checking if %s should be multipathed", pp1->dev);
> --
> 2.16.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-13 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-13 17:20 [PATCH] libmultipath: Fix logic in should_multipath Martin Wilck
2018-04-13 17:28 ` Benjamin Marzinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox