Linux Device Mapper development
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>,
	Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Subject: [PATCH v3 0/3] Fix DM DAX handling
Date: Tue, 26 Jun 2018 11:59:29 -0600	[thread overview]
Message-ID: <20180626175932.8899-1-ross.zwisler@linux.intel.com> (raw)

This series fixes a few issues that I found with DM's handling of DAX
devices.  Here are some of the issues I found:

 * We can create a dm-stripe or dm-linear device which is made up of an
   fsdax PMEM namespace and a raw PMEM namespace but which can hold a
   filesystem mounted with the -o dax mount option.  DAX operations to
   the raw PMEM namespace part lack struct page and can fail in
   interesting/unexpected ways when doing things like fork(), examining
   memory with gdb, etc.

 * We can create a dm-stripe or dm-linear device which is made up of an
   fsdax PMEM namespace and a BRD ramdisk which can hold a filesystem
   mounted with the -o dax mount option.  All I/O to this filesystem
   will fail.

---

Changes since v2:
  * Only set QUEUE_FLAG_DAX for fsdax mode PMEM namespaces. (Mike)
  * Check for QUEUE_FLAG_DAX in __bdev_dax_supported(). (Mike)
  * Get rid of DM_TYPE_DAX_BIO_BASED reworks. (Mike)
  * Dropped the first 2 prep patches of v2 since they were merged for
    v4.18-rc1.  (Thanks, Darrick!)

---

Mike, can you take this series through your tree?

Personally I think this should be treated as a bug fix and merged in the
v4.18-rc* series.

Ross Zwisler (3):
  pmem: only set QUEUE_FLAG_DAX for fsdax mode
  dax: bdev_dax_supported() check for QUEUE_FLAG_DAX
  dm: prevent DAX mounts if not supported

 drivers/dax/super.c           | 8 ++++++++
 drivers/md/dm-ioctl.c         | 5 +++++
 drivers/md/dm-table.c         | 7 +++----
 drivers/md/dm.c               | 3 +--
 drivers/nvdimm/pmem.c         | 3 ++-
 include/linux/device-mapper.h | 5 +++++
 6 files changed, 24 insertions(+), 7 deletions(-)

-- 
2.14.4

             reply	other threads:[~2018-06-26 17:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 17:59 Ross Zwisler [this message]
     [not found] ` <20180626175932.8899-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-26 17:59   ` [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Ross Zwisler
     [not found]     ` <20180626175932.8899-2-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-26 18:52       ` Dan Williams
2018-06-26 18:58         ` Mike Snitzer
     [not found]           ` <20180626185830.GA7171-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-06-26 19:07             ` Dan Williams
     [not found]               ` <CAPcyv4h6HO6fs6k7QMD77jkz2djCeWCtWomCdNb0-1Q4VKanqw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-26 19:12                 ` Ross Zwisler
2018-06-26 19:13                 ` Mike Snitzer
     [not found]                   ` <20180626191346.GA7233-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-06-26 19:19                     ` Dan Williams
2018-06-26 20:54                     ` Kani, Toshi
     [not found]                       ` <1530046327.14039.273.camel-ZPxbGqLxI0U@public.gmane.org>
2018-06-26 21:02                         ` Dan Williams
     [not found]                           ` <CAPcyv4hP_Y3xdyCa-UkYCMJ5OtnjnkwPZDS2Z2Ge8+5ymBONwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-06-26 21:23                             ` Kani, Toshi
     [not found]                               ` <1530048093.14039.286.camel-ZPxbGqLxI0U@public.gmane.org>
2018-06-26 21:28                                 ` Dan Williams
2018-06-26 21:31                                   ` Kani, Toshi
     [not found]                                     ` <1530048545.14039.288.camel-ZPxbGqLxI0U@public.gmane.org>
2018-06-26 21:51                                       ` Dan Williams
2018-06-26 22:04                                         ` Ross Zwisler
     [not found]                                           ` <20180626220430.GA4269-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-28 17:42                                             ` Kani, Toshi
2018-06-28 17:48                                               ` Mike Snitzer
     [not found]                                                 ` <20180628174815.GA18768-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-06-28 17:59                                                   ` Dan Williams
2018-06-28 18:01                                                   ` Kani, Toshi
     [not found]                                               ` <1530207635.14039.308.camel-ZPxbGqLxI0U@public.gmane.org>
2018-06-28 19:04                                                 ` Ross Zwisler
     [not found]                                                   ` <20180628190424.GC17758-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-28 19:40                                                     ` Kani, Toshi
2018-06-26 19:11             ` Ross Zwisler
2018-06-26 17:59   ` [PATCH v3 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX Ross Zwisler
2018-06-26 17:59   ` [PATCH v3 3/3] dm: prevent DAX mounts if not supported Ross Zwisler
     [not found]     ` <20180626175932.8899-4-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-26 18:17       ` Mike Snitzer
2018-06-26 19:01       ` [PATCH v4 " Ross Zwisler
2018-06-26 18:48   ` [PATCH v3 0/3] Fix DM DAX handling Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626175932.8899-1-ross.zwisler@linux.intel.com \
    --to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=toshi.kani-ZPxbGqLxI0U@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox