* [PATCH] dm snapshot: don't define direct_access if we don't support it
@ 2019-02-27 17:02 Mikulas Patocka
2019-02-27 17:27 ` Mike Snitzer
0 siblings, 1 reply; 2+ messages in thread
From: Mikulas Patocka @ 2019-02-27 17:02 UTC (permalink / raw)
To: Mike Snitzer; +Cc: dm-devel
Don't define a direct_access function that fails, dm_dax_direct_access
already fails with -EIO if the pointer is zero;
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/md/dm-snap.c | 8 --------
1 file changed, 8 deletions(-)
Index: linux-2.6/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-snap.c 2019-02-27 17:57:19.000000000 +0100
+++ linux-2.6/drivers/md/dm-snap.c 2019-02-27 17:57:47.000000000 +0100
@@ -2338,13 +2338,6 @@ static int origin_map(struct dm_target *
return do_origin(o->dev, bio);
}
-static long origin_dax_direct_access(struct dm_target *ti, pgoff_t pgoff,
- long nr_pages, void **kaddr, pfn_t *pfn)
-{
- DMWARN("device does not support dax.");
- return -EIO;
-}
-
/*
* Set the target "max_io_len" field to the minimum of all the snapshots'
* chunk sizes.
@@ -2404,7 +2397,6 @@ static struct target_type origin_target
.postsuspend = origin_postsuspend,
.status = origin_status,
.iterate_devices = origin_iterate_devices,
- .direct_access = origin_dax_direct_access,
};
static struct target_type snapshot_target = {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dm snapshot: don't define direct_access if we don't support it
2019-02-27 17:02 [PATCH] dm snapshot: don't define direct_access if we don't support it Mikulas Patocka
@ 2019-02-27 17:27 ` Mike Snitzer
0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2019-02-27 17:27 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: dm-devel
On Wed, Feb 27 2019 at 12:02pm -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Don't define a direct_access function that fails, dm_dax_direct_access
> already fails with -EIO if the pointer is zero;
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
> ---
> drivers/md/dm-snap.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> Index: linux-2.6/drivers/md/dm-snap.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/dm-snap.c 2019-02-27 17:57:19.000000000 +0100
> +++ linux-2.6/drivers/md/dm-snap.c 2019-02-27 17:57:47.000000000 +0100
> @@ -2338,13 +2338,6 @@ static int origin_map(struct dm_target *
> return do_origin(o->dev, bio);
> }
>
> -static long origin_dax_direct_access(struct dm_target *ti, pgoff_t pgoff,
> - long nr_pages, void **kaddr, pfn_t *pfn)
> -{
> - DMWARN("device does not support dax.");
> - return -EIO;
> -}
> -
> /*
> * Set the target "max_io_len" field to the minimum of all the snapshots'
> * chunk sizes.
> @@ -2404,7 +2397,6 @@ static struct target_type origin_target
> .postsuspend = origin_postsuspend,
> .status = origin_status,
> .iterate_devices = origin_iterate_devices,
> - .direct_access = origin_dax_direct_access,
> };
>
> static struct target_type snapshot_target = {
Applied to dm-5.1 branch, thanks.
Mike
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-27 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-27 17:02 [PATCH] dm snapshot: don't define direct_access if we don't support it Mikulas Patocka
2019-02-27 17:27 ` Mike Snitzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox