* dm_set_target_max_io_len
@ 2019-03-21 10:33 Mikulas Patocka
2019-03-21 11:14 ` dm_set_target_max_io_len Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Mikulas Patocka @ 2019-03-21 10:33 UTC (permalink / raw)
To: Mike Snitzer, Ming Lei; +Cc: Jens Axboe, dm-devel
Hi
I'm looking at the patch 8f50e358153dd68182c714626be4a90b64179cf4. The
patch claims that dm-crypt can't deal with large bios - but I fixed this
problem with dm-crypt a year before (see the patch
4e870e948fbabf62b78e8410f04c67703e7c816b). Was my fix for dm-crypt
inefficient? Can you provide some test where dm-crypt fails with big bios?
Should 8f50e358153dd68182c714626be4a90b64179cf4 be dropped? The variable
ti->max_io_len is really split boundary (although it is incorrectly called
len), so if we set it, se are splitting even small bios that cross this
boundary.
Mikulas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dm_set_target_max_io_len
2019-03-21 10:33 dm_set_target_max_io_len Mikulas Patocka
@ 2019-03-21 11:14 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2019-03-21 11:14 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: Jens Axboe, dm-devel, Mike Snitzer
Hi Mikulas,
On Thu, Mar 21, 2019 at 06:33:32AM -0400, Mikulas Patocka wrote:
> Hi
>
> I'm looking at the patch 8f50e358153dd68182c714626be4a90b64179cf4. The
> patch claims that dm-crypt can't deal with large bios - but I fixed this
> problem with dm-crypt a year before (see the patch
> 4e870e948fbabf62b78e8410f04c67703e7c816b). Was my fix for dm-crypt
> inefficient? Can you provide some test where dm-crypt fails with big bios?
Sorry for missing the commit 4e870e948fbabf62b78e8410f04c67703e7c816b.
>
> Should 8f50e358153dd68182c714626be4a90b64179cf4 be dropped? The variable
Yeah, I think so.
Thanks,
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 10:33 dm_set_target_max_io_len Mikulas Patocka
2019-03-21 11:14 ` dm_set_target_max_io_len Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox