Linux Device Mapper development
 help / color / mirror / Atom feed
From: Curtis Gedak <gedakc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Phillip Susi <psusi-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org>
Cc: device-mapper development
	<dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org,
	parted-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org,
	Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>,
	Debian LVM Team
	<pkg-lvm-maintainers-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org>
Subject: Re: [dm-devel] What is the deal with the partition separator?
Date: Wed, 16 Feb 2011 13:18:47 -0700	[thread overview]
Message-ID: <4D5C3127.7050304@gmail.com> (raw)
In-Reply-To: <4D5C268B.6070507-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org>

On 11-02-16 12:33 PM, Phillip Susi wrote:
> On 2/16/2011 12:19 PM, Curtis Gedak wrote:
>> Only newer versions of (lib)parted which link with the dmraid library
>> work this way with dmraid devices.  In this situation it is the dmraid
>> library that is coming up with the device names.  For all other devices,
>> (lib)parted uses the "linux scheme since the dawn of time" mentioned
>> below.  Older versions of (lib)parted follow the "linux scheme since the
>> dawn of time".
> (lib)parted does not link to dmraid; it contains its own code to
> generate the name by always adding the 'p' in libparted/arch/linux.c.

My bad.  (lib)parted does not link with dmraid.  It has been a while 
since I looked deeply into the libparted code.

I do know that the current version of parted in git has a 
"--enable-device-mapper" option for configure that is enabled by default.
http://git.debian.org/?p=parted/parted.git;a=blob;f=configure.ac;h=25960a74abe909f7b11580aa053c0689a966820d;hb=HEAD#l81

The function _device_get_part_path in libparted/arc/linux.c, does appear 
to always insert a 'p'  for devices such as PED_DEVICE_DM and 
PED_DEVICE_ATARAID.
http://git.debian.org/?p=parted/parted.git;a=blob;f=libparted/arch/linux.c;h=0288a150769298b92f06d96f8515f96bc27066ea;hb=HEAD#l2198


Regarding the GParted code, it has been written to will work with dmraid 
devices regardless of whether the "--enable-device-mapper" configure 
option is enabled or disabled.

>> GParted uses (lib)parted to come up with device names, except in the
>> case of dmraid devices.  Because dmraid does not follow the "linux
>> scheme since the dawn of time", gparted calls dmraid directly to create
>> names following the old dmraid standard (only append partition number to
>> device name).  If kpartx is available, then GParted will call kpartx to
>> ensure that dmraid device names follow the "linux scheme since the dawn
>> of time".  This behaviour enables GParted to work with all versions of
>> dmraid, and maintain compatibility with (lib)parted versions 1.7.1 and
>> higher.
> It shouldn't be using both dmraid and kpartx to create the partition
> devices.  If dmraid does it, then calling kpartx at best does nothing,
> and at worst creates duplicate devices.

It would be easy in GParted to not call kpartx at all.  This is in the 
code to try to follow the normal partition naming standards for GNU/Linux.

  parent reply	other threads:[~2011-02-16 20:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  3:21 What is the deal with the partition separator? Phillip Susi
2011-02-16  7:38 ` Hannes Reinecke
     [not found]   ` <4D5B7ED9.20304-l3A5Bk7waGM@public.gmane.org>
2011-02-16 17:19     ` [dm-devel] " Curtis Gedak
     [not found]       ` <4D5C073F.3020502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-02-16 19:33         ` Phillip Susi
     [not found]           ` <4D5C268B.6070507-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org>
2011-02-16 20:18             ` Curtis Gedak [this message]
2011-02-16 19:37     ` Phillip Susi
     [not found]       ` <4D5C2793.1020601-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org>
2011-02-17  7:29         ` Hannes Reinecke
     [not found]           ` <4D5CCE75.5090202-l3A5Bk7waGM@public.gmane.org>
2011-02-17 14:57             ` Phillip Susi
     [not found]               ` <4D5D375F.9070106-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org>
2011-02-17 15:13                 ` Hannes Reinecke
     [not found]                   ` <4D5D3B34.4000005-l3A5Bk7waGM@public.gmane.org>
2011-02-17 15:13                     ` Phillip Susi
2011-02-17 16:53                       ` Alasdair G Kergon
2011-02-17 16:58                         ` Alasdair G Kergon
     [not found]                         ` <20110217165332.GE28729-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2011-02-20  5:04                           ` [dm-devel] " Phillip Susi
2011-02-17 16:54                     ` Curtis Gedak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5C3127.7050304@gmail.com \
    --to=gedakc-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hare-l3A5Bk7waGM@public.gmane.org \
    --cc=parted-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org \
    --cc=pkg-lvm-maintainers-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org \
    --cc=psusi-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org \
    --cc=serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox