Re: [PATCH 05/18] update multipath rules to deal with partition devices

[Hannes Reinecke <hare@suse.de>]

On 10/08/2015 09:44 PM, Benjamin Marzinski wrote:
> Partition devices should inherit the DM_MULTIPATH_DEVICE_PATH
> state of their parents, and if they are part of multipath path devices,
> they shouldn't have their own ID_FS_TYPE
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  multipath/multipath.rules | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/multipath/multipath.rules b/multipath/multipath.rules
> index c76e6b8..c8fb7e6 100644
> --- a/multipath/multipath.rules
> +++ b/multipath/multipath.rules
> @@ -1,14 +1,22 @@
>  # Set DM_MULTIPATH_DEVICE_PATH if the device should be handled by multipath
>  SUBSYSTEM!="block", GOTO="end_mpath"
> +ACTION!="add|change", GOTO="end_mpath"
> +KERNEL!="sd*|dasd*", GOTO="end_mpath"
> +
> +ENV{DEVTYPE}!="partition", GOTO="test_dev"
> +IMPORT{parent}="DM_MULTIPATH_DEVICE_PATH"
> +ENV{DM_MULTIPATH_DEVICE_PATH}=="1", ENV{ID_FS_TYPE}="none", \
> +	ENV{SYSTEMD_READY}="0"
> +GOTO="end_mpath"
> +
> +LABEL="test_dev"
>  
>  ENV{MPATH_SBIN_PATH}="/sbin"
>  TEST!="$env{MPATH_SBIN_PATH}/multipath", ENV{MPATH_SBIN_PATH}="/usr/sbin"
>  
> -SUBSYSTEM=="block", ACTION=="add|change", KERNEL=="sd*|dasd*", \
> -	ENV{DM_MULTIPATH_DEVICE_PATH}!="1", \
> +ENV{DM_MULTIPATH_DEVICE_PATH}!="1", \
>  	PROGRAM=="$env{MPATH_SBIN_PATH}/multipath -u %k", \
> -	ENV{DM_MULTIPATH_DEVICE_PATH}="1" \
> -	ENV{ID_FS_TYPE}="none" \
> +	ENV{DM_MULTIPATH_DEVICE_PATH}="1", ENV{ID_FS_TYPE}="none", \
>  	ENV{SYSTEMD_READY}="0"
>  
>  LABEL="end_mpath"
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)