From: Hannes Reinecke <hare@suse.de>
To: dm-devel@redhat.com
Subject: Re: [PATCH 13/18] libmultipath: add ignore_new_boot_devs option
Date: Mon, 12 Oct 2015 09:08:17 +0200 [thread overview]
Message-ID: <561B5C61.6010201@suse.de> (raw)
In-Reply-To: <1444333491-16265-14-git-send-email-bmarzins@redhat.com>
On 10/08/2015 09:44 PM, Benjamin Marzinski wrote:
> When multipath relies on the wwids file to determine whether a device is
> a multipath path (with "multipath -c"), it will fail the first time a
> new multipathable device is discovered, since the wwid clearly won't be
> in the wwids file. This is usually fine. Multipath will still set
> itself up on the device, and add the wwid to the wwids file. However,
> this causes a race, where multipath won't claim the path immediately,
> and something else may. Later multipath will try, and possibly succeed
> at, setting itself up on that device.
>
> I've seen cases where this can cause problems during boot on and
> immediately after install, where multipath racing with LVM on an already
> labelled device can get the machine into a state where boot fails. This
> can be avoided if multipath simply doesn't set itself up on any devices
> that it didn't claim (with "multipath -c") in the initramfs. It can
> still safely attempt to set itself up on these devices later in boot,
> after the regular filesystem has been set up.
>
> To allow this, this patch adds a new option, ignore_new_boot_devs. When
> enabled, this patch simply keeps multipath from being set up on devices
> that aren't already in the wwids file (along with all the other checks
> that multipath already does). This means that only devices that are
> claimed by "multipath -c" will be used by multipath.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
Well, as SUSE is not relying on /etc/wwids during boot we don't have
this issue :-)
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-10-12 7:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 19:44 [PATCH 00/18] multipath patch sync Benjamin Marzinski
2015-10-08 19:44 ` [PATCH 01/18] libmultipath: Add prioritizer context data Benjamin Marzinski
2015-10-12 6:35 ` Hannes Reinecke
2015-10-21 22:16 ` Benjamin Marzinski
2015-10-22 5:47 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 02/18] fix memory leaks on realloc failures Benjamin Marzinski
2015-10-12 6:35 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 03/18] multipathd: use /run instead of /var/run Benjamin Marzinski
2015-10-12 6:37 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 04/18] retrigger uevents to try and get the uid through udev Benjamin Marzinski
2015-10-12 6:40 ` Hannes Reinecke
2015-10-21 22:20 ` Benjamin Marzinski
2015-10-08 19:44 ` [PATCH 05/18] update multipath rules to deal with partition devices Benjamin Marzinski
2015-10-12 6:42 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 06/18] change order of multipath.rules Benjamin Marzinski
2015-10-12 6:43 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 07/18] make kpartx -d remove all partitions Benjamin Marzinski
2015-10-12 6:46 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 08/18] Fix issues with user_friendly_names initramfs bindings Benjamin Marzinski
2015-10-15 8:52 ` Hannes Reinecke
2015-10-21 22:43 ` Benjamin Marzinski
2015-10-08 19:44 ` [PATCH 09/18] Make multipath deactivate devices before iscsi shutdown Benjamin Marzinski
2015-10-12 7:05 ` Hannes Reinecke
2015-10-21 22:29 ` Benjamin Marzinski
2015-10-08 19:44 ` [PATCH 10/18] resize reply buffer for mutipathd help message Benjamin Marzinski
2015-10-12 7:05 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 11/18] Add libmpathcmd library and use it internally Benjamin Marzinski
2015-10-12 7:06 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 12/18] add raw format multipathd commands Benjamin Marzinski
2015-10-12 7:06 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 13/18] libmultipath: add ignore_new_boot_devs option Benjamin Marzinski
2015-10-12 7:08 ` Hannes Reinecke [this message]
2015-10-08 19:44 ` [PATCH 14/18] Make use of /run depend on systemd Benjamin Marzinski
2015-10-12 7:09 ` Hannes Reinecke
2015-10-12 7:34 ` Zdenek Kabelac
2015-10-12 8:35 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 15/18] libmpathpersist: uninstall man page correctly Benjamin Marzinski
2015-10-12 7:09 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 16/18] Increase host buffer size Benjamin Marzinski
2015-10-12 7:10 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 17/18] Fix sun partition numbering Benjamin Marzinski
2015-10-12 7:11 ` Hannes Reinecke
2015-10-08 19:44 ` [PATCH 18/18] Make multipath ignore devices without mpath prefix Benjamin Marzinski
2015-10-12 7:12 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B5C61.6010201@suse.de \
--to=hare@suse.de \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox