* Question about multipath device compiled defaults @ 2015-11-05 6:59 Doron Tal1 2016-01-19 16:35 ` Mauricio Faria de Oliveira 0 siblings, 1 reply; 7+ messages in thread From: Doron Tal1 @ 2015-11-05 6:59 UTC (permalink / raw) To: dm-devel [-- Attachment #1.1: Type: text/plain, Size: 603 bytes --] Hi all, I would like to know how and what procedure i should follow if i want to modify or add new settings to the device mapper defaults. So for example how can i modify existing compiled settings for the 2810XIV device? in case i want to add a new device and it settings, how can it be done? Thx in advance for your help with this matter. Regards, ____________________________________ Doron Tal Software Specialist, Interoperability Team XIV, an IBM global brand Phone: +972-(0)3-689-7293 Mobile: +972-(0)54-5989-222 Fax: +972-(0)3-647-8925 E-mail: dorontal@il.ibm.com [-- Attachment #1.2: Type: text/html, Size: 952 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Question about multipath device compiled defaults 2015-11-05 6:59 Question about multipath device compiled defaults Doron Tal1 @ 2016-01-19 16:35 ` Mauricio Faria de Oliveira 2016-01-19 16:48 ` Christophe Varoqui 0 siblings, 1 reply; 7+ messages in thread From: Mauricio Faria de Oliveira @ 2016-01-19 16:35 UTC (permalink / raw) To: DORONTAL; +Cc: device-mapper development On 11/05/2015 04:59 AM, Doron Tal1 wrote: > I would like to know how and what procedure i should follow if i want to > modify or add new settings to the device mapper defaults. The defaults are in hwtable.c [1]. > So for example how can i modify existing compiled settings for the > 2810XIV device? in case i want to add a new device and it settings, how > can it be done? To modify the compiled settings, you have to modify it and recompile. To modify the runtime settings (based on the defaults), you can modify /etc/multipath.conf (see its manpage [2] with 'man multipath.conf'). You can verify the the setting values used during multipath discovery with 'multipath -v3' for example, or "multipathd -k'show config'". Hope this might still help at this time, [1] http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c [2] http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=multipath/multipath.conf.5 -- Mauricio Faria de Oliveira IBM Linux Technology Center ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Question about multipath device compiled defaults 2016-01-19 16:35 ` Mauricio Faria de Oliveira @ 2016-01-19 16:48 ` Christophe Varoqui 2016-01-19 22:17 ` Brian Bunker 0 siblings, 1 reply; 7+ messages in thread From: Christophe Varoqui @ 2016-01-19 16:48 UTC (permalink / raw) To: device-mapper development; +Cc: DORONTAL [-- Attachment #1.1: Type: text/plain, Size: 1394 bytes --] Hi, and when you are ready, you can post the patch here so I can merge it upstream. Thanks, Christophe Varoqui OpenSVC On Tue, Jan 19, 2016 at 5:35 PM, Mauricio Faria de Oliveira < mauricfo@linux.vnet.ibm.com> wrote: > On 11/05/2015 04:59 AM, Doron Tal1 wrote: > >> I would like to know how and what procedure i should follow if i want to >> modify or add new settings to the device mapper defaults. >> > > The defaults are in hwtable.c [1]. > > So for example how can i modify existing compiled settings for the >> 2810XIV device? in case i want to add a new device and it settings, how >> can it be done? >> > > To modify the compiled settings, you have to modify it and recompile. > > To modify the runtime settings (based on the defaults), you can modify > /etc/multipath.conf (see its manpage [2] with 'man multipath.conf'). > > You can verify the the setting values used during multipath discovery > with 'multipath -v3' for example, or "multipathd -k'show config'". > > Hope this might still help at this time, > > [1] > http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c > [2] > http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=multipath/multipath.conf.5 > > -- > Mauricio Faria de Oliveira > IBM Linux Technology Center > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > [-- Attachment #1.2: Type: text/html, Size: 2650 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Question about multipath device compiled defaults 2016-01-19 16:48 ` Christophe Varoqui @ 2016-01-19 22:17 ` Brian Bunker 2016-01-20 6:58 ` Christophe Varoqui 0 siblings, 1 reply; 7+ messages in thread From: Brian Bunker @ 2016-01-19 22:17 UTC (permalink / raw) To: device-mapper development [-- Attachment #1.1: Type: text/plain, Size: 3654 bytes --] There are just two files I touch, so the patch is simple: diff -Naur 3/multipath-tools/libmultipath/hwtable.c 4/multipath-tools/libmultipath/hwtable.c --- 3/multipath-tools/libmultipath/hwtable.c 2016-01-14 17:47:06.000000000 -0800 +++ 4/multipath-tools/libmultipath/hwtable.c 2016-01-14 18:33:45.000000000 -0800 @@ -1166,6 +1166,22 @@ .prio_name = PRIO_ALUA, .prio_args = NULL, }, + { + .vendor = "PURE", + .product = "FlashArray", + .features = DEFAULT_FEATURES, + .hwhandler = DEFAULT_HWHANDLER, + .selector = "queue-length 0", + .pgpolicy = MULTIBUS, + .pgfailback = -FAILBACK_IMMEDIATE, + .checker_name = TUR, + .fast_io_fail = 10, + .user_friendly_names = USER_FRIENDLY_NAMES_OFF, + .prio_name = DEFAULT_PRIO, + .no_path_retry = 0, + .dev_loss = 60, + .prio_args = NULL, + }, /* * EOL */ diff -Naur 3/multipath-tools/multipath.conf.defaults 4/multipath-tools/multipath.conf.defaults --- 3/multipath-tools/multipath.conf.defaults 2016-01-14 17:47:06.000000000 -0800 +++ 4/multipath-tools/multipath.conf.defaults 2016-01-14 18:35:50.000000000 -0800 @@ -940,6 +940,17 @@ # rr_weight "uniform" # no_path_retry "queue" # } +# device { +# vendor "PURE" +# path_selector "queue-length 0" +# path_grouping_policy "multibus" +# path_checker "tur" +# fast_io_fail_tmo 10 +# user_friendly_names "no" +# no_path_retry 0 +# features 0 +# dev_loss_tmo 60 +# } #} #multipaths { #} Thanks, Brian On Tue, Jan 19, 2016 at 8:48 AM, Christophe Varoqui < christophe.varoqui@opensvc.com> wrote: > Hi, > > and when you are ready, you can post the patch here so I can merge it > upstream. > > Thanks, > Christophe Varoqui > OpenSVC > > On Tue, Jan 19, 2016 at 5:35 PM, Mauricio Faria de Oliveira < > mauricfo@linux.vnet.ibm.com> wrote: > >> On 11/05/2015 04:59 AM, Doron Tal1 wrote: >> >>> I would like to know how and what procedure i should follow if i want to >>> modify or add new settings to the device mapper defaults. >>> >> >> The defaults are in hwtable.c [1]. >> >> So for example how can i modify existing compiled settings for the >>> 2810XIV device? in case i want to add a new device and it settings, how >>> can it be done? >>> >> >> To modify the compiled settings, you have to modify it and recompile. >> >> To modify the runtime settings (based on the defaults), you can modify >> /etc/multipath.conf (see its manpage [2] with 'man multipath.conf'). >> >> You can verify the the setting values used during multipath discovery >> with 'multipath -v3' for example, or "multipathd -k'show config'". >> >> Hope this might still help at this time, >> >> [1] >> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c >> [2] >> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=multipath/multipath.conf.5 >> >> -- >> Mauricio Faria de Oliveira >> IBM Linux Technology Center >> >> -- >> dm-devel mailing list >> dm-devel@redhat.com >> https://www.redhat.com/mailman/listinfo/dm-devel >> > > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > -- Brian Bunker PURE Storage, Inc. <http://www.purestorage.com> brian@purestorage.com [-- Attachment #1.2: Type: text/html, Size: 6427 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Question about multipath device compiled defaults 2016-01-19 22:17 ` Brian Bunker @ 2016-01-20 6:58 ` Christophe Varoqui 2016-01-20 16:15 ` Brian Bunker 0 siblings, 1 reply; 7+ messages in thread From: Christophe Varoqui @ 2016-01-20 6:58 UTC (permalink / raw) To: device-mapper development [-- Attachment #1.1: Type: text/plain, Size: 4039 bytes --] Ok, merged. On Tue, Jan 19, 2016 at 11:17 PM, Brian Bunker <brian@purestorage.com> wrote: > There are just two files I touch, so the patch is simple: > > diff -Naur 3/multipath-tools/libmultipath/hwtable.c > 4/multipath-tools/libmultipath/hwtable.c > --- 3/multipath-tools/libmultipath/hwtable.c 2016-01-14 > 17:47:06.000000000 -0800 > +++ 4/multipath-tools/libmultipath/hwtable.c 2016-01-14 > 18:33:45.000000000 -0800 > @@ -1166,6 +1166,22 @@ > .prio_name = PRIO_ALUA, > .prio_args = NULL, > }, > + { > + .vendor = "PURE", > + .product = "FlashArray", > + .features = DEFAULT_FEATURES, > + .hwhandler = DEFAULT_HWHANDLER, > + .selector = "queue-length 0", > + .pgpolicy = MULTIBUS, > + .pgfailback = -FAILBACK_IMMEDIATE, > + .checker_name = TUR, > + .fast_io_fail = 10, > + .user_friendly_names = USER_FRIENDLY_NAMES_OFF, > + .prio_name = DEFAULT_PRIO, > + .no_path_retry = 0, > + .dev_loss = 60, > + .prio_args = NULL, > + }, > /* > * EOL > */ > diff -Naur 3/multipath-tools/multipath.conf.defaults > 4/multipath-tools/multipath.conf.defaults > --- 3/multipath-tools/multipath.conf.defaults 2016-01-14 > 17:47:06.000000000 -0800 > +++ 4/multipath-tools/multipath.conf.defaults 2016-01-14 > 18:35:50.000000000 -0800 > @@ -940,6 +940,17 @@ > # rr_weight "uniform" > # no_path_retry "queue" > # } > +# device { > +# vendor "PURE" > +# path_selector "queue-length 0" > +# path_grouping_policy "multibus" > +# path_checker "tur" > +# fast_io_fail_tmo 10 > +# user_friendly_names "no" > +# no_path_retry 0 > +# features 0 > +# dev_loss_tmo 60 > +# } > #} > #multipaths { > #} > > > Thanks, > Brian > > On Tue, Jan 19, 2016 at 8:48 AM, Christophe Varoqui < > christophe.varoqui@opensvc.com> wrote: > >> Hi, >> >> and when you are ready, you can post the patch here so I can merge it >> upstream. >> >> Thanks, >> Christophe Varoqui >> OpenSVC >> >> On Tue, Jan 19, 2016 at 5:35 PM, Mauricio Faria de Oliveira < >> mauricfo@linux.vnet.ibm.com> wrote: >> >>> On 11/05/2015 04:59 AM, Doron Tal1 wrote: >>> >>>> I would like to know how and what procedure i should follow if i want to >>>> modify or add new settings to the device mapper defaults. >>>> >>> >>> The defaults are in hwtable.c [1]. >>> >>> So for example how can i modify existing compiled settings for the >>>> 2810XIV device? in case i want to add a new device and it settings, how >>>> can it be done? >>>> >>> >>> To modify the compiled settings, you have to modify it and recompile. >>> >>> To modify the runtime settings (based on the defaults), you can modify >>> /etc/multipath.conf (see its manpage [2] with 'man multipath.conf'). >>> >>> You can verify the the setting values used during multipath discovery >>> with 'multipath -v3' for example, or "multipathd -k'show config'". >>> >>> Hope this might still help at this time, >>> >>> [1] >>> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c >>> [2] >>> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=multipath/multipath.conf.5 >>> >>> -- >>> Mauricio Faria de Oliveira >>> IBM Linux Technology Center >>> >>> -- >>> dm-devel mailing list >>> dm-devel@redhat.com >>> https://www.redhat.com/mailman/listinfo/dm-devel >>> >> >> >> -- >> dm-devel mailing list >> dm-devel@redhat.com >> https://www.redhat.com/mailman/listinfo/dm-devel >> > > > > -- > Brian Bunker > PURE Storage, Inc. <http://www.purestorage.com> > brian@purestorage.com > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > [-- Attachment #1.2: Type: text/html, Size: 7124 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Question about multipath device compiled defaults 2016-01-20 6:58 ` Christophe Varoqui @ 2016-01-20 16:15 ` Brian Bunker 2016-01-20 17:47 ` Mauricio Faria de Oliveira 0 siblings, 1 reply; 7+ messages in thread From: Brian Bunker @ 2016-01-20 16:15 UTC (permalink / raw) To: device-mapper development [-- Attachment #1.1: Type: text/plain, Size: 4695 bytes --] Thank you. Any ideas how long it typically takes the distros like RHEL, etc. to pull these changes down, or do they need to be pinged explicitly that there are changes available that we want them to consider? Brian On Tue, Jan 19, 2016 at 10:58 PM, Christophe Varoqui < christophe.varoqui@opensvc.com> wrote: > Ok, merged. > > On Tue, Jan 19, 2016 at 11:17 PM, Brian Bunker <brian@purestorage.com> > wrote: > >> There are just two files I touch, so the patch is simple: >> >> diff -Naur 3/multipath-tools/libmultipath/hwtable.c >> 4/multipath-tools/libmultipath/hwtable.c >> --- 3/multipath-tools/libmultipath/hwtable.c 2016-01-14 >> 17:47:06.000000000 -0800 >> +++ 4/multipath-tools/libmultipath/hwtable.c 2016-01-14 >> 18:33:45.000000000 -0800 >> @@ -1166,6 +1166,22 @@ >> .prio_name = PRIO_ALUA, >> .prio_args = NULL, >> }, >> + { >> + .vendor = "PURE", >> + .product = "FlashArray", >> + .features = DEFAULT_FEATURES, >> + .hwhandler = DEFAULT_HWHANDLER, >> + .selector = "queue-length 0", >> + .pgpolicy = MULTIBUS, >> + .pgfailback = -FAILBACK_IMMEDIATE, >> + .checker_name = TUR, >> + .fast_io_fail = 10, >> + .user_friendly_names = USER_FRIENDLY_NAMES_OFF, >> + .prio_name = DEFAULT_PRIO, >> + .no_path_retry = 0, >> + .dev_loss = 60, >> + .prio_args = NULL, >> + }, >> /* >> * EOL >> */ >> diff -Naur 3/multipath-tools/multipath.conf.defaults >> 4/multipath-tools/multipath.conf.defaults >> --- 3/multipath-tools/multipath.conf.defaults 2016-01-14 >> 17:47:06.000000000 -0800 >> +++ 4/multipath-tools/multipath.conf.defaults 2016-01-14 >> 18:35:50.000000000 -0800 >> @@ -940,6 +940,17 @@ >> # rr_weight "uniform" >> # no_path_retry "queue" >> # } >> +# device { >> +# vendor "PURE" >> +# path_selector "queue-length 0" >> +# path_grouping_policy "multibus" >> +# path_checker "tur" >> +# fast_io_fail_tmo 10 >> +# user_friendly_names "no" >> +# no_path_retry 0 >> +# features 0 >> +# dev_loss_tmo 60 >> +# } >> #} >> #multipaths { >> #} >> >> >> Thanks, >> Brian >> >> On Tue, Jan 19, 2016 at 8:48 AM, Christophe Varoqui < >> christophe.varoqui@opensvc.com> wrote: >> >>> Hi, >>> >>> and when you are ready, you can post the patch here so I can merge it >>> upstream. >>> >>> Thanks, >>> Christophe Varoqui >>> OpenSVC >>> >>> On Tue, Jan 19, 2016 at 5:35 PM, Mauricio Faria de Oliveira < >>> mauricfo@linux.vnet.ibm.com> wrote: >>> >>>> On 11/05/2015 04:59 AM, Doron Tal1 wrote: >>>> >>>>> I would like to know how and what procedure i should follow if i want >>>>> to >>>>> modify or add new settings to the device mapper defaults. >>>>> >>>> >>>> The defaults are in hwtable.c [1]. >>>> >>>> So for example how can i modify existing compiled settings for the >>>>> 2810XIV device? in case i want to add a new device and it settings, how >>>>> can it be done? >>>>> >>>> >>>> To modify the compiled settings, you have to modify it and recompile. >>>> >>>> To modify the runtime settings (based on the defaults), you can modify >>>> /etc/multipath.conf (see its manpage [2] with 'man multipath.conf'). >>>> >>>> You can verify the the setting values used during multipath discovery >>>> with 'multipath -v3' for example, or "multipathd -k'show config'". >>>> >>>> Hope this might still help at this time, >>>> >>>> [1] >>>> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c >>>> [2] >>>> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=multipath/multipath.conf.5 >>>> >>>> -- >>>> Mauricio Faria de Oliveira >>>> IBM Linux Technology Center >>>> >>>> -- >>>> dm-devel mailing list >>>> dm-devel@redhat.com >>>> https://www.redhat.com/mailman/listinfo/dm-devel >>>> >>> >>> >>> -- >>> dm-devel mailing list >>> dm-devel@redhat.com >>> https://www.redhat.com/mailman/listinfo/dm-devel >>> >> >> >> >> -- >> Brian Bunker >> PURE Storage, Inc. <http://www.purestorage.com> >> brian@purestorage.com >> >> -- >> dm-devel mailing list >> dm-devel@redhat.com >> https://www.redhat.com/mailman/listinfo/dm-devel >> > > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > -- Brian Bunker PURE Storage, Inc. <http://www.purestorage.com> brian@purestorage.com [-- Attachment #1.2: Type: text/html, Size: 8334 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Question about multipath device compiled defaults 2016-01-20 16:15 ` Brian Bunker @ 2016-01-20 17:47 ` Mauricio Faria de Oliveira 0 siblings, 0 replies; 7+ messages in thread From: Mauricio Faria de Oliveira @ 2016-01-20 17:47 UTC (permalink / raw) To: device-mapper development; +Cc: brian Hi Brian, On 01/20/2016 02:15 PM, Brian Bunker wrote: > Any ideas how long it typically takes the distros like RHEL, etc. to > pull these changes down, or do they need to be pinged explicitly that > there are changes available that we want them to consider? It's a good idea to let them know (e.g., bug/feature report). I've worked a bit w/ Ubuntu, RHEL, and SLES. Even though the changes might eventually make downstream, some distros won't pull everything (reasonably), but only the pieces they find/know to be required or desired by users/customers -- specially on released/ stable distro versions. So, letting them know / ask for consideration usually helps. -- Mauricio Faria de Oliveira IBM Linux Technology Center ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-20 17:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-05 6:59 Question about multipath device compiled defaults Doron Tal1 2016-01-19 16:35 ` Mauricio Faria de Oliveira 2016-01-19 16:48 ` Christophe Varoqui 2016-01-19 22:17 ` Brian Bunker 2016-01-20 6:58 ` Christophe Varoqui 2016-01-20 16:15 ` Brian Bunker 2016-01-20 17:47 ` Mauricio Faria de Oliveira
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox