From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH 14/14] block: add bio_start_io_acct_remapped for the benefit of DM
Date: Thu, 10 Feb 2022 23:07:54 -0800 [thread overview]
Message-ID: <YgYLShZC1qboLQN4@infradead.org> (raw)
In-Reply-To: <20220210223832.99412-15-snitzer@redhat.com>
On Thu, Feb 10, 2022 at 05:38:32PM -0500, Mike Snitzer wrote:
> DM needs the ability to account a clone bio's IO to the original
> block_device. So add @orig_bdev argument to bio_start_io_acct_time.
> Rename bio_start_io_acct_time to bio_start_io_acct_remapped.
> Also, follow bio_end_io_acct and bio_end_io_acct_remapped pattern by
> moving bio_start_io_acct to blkdev.h and have it call
> bio_start_io_acct_remapped.
>
> Improve DM to no longer need to play games with swizzling a clone
> bio's bi_bdev (in dm_submit_bio_remap) and remove DM's
> clone_and_start_io_acct() interface.
Please split the core block layer part of this out, reorder it before
the current patch 10 and then do the right thing in that patch from the
start.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2022-02-11 7:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 22:38 [dm-devel] [PATCH 00/14] dm: improve bio-based IO accounting Mike Snitzer
2022-02-10 22:38 ` [dm-devel] [PATCH 01/14] dm: rename split functions Mike Snitzer
2022-02-11 6:48 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 02/14] dm: fold __clone_and_map_data_bio into __split_and_process_bio Mike Snitzer
2022-02-11 6:48 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 03/14] dm: refactor dm_split_and_process_bio a bit Mike Snitzer
2022-02-11 6:52 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 04/14] dm: reduce code duplication in __map_bio Mike Snitzer
2022-02-11 6:52 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 05/14] dm: remove impossible BUG_ON in __send_empty_flush Mike Snitzer
2022-02-11 6:53 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 06/14] dm: remove unused mapped_device argument from free_tio Mike Snitzer
2022-02-11 6:53 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 07/14] dm: remove code only needed before submit_bio recursion Mike Snitzer
2022-02-11 6:56 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 08/14] dm: record old_sector in dm_target_io before calling map function Mike Snitzer
2022-02-11 6:56 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 09/14] dm: prep for following changes Mike Snitzer
2022-02-11 6:57 ` Christoph Hellwig
2022-02-10 22:38 ` [dm-devel] [PATCH 10/14] dm: add dm_submit_bio_remap interface Mike Snitzer
2022-02-10 22:38 ` [dm-devel] [PATCH 11/14] dm crypt: use dm_submit_bio_remap Mike Snitzer
2022-02-10 22:38 ` [dm-devel] [PATCH 12/14] dm delay: dm_submit_bio_remap Mike Snitzer
2022-02-10 22:38 ` [dm-devel] [PATCH 13/14] dm: improve correctness and efficiency of bio-based IO accounting Mike Snitzer
2022-02-10 22:38 ` [dm-devel] [PATCH 14/14] block: add bio_start_io_acct_remapped for the benefit of DM Mike Snitzer
2022-02-11 7:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgYLShZC1qboLQN4@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox