From: Mike Snitzer <snitzer@kernel.org>
To: linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
Dennis Zhou <dennis@kernel.org>,
tj@kernel.org, axboe@kernel.dk, dm-devel@redhat.com
Subject: [dm-devel] [PATCH] block: remove redundant blk-cgroup init from __bio_clone
Date: Mon, 11 Apr 2022 13:33:58 -0400 [thread overview]
Message-ID: <YlRmhlL8TtQow0W0@redhat.com> (raw)
In-Reply-To: <YlRiUVFK+a0DwQhu@redhat.com>
When bio_{alloc,init}_clone are passed a bdev, bio_init() will call
bio_associate_blkg() so the __bio_clone() work to initialize blkcg
isn't needed.
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
---
block/bio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 7892f1108ca6..6980f1b4b0f4 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -778,9 +778,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
bio->bi_ioprio = bio_src->bi_ioprio;
bio->bi_iter = bio_src->bi_iter;
- bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
-
if (bio_crypt_clone(bio, bio_src, gfp) < 0)
return -ENOMEM;
if (bio_integrity(bio_src) &&
--
2.30.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-04-11 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 16:52 [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg? Mike Snitzer
2022-03-30 12:28 ` Dennis Zhou
2022-03-31 4:39 ` Christoph Hellwig
2022-03-31 5:52 ` Dennis Zhou
2022-03-31 9:15 ` Christoph Hellwig
2022-04-08 15:42 ` Mike Snitzer
2022-04-09 5:15 ` Christoph Hellwig
2022-04-11 16:58 ` Mike Snitzer
2022-04-11 17:16 ` Mike Snitzer
2022-04-11 17:33 ` Mike Snitzer [this message]
2022-04-12 5:27 ` [dm-devel] [PATCH] block: remove redundant blk-cgroup init from __bio_clone Christoph Hellwig
2022-04-12 7:52 ` Dennis Zhou
2022-04-23 16:55 ` Christoph Hellwig
2022-04-26 17:30 ` [dm-devel] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlRmhlL8TtQow0W0@redhat.com \
--to=snitzer@kernel.org \
--cc=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).