* [PATCH -next] dm integrity: Make dm_integrity_init and dm_integrity_exit static
@ 2019-03-22 14:16 Yue Haibing
2019-03-22 14:56 ` Heinz Mauelshagen
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-03-22 14:16 UTC (permalink / raw)
To: agk, snitzer; +Cc: linux-kernel, dm-devel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
drivers/md/dm-integrity.c:3619:12: warning:
symbol 'dm_integrity_init' was not declared. Should it be static?
drivers/md/dm-integrity.c:3638:6: warning:
symbol 'dm_integrity_exit' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/md/dm-integrity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index d57d997..0932c32 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -3616,7 +3616,7 @@ static struct target_type integrity_target = {
.io_hints = dm_integrity_io_hints,
};
-int __init dm_integrity_init(void)
+static int __init dm_integrity_init(void)
{
int r;
@@ -3635,7 +3635,7 @@ int __init dm_integrity_init(void)
return r;
}
-void dm_integrity_exit(void)
+static void dm_integrity_exit(void)
{
dm_unregister_target(&integrity_target);
kmem_cache_destroy(journal_io_cache);
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] dm integrity: Make dm_integrity_init and dm_integrity_exit static
2019-03-22 14:16 [PATCH -next] dm integrity: Make dm_integrity_init and dm_integrity_exit static Yue Haibing
@ 2019-03-22 14:56 ` Heinz Mauelshagen
0 siblings, 0 replies; 2+ messages in thread
From: Heinz Mauelshagen @ 2019-03-22 14:56 UTC (permalink / raw)
To: dm-devel
On 3/22/19 3:16 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/md/dm-integrity.c:3619:12: warning:
> symbol 'dm_integrity_init' was not declared. Should it be static?
> drivers/md/dm-integrity.c:3638:6: warning:
> symbol 'dm_integrity_exit' was not declared. Should it be static?
Yes, both should be static.
Once on it, declare 'static void __exit dm_integrity_exit(void);'
Heinz
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/md/dm-integrity.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
> index d57d997..0932c32 100644
> --- a/drivers/md/dm-integrity.c
> +++ b/drivers/md/dm-integrity.c
> @@ -3616,7 +3616,7 @@ static struct target_type integrity_target = {
> .io_hints = dm_integrity_io_hints,
> };
>
> -int __init dm_integrity_init(void)
> +static int __init dm_integrity_init(void)
> {
> int r;
>
> @@ -3635,7 +3635,7 @@ int __init dm_integrity_init(void)
> return r;
> }
>
> -void dm_integrity_exit(void)
> +static void dm_integrity_exit(void)
> {
> dm_unregister_target(&integrity_target);
> kmem_cache_destroy(journal_io_cache);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-22 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-22 14:16 [PATCH -next] dm integrity: Make dm_integrity_init and dm_integrity_exit static Yue Haibing
2019-03-22 14:56 ` Heinz Mauelshagen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox