[PATCH] dm mpath: integrity errors should not cause failover

[PATCH] dm mpath: integrity errors should not cause failover

[Mike Snitzer]

From: "Martin K. Petersen" <martin.petersen@oracle.com>

Integrity errors need to be passed to the owner of the integrity
metadata for processing. Consequently EILSEQ should be passed up the
stack.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
 drivers/md/dm-mpath.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[resubmitting to dm-devel to get this in through the DM tree, next
merge window, now that this change missed the 2.6.39 merge window]

diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index a550a05..aa4e570 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -1290,7 +1290,7 @@ static int do_end_io(struct multipath *m, struct request *clone,
 	if (!error && !clone->errors)
 		return 0;	/* I/O complete */
 
-	if (error == -EOPNOTSUPP || error == -EREMOTEIO)
+	if (error == -EOPNOTSUPP || error == -EREMOTEIO || error == -EILSEQ)
 		return error;
 
 	if (mpio->pgpath)

Re: dm mpath: integrity errors should not cause failover

[Mike Snitzer]

On Mon, Mar 28 2011 at  3:37pm -0400,
Mike Snitzer <snitzer@redhat.com> wrote:

> From: "Martin K. Petersen" <martin.petersen@oracle.com>
> 
> Integrity errors need to be passed to the owner of the integrity
> metadata for processing. Consequently EILSEQ should be passed up the
> stack.
> 
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> ---
>  drivers/md/dm-mpath.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> [resubmitting to dm-devel to get this in through the DM tree, next
> merge window, now that this change missed the 2.6.39 merge window]

Though this change could easily be considered a fix (for those lucky
enough to even have a DIF/DIX capable mpath configuration)...

Anyway, please consider it on the DM queue.

Re: dm mpath: integrity errors should not cause failover

[Martin K. Petersen]

>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:

Mike> Though this change could easily be considered a fix (for those
Mike> lucky enough to even have a DIF/DIX capable mpath
Mike> configuration)...

Yeah, I actually fixed this in my tree as a result of a user bug report.

-- 
Martin K. Petersen	Oracle Linux Engineering