* [PATCH] dm: Integrity errors should not cause failover
@ 2011-03-08 6:54 Martin K. Petersen
2011-03-08 15:14 ` Mike Snitzer
0 siblings, 1 reply; 6+ messages in thread
From: Martin K. Petersen @ 2011-03-08 6:54 UTC (permalink / raw)
To: dm-devel
Integrity errors need to be passed to the owner of the integrity
metadata for processing. Consequently EILSEQ should be passed up the
stack.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index f336c69..57f7dd3 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -1215,7 +1215,7 @@ static int do_end_io(struct multipath *m, struct request *clone,
if (!error && !clone->errors)
return 0; /* I/O complete */
- if (error == -EOPNOTSUPP)
+ if (error == -EOPNOTSUPP || error == -EILSEQ)
return error;
if (mpio->pgpath)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: dm: Integrity errors should not cause failover
2011-03-08 6:54 [PATCH] dm: Integrity errors should not cause failover Martin K. Petersen
@ 2011-03-08 15:14 ` Mike Snitzer
2011-03-08 15:20 ` James Bottomley
2011-03-08 15:24 ` Martin K. Petersen
0 siblings, 2 replies; 6+ messages in thread
From: Mike Snitzer @ 2011-03-08 15:14 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: James Bottomley, device-mapper development, linux-scsi
On Tue, Mar 08 2011 at 1:54am -0500,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
>
> Integrity errors need to be passed to the owner of the integrity
> metadata for processing. Consequently EILSEQ should be passed up the
> stack.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Mike Snitzer <snitzer@redhat.com>
Thanks Martin. But James has already staged a few patches associated
with IO error differentation for 2.6.39. Your dm-mpath patch will need
to be rebased on that work; best to feed it to James too.
(we were gambling that there wouldn't be additional DM or block changes
related to this work and figured it safe to have James carry all the
SCSI, block and DM changes... ;)
Problem is I'm not seeing a 2.6.39 branch in James' scsi-2.6-misc.git
(even though I know the changes are staged there ;)
See:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=79775567e0439ca47eb9f501e52c4b713d44cf89
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=751b2a7d623ead9e55f751a6087efeab454b5659
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=63583cca745f440167bf27877182dc13e19d4bcf
James,
Any easy way to get Martin your 2.6.39 tree? Do you have a branch (just
the tag isn't exposed)?
Mike
> ---
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index f336c69..57f7dd3 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1215,7 +1215,7 @@ static int do_end_io(struct multipath *m, struct request *clone,
> if (!error && !clone->errors)
> return 0; /* I/O complete */
>
> - if (error == -EOPNOTSUPP)
> + if (error == -EOPNOTSUPP || error == -EILSEQ)
> return error;
>
> if (mpio->pgpath)
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dm: Integrity errors should not cause failover
2011-03-08 15:14 ` Mike Snitzer
@ 2011-03-08 15:20 ` James Bottomley
2011-03-08 15:30 ` Mike Snitzer
2011-03-08 15:24 ` Martin K. Petersen
1 sibling, 1 reply; 6+ messages in thread
From: James Bottomley @ 2011-03-08 15:20 UTC (permalink / raw)
To: Mike Snitzer; +Cc: Martin K. Petersen, device-mapper development, linux-scsi
On Tue, 2011-03-08 at 10:14 -0500, Mike Snitzer wrote:
> On Tue, Mar 08 2011 at 1:54am -0500,
> Martin K. Petersen <martin.petersen@oracle.com> wrote:
>
> >
> > Integrity errors need to be passed to the owner of the integrity
> > metadata for processing. Consequently EILSEQ should be passed up the
> > stack.
> >
> > Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
>
> Thanks Martin. But James has already staged a few patches associated
> with IO error differentation for 2.6.39. Your dm-mpath patch will need
> to be rebased on that work; best to feed it to James too.
>
> (we were gambling that there wouldn't be additional DM or block changes
> related to this work and figured it safe to have James carry all the
> SCSI, block and DM changes... ;)
>
> Problem is I'm not seeing a 2.6.39 branch in James' scsi-2.6-misc.git
> (even though I know the changes are staged there ;)
>
> See:
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=79775567e0439ca47eb9f501e52c4b713d44cf89
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=751b2a7d623ead9e55f751a6087efeab454b5659
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=63583cca745f440167bf27877182dc13e19d4bcf
>
> James,
> Any easy way to get Martin your 2.6.39 tree? Do you have a branch (just
> the tag isn't exposed)?
Branch for what? It's a linear tree with all the SCSI patches on
master.
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dm: Integrity errors should not cause failover
2011-03-08 15:20 ` James Bottomley
@ 2011-03-08 15:30 ` Mike Snitzer
0 siblings, 0 replies; 6+ messages in thread
From: Mike Snitzer @ 2011-03-08 15:30 UTC (permalink / raw)
To: James Bottomley; +Cc: Martin K. Petersen, device-mapper development, linux-scsi
On Tue, Mar 08 2011 at 10:20am -0500,
James Bottomley <James.Bottomley@suse.de> wrote:
> On Tue, 2011-03-08 at 10:14 -0500, Mike Snitzer wrote:
> > On Tue, Mar 08 2011 at 1:54am -0500,
> > Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >
> > >
> > > Integrity errors need to be passed to the owner of the integrity
> > > metadata for processing. Consequently EILSEQ should be passed up the
> > > stack.
> > >
> > > Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >
> > Acked-by: Mike Snitzer <snitzer@redhat.com>
> >
> > Thanks Martin. But James has already staged a few patches associated
> > with IO error differentation for 2.6.39. Your dm-mpath patch will need
> > to be rebased on that work; best to feed it to James too.
> >
> > (we were gambling that there wouldn't be additional DM or block changes
> > related to this work and figured it safe to have James carry all the
> > SCSI, block and DM changes... ;)
> >
> > Problem is I'm not seeing a 2.6.39 branch in James' scsi-2.6-misc.git
> > (even though I know the changes are staged there ;)
> >
> > See:
> > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=79775567e0439ca47eb9f501e52c4b713d44cf89
> > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=751b2a7d623ead9e55f751a6087efeab454b5659
> > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=63583cca745f440167bf27877182dc13e19d4bcf
> >
> > James,
> > Any easy way to get Martin your 2.6.39 tree? Do you have a branch (just
> > the tag isn't exposed)?
>
> Branch for what? It's a linear tree with all the SCSI patches on
> master.
Ah.. good to know. I hadn't looked that closely ;)
But now that I look, you've been quite busy! The above commits are
buried pretty deep by now.
Mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dm: Integrity errors should not cause failover
2011-03-08 15:14 ` Mike Snitzer
2011-03-08 15:20 ` James Bottomley
@ 2011-03-08 15:24 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2011-03-08 15:24 UTC (permalink / raw)
To: Mike Snitzer
Cc: Martin K. Petersen, James Bottomley, device-mapper development,
linux-scsi
>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
Mike> But James has already staged a few patches associated with IO
Mike> error differentation for 2.6.39. Your dm-mpath patch will need to
Mike> be rebased on that work;
Oh, I didn't see they finally went in. I'll take a look at scsi-misc.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] dm: Integrity errors should not cause failover
@ 2011-05-18 4:49 Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2011-05-18 4:49 UTC (permalink / raw)
To: device-mapper development; +Cc: Alasdair G. Kergon, Mike Snitzer
Integrity errors need to be passed to the owner of the integrity
metadata for processing. Consequently EILSEQ should be passed up the
stack.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Mike Snitzer <snitzer@redhat.com>
---
Ping on this one?
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index a550a05..aa4e570 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -1290,7 +1290,7 @@ static int do_end_io(struct multipath *m, struct request *clone,
if (!error && !clone->errors)
return 0; /* I/O complete */
- if (error == -EOPNOTSUPP || error == -EREMOTEIO)
+ if (error == -EOPNOTSUPP || error == -EREMOTEIO || error == -EILSEQ)
return error;
if (mpio->pgpath)
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-18 4:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 6:54 [PATCH] dm: Integrity errors should not cause failover Martin K. Petersen
2011-03-08 15:14 ` Mike Snitzer
2011-03-08 15:20 ` James Bottomley
2011-03-08 15:30 ` Mike Snitzer
2011-03-08 15:24 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2011-05-18 4:49 [PATCH] " Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox