[PATCH] dmaengine: pl330: Move device specific debugfs file to its directory

[PATCH] dmaengine: pl330: Move device specific debugfs file to its directory

[Vladimir Zapolskiy]

Under DMA framework every DMA device gets its dedicated directory
dmaengine/$device_name in debugfs to store any supplementary data
accessible from userspace. This change moves a single registered
debugfs file of each PL330 device from debugfs top directory to the
device specific directory, the file is renamed to "stats" to match
the most popular name among all DMA device debugfs files.

The S_IFREG mask is dropped as excessive for debugfs_create_file()
function.

Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
---
 drivers/dma/pl330.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 25ba84b18704..9736eb24e5ac 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2952,8 +2952,7 @@ DEFINE_SHOW_ATTRIBUTE(pl330_debugfs);
 
 static inline void init_pl330_debugfs(struct pl330_dmac *pl330)
 {
-	debugfs_create_file(dev_name(pl330->ddma.dev),
-			    S_IFREG | 0444, NULL, pl330,
+	debugfs_create_file("stats", 0444, pl330->ddma.dbg_dev_root, pl330,
 			    &pl330_debugfs_fops);
 }
 #else
-- 
2.51.0

Re: [PATCH] dmaengine: pl330: Move device specific debugfs file to its directory

[Frank Li]

On Sat, Jul 25, 2026 at 10:43:43PM +0300, Vladimir Zapolskiy wrote:
> Under DMA framework every DMA device gets its dedicated directory
> dmaengine/$device_name in debugfs to store any supplementary data
> accessible from userspace. This change moves a single registered
> debugfs file of each PL330 device from debugfs top directory to the
> device specific directory, the file is renamed to "stats" to match
> the most popular name among all DMA device debugfs files.
>
> The S_IFREG mask is dropped as excessive for debugfs_create_file()
> function.
>
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/pl330.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 25ba84b18704..9736eb24e5ac 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2952,8 +2952,7 @@ DEFINE_SHOW_ATTRIBUTE(pl330_debugfs);
>
>  static inline void init_pl330_debugfs(struct pl330_dmac *pl330)
>  {
> -	debugfs_create_file(dev_name(pl330->ddma.dev),
> -			    S_IFREG | 0444, NULL, pl330,
> +	debugfs_create_file("stats", 0444, pl330->ddma.dbg_dev_root, pl330,
>  			    &pl330_debugfs_fops);
>  }
>  #else
> --
> 2.51.0
>

Re: [PATCH] dmaengine: pl330: Move device specific debugfs file to its directory

[Vinod Koul]

On Sat, 25 Jul 2026 22:43:43 +0300, Vladimir Zapolskiy wrote:
> Under DMA framework every DMA device gets its dedicated directory
> dmaengine/$device_name in debugfs to store any supplementary data
> accessible from userspace. This change moves a single registered
> debugfs file of each PL330 device from debugfs top directory to the
> device specific directory, the file is renamed to "stats" to match
> the most popular name among all DMA device debugfs files.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: pl330: Move device specific debugfs file to its directory
      commit: d2d5b3dbd97e50261c1ad6a5f0eb09963f421848

Best regards,
-- 
~Vinod