From: Vinod Koul <vkoul@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Angelo Dureghello <angelo@sysam.it>,
dmaengine@vger.kernel.org,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: [v5,2/2] dmaengine: fsl-edma: add ColdFire mcf5441x edma support
Date: Thu, 28 Jun 2018 16:39:13 +0530 [thread overview]
Message-ID: <20180628110913.GT22377@vkoul-mobl> (raw)
On 28-06-18, 09:43, Geert Uytterhoeven wrote:
> Hi Vinod,
>
> On Thu, Jun 28, 2018 at 9:29 AM Vinod <vkoul@kernel.org> wrote:
> > On 28-06-18, 08:50, Geert Uytterhoeven wrote:
> > > On Thu, Jun 28, 2018 at 8:29 AM Vinod <vkoul@kernel.org> wrote:
> > > > On 22-06-18, 11:44, Angelo Dureghello wrote:
> > > > > obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
> > > > > obj-$(CONFIG_FSL_DMA) += fsldma.o
> > > > > obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
> > > > > +obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o
> > > >
> > > > that makes kernel have two copies of common.o one in thsi driver and one
> > >
> > > Does it? It's a common pattern in several Makefiles (e.g.
> > > drivers/net/ethernet/8390/Makefile and drivers/scsi/Makefile)
> >
> > won't each static symbol be part each one?
>
> Remember, obj-y is a list, and IIRC it's filtered for duplicates.
>
> > What about when they are modules?
>
> Same thing, you'll have fsl-edma-common.ko, and fsl-edma.ko and/or mcf-edma.ko.
Yeah that is right, I missed the list part
next reply other threads:[~2018-06-28 11:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 11:09 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-01 13:11 [v5,2/2] dmaengine: fsl-edma: add ColdFire mcf5441x edma support Vinod Koul
2018-06-30 21:06 Geert Uytterhoeven
2018-06-30 13:42 Angelo Dureghello
2018-06-29 5:15 Vinod Koul
2018-06-28 16:56 Angelo Dureghello
2018-06-28 7:43 Geert Uytterhoeven
2018-06-28 7:29 Vinod Koul
2018-06-28 6:50 Geert Uytterhoeven
2018-06-28 6:23 Vinod Koul
2018-06-22 9:44 Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628110913.GT22377@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=angelo@sysam.it \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox