* [3/5] dmaengine: mv_xor_v2: convert callback to helper function
@ 2018-07-17 10:30 hannah
0 siblings, 0 replies; 2+ messages in thread
From: hannah @ 2018-07-17 10:30 UTC (permalink / raw)
To: dan.j.williams, vkoul, dmaengine
Cc: thomas.petazzoni, linux-kernel, nadavh, omrii, oferh,
gregory.clement, Hanna Hawa
From: Hanna Hawa <hannah@marvell.com>
This is in preperation of moving to a callback that provides results to the
callback for the transaction. The conversion will maintain current behavior
and the driver must convert to new callback mechanism at a later time in
order to receive results.
Signed-off-by: Hanna Hawa <hannah@marvell.com>
---
drivers/dma/mv_xor_v2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index e718498..14e2a7a 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -589,9 +589,8 @@ static void mv_xor_v2_tasklet(unsigned long data)
*/
dma_cookie_complete(&next_pending_sw_desc->async_tx);
- if (next_pending_sw_desc->async_tx.callback)
- next_pending_sw_desc->async_tx.callback(
- next_pending_sw_desc->async_tx.callback_param);
+ dmaengine_desc_get_callback_invoke(
+ &next_pending_sw_desc->async_tx, NULL);
dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [3/5] dmaengine: mv_xor_v2: convert callback to helper function
@ 2018-07-20 9:29 Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2018-07-20 9:29 UTC (permalink / raw)
To: hannah
Cc: dan.j.williams, dmaengine, thomas.petazzoni, linux-kernel, nadavh,
omrii, oferh, gregory.clement
On 17-07-18, 13:30, hannah@marvell.com wrote:
> From: Hanna Hawa <hannah@marvell.com>
>
> This is in preperation of moving to a callback that provides results to the
typo preperation
> callback for the transaction. The conversion will maintain current behavior
> and the driver must convert to new callback mechanism at a later time in
> order to receive results.
>
> Signed-off-by: Hanna Hawa <hannah@marvell.com>
> ---
> drivers/dma/mv_xor_v2.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index e718498..14e2a7a 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -589,9 +589,8 @@ static void mv_xor_v2_tasklet(unsigned long data)
> */
> dma_cookie_complete(&next_pending_sw_desc->async_tx);
>
> - if (next_pending_sw_desc->async_tx.callback)
> - next_pending_sw_desc->async_tx.callback(
> - next_pending_sw_desc->async_tx.callback_param);
> + dmaengine_desc_get_callback_invoke(
> + &next_pending_sw_desc->async_tx, NULL);
>
> dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-20 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-20 9:29 [3/5] dmaengine: mv_xor_v2: convert callback to helper function Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-07-17 10:30 hannah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox