DMA Engine development
 help / color / mirror / Atom feed
From: Huang Shijie <sjhuang@iluvatar.ai>
To: Daniel Mack <daniel@zonque.org>
Cc: vkoul@kernel.org, dan.j.williams@intel.com,
	Zubair.Kakakhel@imgtec.com, haojian.zhuang@gmail.com,
	robert.jarzmik@free.fr, patrice.chotard@st.com,
	linus.walleij@linaro.org, mcoquelin.stm32@gmail.com,
	alexandre.torgue@st.com, Eugeniy.Paltsev@synopsys.com,
	colin.king@canonical.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [v2,3/9] dmaengine: st_fdma: use dmaenginem_async_device_register to simplify the code
Date: Mon, 6 Aug 2018 17:22:59 +0800	[thread overview]
Message-ID: <20180806092252.GA5301@hsj-Precision-5520> (raw)

On Mon, Aug 06, 2018 at 11:03:51AM +0200, Daniel Mack wrote:
> > -	ret = dma_async_device_register(&fdev->dma_device);
> > +	ret = dmaenginem_async_device_register(&fdev->dma_device);
> >   	if (ret) {
> >   		dev_err(&pdev->dev,
> >   			"Failed to register DMA device (%d)\n", ret);
> > @@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev)
> >   	return 0;
> >   err_dma_dev:
> > -	dma_async_device_unregister(&fdev->dma_device);
> 
> I guess the jump label can go away too?
Yes. 

We can remove the err_dma_dev too.

Thanks
Huang Shijie
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-08-06  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06  9:22 Huang Shijie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-08-06  9:03 [v2,3/9] dmaengine: st_fdma: use dmaenginem_async_device_register to simplify the code Daniel Mack
2018-08-06  8:52 Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180806092252.GA5301@hsj-Precision-5520 \
    --to=sjhuang@iluvatar.ai \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=alexandre.torgue@st.com \
    --cc=colin.king@canonical.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@zonque.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=patrice.chotard@st.com \
    --cc=robert.jarzmik@free.fr \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox