* [v2,3/9] dmaengine: st_fdma: use dmaenginem_async_device_register to simplify the code
@ 2018-08-06 9:22 Huang Shijie
0 siblings, 0 replies; 3+ messages in thread
From: Huang Shijie @ 2018-08-06 9:22 UTC (permalink / raw)
To: Daniel Mack
Cc: vkoul, dan.j.williams, Zubair.Kakakhel, haojian.zhuang,
robert.jarzmik, patrice.chotard, linus.walleij, mcoquelin.stm32,
alexandre.torgue, Eugeniy.Paltsev, colin.king, dmaengine,
linux-arm-kernel
On Mon, Aug 06, 2018 at 11:03:51AM +0200, Daniel Mack wrote:
> > - ret = dma_async_device_register(&fdev->dma_device);
> > + ret = dmaenginem_async_device_register(&fdev->dma_device);
> > if (ret) {
> > dev_err(&pdev->dev,
> > "Failed to register DMA device (%d)\n", ret);
> > @@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev)
> > return 0;
> > err_dma_dev:
> > - dma_async_device_unregister(&fdev->dma_device);
>
> I guess the jump label can go away too?
Yes.
We can remove the err_dma_dev too.
Thanks
Huang Shijie
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* [v2,3/9] dmaengine: st_fdma: use dmaenginem_async_device_register to simplify the code
@ 2018-08-06 9:03 Daniel Mack
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Mack @ 2018-08-06 9:03 UTC (permalink / raw)
To: Huang Shijie, vkoul
Cc: dan.j.williams, Zubair.Kakakhel, haojian.zhuang, robert.jarzmik,
patrice.chotard, linus.walleij, mcoquelin.stm32, alexandre.torgue,
Eugeniy.Paltsev, colin.king, dmaengine, linux-arm-kernel
On Monday, August 06, 2018 10:52 AM, Huang Shijie wrote:
> Use dmaenginem_async_device_register to simplify the code:
> remove dma_async_device_unregister.
>
> Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
> ---
> drivers/dma/st_fdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
> index bfb79bd0c6de..7eafccd4f7f5 100644
> --- a/drivers/dma/st_fdma.c
> +++ b/drivers/dma/st_fdma.c
> @@ -833,7 +833,7 @@ static int st_fdma_probe(struct platform_device *pdev)
> fdev->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> fdev->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
>
> - ret = dma_async_device_register(&fdev->dma_device);
> + ret = dmaenginem_async_device_register(&fdev->dma_device);
> if (ret) {
> dev_err(&pdev->dev,
> "Failed to register DMA device (%d)\n", ret);
> @@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev)
> return 0;
>
> err_dma_dev:
> - dma_async_device_unregister(&fdev->dma_device);
I guess the jump label can go away too?
Thanks,
Daniel
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* [v2,3/9] dmaengine: st_fdma: use dmaenginem_async_device_register to simplify the code
@ 2018-08-06 8:52 Huang Shijie
0 siblings, 0 replies; 3+ messages in thread
From: Huang Shijie @ 2018-08-06 8:52 UTC (permalink / raw)
To: vkoul
Cc: dan.j.williams, Zubair.Kakakhel, daniel, haojian.zhuang,
robert.jarzmik, patrice.chotard, linus.walleij, mcoquelin.stm32,
alexandre.torgue, Eugeniy.Paltsev, colin.king, dmaengine,
linux-arm-kernel, Huang Shijie
Use dmaenginem_async_device_register to simplify the code:
remove dma_async_device_unregister.
Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
---
drivers/dma/st_fdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index bfb79bd0c6de..7eafccd4f7f5 100644
--- a/drivers/dma/st_fdma.c
+++ b/drivers/dma/st_fdma.c
@@ -833,7 +833,7 @@ static int st_fdma_probe(struct platform_device *pdev)
fdev->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
fdev->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
- ret = dma_async_device_register(&fdev->dma_device);
+ ret = dmaenginem_async_device_register(&fdev->dma_device);
if (ret) {
dev_err(&pdev->dev,
"Failed to register DMA device (%d)\n", ret);
@@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev)
return 0;
err_dma_dev:
- dma_async_device_unregister(&fdev->dma_device);
err_rproc:
st_fdma_free(fdev);
st_slim_rproc_put(fdev->slim_rproc);
@@ -867,7 +866,6 @@ static int st_fdma_remove(struct platform_device *pdev)
devm_free_irq(&pdev->dev, fdev->irq, fdev);
st_slim_rproc_put(fdev->slim_rproc);
of_dma_controller_free(pdev->dev.of_node);
- dma_async_device_unregister(&fdev->dma_device);
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-06 9:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-06 9:22 [v2,3/9] dmaengine: st_fdma: use dmaenginem_async_device_register to simplify the code Huang Shijie
-- strict thread matches above, loose matches on Subject: below --
2018-08-06 9:03 Daniel Mack
2018-08-06 8:52 Huang Shijie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox