* [1/2] ACPI / LPSS: Add alternative ACPI HIDs for Cherry Trail DMA controllers
@ 2018-08-29 16:50 Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-08-29 16:50 UTC (permalink / raw)
To: Hans de Goede
Cc: Rafael J . Wysocki, Len Brown, Viresh Kumar, Vinod Koul,
linux-acpi, Dan Williams, dmaengine
On Mon, Aug 27, 2018 at 09:45:44AM +0200, Hans de Goede wrote:
> Bay and Cherry Trail DSTDs represent a different set of devices depending
> on which OS the device think it is booting. One set of decices for Windows
> and another set of devices for Android which targets the Android-x86 Linux
> kernel fork (which e.g. used to have its own display driver instead of
> using the i915 driver).
>
> Which set of devices we are actually going to get is out of our control,
> this is controlled by the ACPI OSID variable, which gets either set through
> an EFI setup option, or sometimes is autodetected. So we need to support
> both.
>
> This commit adds support for the 80862286 and 808622C0 ACPI HIDs which we
> get for the first resp. second DMA controller on Cherry Trail devices when
> OSID is set to Android.
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/acpi/acpi_lpss.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 0569972b02e1..95d9c45e13cc 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -327,9 +327,11 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
> { "INT33FC", },
>
> /* Braswell LPSS devices */
> + { "80862286", LPSS_ADDR(lpss_dma_desc) },
> { "80862288", LPSS_ADDR(bsw_pwm_dev_desc) },
> { "8086228A", LPSS_ADDR(bsw_uart_dev_desc) },
> { "8086228E", LPSS_ADDR(bsw_spi_dev_desc) },
> + { "808622C0", LPSS_ADDR(lpss_dma_desc) },
> { "808622C1", LPSS_ADDR(bsw_i2c_dev_desc) },
>
> /* Broadwell LPSS devices */
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [1/2] ACPI / LPSS: Add alternative ACPI HIDs for Cherry Trail DMA controllers
@ 2018-09-14 8:40 Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-09-14 8:40 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede
Cc: Len Brown, Viresh Kumar, Vinod Koul, linux-acpi, Dan Williams,
dmaengine
On Wednesday, August 29, 2018 6:50:53 PM CEST Andy Shevchenko wrote:
> On Mon, Aug 27, 2018 at 09:45:44AM +0200, Hans de Goede wrote:
> > Bay and Cherry Trail DSTDs represent a different set of devices depending
> > on which OS the device think it is booting. One set of decices for Windows
> > and another set of devices for Android which targets the Android-x86 Linux
> > kernel fork (which e.g. used to have its own display driver instead of
> > using the i915 driver).
> >
> > Which set of devices we are actually going to get is out of our control,
> > this is controlled by the ACPI OSID variable, which gets either set through
> > an EFI setup option, or sometimes is autodetected. So we need to support
> > both.
> >
> > This commit adds support for the 80862286 and 808622C0 ACPI HIDs which we
> > get for the first resp. second DMA controller on Cherry Trail devices when
> > OSID is set to Android.
> >
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > drivers/acpi/acpi_lpss.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> > index 0569972b02e1..95d9c45e13cc 100644
> > --- a/drivers/acpi/acpi_lpss.c
> > +++ b/drivers/acpi/acpi_lpss.c
> > @@ -327,9 +327,11 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
> > { "INT33FC", },
> >
> > /* Braswell LPSS devices */
> > + { "80862286", LPSS_ADDR(lpss_dma_desc) },
> > { "80862288", LPSS_ADDR(bsw_pwm_dev_desc) },
> > { "8086228A", LPSS_ADDR(bsw_uart_dev_desc) },
> > { "8086228E", LPSS_ADDR(bsw_spi_dev_desc) },
> > + { "808622C0", LPSS_ADDR(lpss_dma_desc) },
> > { "808622C1", LPSS_ADDR(bsw_i2c_dev_desc) },
> >
> > /* Broadwell LPSS devices */
>
>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread* [1/2] ACPI / LPSS: Add alternative ACPI HIDs for Cherry Trail DMA controllers
@ 2018-08-27 7:45 Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2018-08-27 7:45 UTC (permalink / raw)
To: Rafael J . Wysocki, Len Brown, Viresh Kumar, Andy Shevchenko,
Vinod Koul
Cc: Hans de Goede, linux-acpi, Dan Williams, dmaengine
Bay and Cherry Trail DSTDs represent a different set of devices depending
on which OS the device think it is booting. One set of decices for Windows
and another set of devices for Android which targets the Android-x86 Linux
kernel fork (which e.g. used to have its own display driver instead of
using the i915 driver).
Which set of devices we are actually going to get is out of our control,
this is controlled by the ACPI OSID variable, which gets either set through
an EFI setup option, or sometimes is autodetected. So we need to support
both.
This commit adds support for the 80862286 and 808622C0 ACPI HIDs which we
get for the first resp. second DMA controller on Cherry Trail devices when
OSID is set to Android.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/acpi_lpss.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 0569972b02e1..95d9c45e13cc 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -327,9 +327,11 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
{ "INT33FC", },
/* Braswell LPSS devices */
+ { "80862286", LPSS_ADDR(lpss_dma_desc) },
{ "80862288", LPSS_ADDR(bsw_pwm_dev_desc) },
{ "8086228A", LPSS_ADDR(bsw_uart_dev_desc) },
{ "8086228E", LPSS_ADDR(bsw_spi_dev_desc) },
+ { "808622C0", LPSS_ADDR(lpss_dma_desc) },
{ "808622C1", LPSS_ADDR(bsw_i2c_dev_desc) },
/* Broadwell LPSS devices */
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-14 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 16:50 [1/2] ACPI / LPSS: Add alternative ACPI HIDs for Cherry Trail DMA controllers Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2018-09-14 8:40 Rafael J. Wysocki
2018-08-27 7:45 Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox