* [2/5] dmaengine: sprd: remove dma_slave_config direction usage
@ 2018-11-11 15:47 Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2018-11-11 15:47 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul, Baolin Wang
dma_slave_config direction was marked as deprecated quite some
time back, remove the usage from this driver so that the field
can be removed
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/sprd-dma.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 38d4e4f07c66..c226dc93e401 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -847,9 +847,6 @@ static int sprd_dma_slave_config(struct dma_chan *chan,
struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
struct dma_slave_config *slave_cfg = &schan->slave_cfg;
- if (!is_slave_direction(config->direction))
- return -EINVAL;
-
memcpy(slave_cfg, config, sizeof(*config));
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [2/5] dmaengine: sprd: remove dma_slave_config direction usage
@ 2018-11-12 2:47 Baolin Wang
0 siblings, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2018-11-12 2:47 UTC (permalink / raw)
To: Vinod Koul; +Cc: dmaengine
Hi Vinod,
On 11 November 2018 at 23:47, Vinod Koul <vkoul@kernel.org> wrote:
> dma_slave_config direction was marked as deprecated quite some
> time back, remove the usage from this driver so that the field
> can be removed
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
We already posted one patch set to fix this issue, could you have a
look when you feel free? Thanks.
https://lore.kernel.org/patchwork/patch/1007238/
https://lore.kernel.org/patchwork/project/lkml/list/?series=371812
> ---
> drivers/dma/sprd-dma.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 38d4e4f07c66..c226dc93e401 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -847,9 +847,6 @@ static int sprd_dma_slave_config(struct dma_chan *chan,
> struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
> struct dma_slave_config *slave_cfg = &schan->slave_cfg;
>
> - if (!is_slave_direction(config->direction))
> - return -EINVAL;
> -
> memcpy(slave_cfg, config, sizeof(*config));
> return 0;
> }
> --
> 2.14.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2/5] dmaengine: sprd: remove dma_slave_config direction usage
@ 2018-11-12 18:06 Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2018-11-12 18:06 UTC (permalink / raw)
To: Baolin Wang; +Cc: dmaengine
On 12-11-18, 10:47, Baolin Wang wrote:
> Hi Vinod,
>
> On 11 November 2018 at 23:47, Vinod Koul <vkoul@kernel.org> wrote:
> > dma_slave_config direction was marked as deprecated quite some
> > time back, remove the usage from this driver so that the field
> > can be removed
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> We already posted one patch set to fix this issue, could you have a
> look when you feel free? Thanks.
Thanks for fixing that, I will check the series and drop this one
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-12 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-12 18:06 [2/5] dmaengine: sprd: remove dma_slave_config direction usage Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 2:47 Baolin Wang
2018-11-11 15:47 Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox