* [V2] dmaengine: dmatest: unmap data on a single code-path when xfer done
@ 2018-10-29 10:08 Alexandru Ardelean
0 siblings, 0 replies; 2+ messages in thread
From: Alexandru Ardelean @ 2018-10-29 10:08 UTC (permalink / raw)
To: dmaengine, dan.j.williams; +Cc: Alexandru Ardelean
After the DMA transfer is done, we don't need to call the un-mapping code
in 3 places. One is enough.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
Changelog v1 -> v2:
- re-applied on an upstream base; V1 was applied on another patch
drivers/dma/dmatest.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 9cd09e8f9b4f..214391ba019a 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -721,14 +721,14 @@ static int dmatest_func(void *data)
status = dma_async_is_tx_complete(chan, cookie, NULL, NULL);
+ dmaengine_unmap_put(um);
+
if (!done->done) {
- dmaengine_unmap_put(um);
result("test timed out", total_tests, src_off, dst_off,
len, 0);
failed_tests++;
continue;
} else if (status != DMA_COMPLETE) {
- dmaengine_unmap_put(um);
result(status == DMA_ERROR ?
"completion error status" :
"completion busy status", total_tests, src_off,
@@ -737,8 +737,6 @@ static int dmatest_func(void *data)
continue;
}
- dmaengine_unmap_put(um);
-
if (params->noverify) {
verbose_result("test passed", total_tests, src_off,
dst_off, len, 0);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [V2] dmaengine: dmatest: unmap data on a single code-path when xfer done
@ 2018-11-24 13:47 Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2018-11-24 13:47 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: dmaengine, dan.j.williams
On 29-10-18, 12:08, Alexandru Ardelean wrote:
> After the DMA transfer is done, we don't need to call the un-mapping code
> in 3 places. One is enough.
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-24 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-24 13:47 [V2] dmaengine: dmatest: unmap data on a single code-path when xfer done Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-10-29 10:08 Alexandru Ardelean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox