* dmaengine: at_hdmac: fix module unloading
@ 2018-11-29 14:21 Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2018-11-29 14:21 UTC (permalink / raw)
To: Richard Genoud
Cc: Ludovic Desroches, Dan Williams, Alexandre Belloni, Nicolas Ferre,
Maxime Ripard, Mario Forner, linux-arm-kernel, dmaengine,
linux-kernel, linux-serial, stable
On 27-11-18, 17:06, Richard Genoud wrote:
> of_dma_controller_free() was not called on module onloading.
> This lead to a soft lockup:
> watchdog: BUG: soft lockup - CPU#0 stuck for 23s!
> Modules linked in: at_hdmac [last unloaded: at_hdmac]
> when of_dma_request_slave_channel() tried to call ofdma->of_dma_xlate().
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* dmaengine: at_hdmac: fix module unloading
@ 2018-11-29 13:52 Ludovic Desroches
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2018-11-29 13:52 UTC (permalink / raw)
To: Richard Genoud
Cc: Dan Williams, Vinod Koul, Alexandre Belloni, Nicolas Ferre,
Maxime Ripard, Mario Forner, linux-arm-kernel, dmaengine,
linux-kernel, linux-serial, stable
On Tue, Nov 27, 2018 at 05:06:35PM +0100, Richard Genoud wrote:
> of_dma_controller_free() was not called on module onloading.
s/onloading/unloading
> This lead to a soft lockup:
> watchdog: BUG: soft lockup - CPU#0 stuck for 23s!
> Modules linked in: at_hdmac [last unloaded: at_hdmac]
> when of_dma_request_slave_channel() tried to call ofdma->of_dma_xlate().
>
> Cc: stable@vger.kernel.org
> Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
Ludovic
> ---
> drivers/dma/at_hdmac.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 1b7f0ca0d5cd..01d936c9fe89 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -2006,6 +2006,8 @@ static int at_dma_remove(struct platform_device *pdev)
> struct resource *io;
>
> at_dma_off(atdma);
> + if (pdev->dev.of_node)
> + of_dma_controller_free(pdev->dev.of_node);
> dma_async_device_unregister(&atdma->dma_common);
>
> dma_pool_destroy(atdma->memset_pool);
^ permalink raw reply [flat|nested] 3+ messages in thread* dmaengine: at_hdmac: fix module unloading
@ 2018-11-27 16:06 Richard Genoud
0 siblings, 0 replies; 3+ messages in thread
From: Richard Genoud @ 2018-11-27 16:06 UTC (permalink / raw)
To: Ludovic Desroches, Dan Williams, Vinod Koul
Cc: Alexandre Belloni, Nicolas Ferre, Maxime Ripard, Mario Forner,
linux-arm-kernel, dmaengine, linux-kernel, linux-serial,
Richard Genoud, stable
of_dma_controller_free() was not called on module onloading.
This lead to a soft lockup:
watchdog: BUG: soft lockup - CPU#0 stuck for 23s!
Modules linked in: at_hdmac [last unloaded: at_hdmac]
when of_dma_request_slave_channel() tried to call ofdma->of_dma_xlate().
Cc: stable@vger.kernel.org
Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/dma/at_hdmac.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 1b7f0ca0d5cd..01d936c9fe89 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -2006,6 +2006,8 @@ static int at_dma_remove(struct platform_device *pdev)
struct resource *io;
at_dma_off(atdma);
+ if (pdev->dev.of_node)
+ of_dma_controller_free(pdev->dev.of_node);
dma_async_device_unregister(&atdma->dma_common);
dma_pool_destroy(atdma->memset_pool);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-29 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-29 14:21 dmaengine: at_hdmac: fix module unloading Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-11-29 13:52 Ludovic Desroches
2018-11-27 16:06 Richard Genoud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox