* [v3,1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet
@ 2019-04-03 10:23 Nicolas Ferre
2019-04-23 5:10 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2019-04-03 10:23 UTC (permalink / raw)
To: dmaengine, Vinod Koul
Cc: Ludovic Desroches, linux-arm-kernel, Alexandre Belloni,
linux-kernel, Nicolas Ferre
Even if this case shouldn't happen when controller is properly programmed,
it's still better to avoid dumping a kernel Oops for this.
As the sequence may happen only for debugging purposes, log the error and
just finish the tasklet call.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
v3: no change
v2: added Ludovic's tag
drivers/dma/at_xdmac.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index fe69dccfa0c0..37a269420435 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1606,7 +1606,11 @@ static void at_xdmac_tasklet(unsigned long data)
struct at_xdmac_desc,
xfer_node);
dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);
- BUG_ON(!desc->active_xfer);
+ if (!desc->active_xfer) {
+ dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting");
+ spin_unlock_bh(&atchan->lock);
+ return;
+ }
txd = &desc->tx_dma_desc;
^ permalink raw reply related [flat|nested] 3+ messages in thread* [v3,1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet
@ 2019-04-23 5:10 ` Vinod Koul
2019-04-23 5:10 ` [PATCH v3 1/3] " Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2019-04-23 5:10 UTC (permalink / raw)
To: Nicolas Ferre
Cc: dmaengine, Ludovic Desroches, linux-arm-kernel, Alexandre Belloni,
linux-kernel
On 03-04-19, 12:23, Nicolas Ferre wrote:
> Even if this case shouldn't happen when controller is properly programmed,
> it's still better to avoid dumping a kernel Oops for this.
> As the sequence may happen only for debugging purposes, log the error and
> just finish the tasklet call.
Applied all, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet
2019-04-23 5:10 ` Vinod Koul
@ 2019-04-23 5:10 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-04-23 5:10 UTC (permalink / raw)
To: Nicolas Ferre
Cc: dmaengine, Ludovic Desroches, linux-arm-kernel, Alexandre Belloni,
linux-kernel
On 03-04-19, 12:23, Nicolas Ferre wrote:
> Even if this case shouldn't happen when controller is properly programmed,
> it's still better to avoid dumping a kernel Oops for this.
> As the sequence may happen only for debugging purposes, log the error and
> just finish the tasklet call.
Applied all, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-23 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03 10:23 [v3,1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet Nicolas Ferre
2019-04-23 5:10 ` Vinod Koul
2019-04-23 5:10 ` [PATCH v3 1/3] " Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox