From: Vinod Koul <vkoul@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Lukas Wunner <lukas@wunner.de>,
Florian Kauer <florian.kauer@koalo.de>,
Martin Sperl <kernel@martin.sperl.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: [RFC] dmaengine: bcm2835: Avoid GFP_KERNEL in device_prep_slave_sg
Date: Tue, 23 Apr 2019 10:41:09 +0530 [thread overview]
Message-ID: <20190423051109.GE28103@vkoul-mobl> (raw)
On 01-04-19, 20:38, Stefan Wahren wrote:
> The commit af19b7ce76ba ("mmc: bcm2835: Avoid possible races on
> data requests") introduces a possible circular locking dependency,
> which is triggered by swapping to the sdhost interface.
>
> So instead of reintroduce the race condition again, we could also
> avoid this situation by using GFP_NOWAIT for the allocation of the
> DMA buffer descriptors.
Applied, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Lukas Wunner <lukas@wunner.de>,
Florian Kauer <florian.kauer@koalo.de>,
Martin Sperl <kernel@martin.sperl.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH RFC] dmaengine: bcm2835: Avoid GFP_KERNEL in device_prep_slave_sg
Date: Tue, 23 Apr 2019 10:41:09 +0530 [thread overview]
Message-ID: <20190423051109.GE28103@vkoul-mobl> (raw)
Message-ID: <20190423051109.MBoL_qIxOJXgzykYhGnPRDZ6XM9EQuqadbXMN6I5XZQ@z> (raw)
In-Reply-To: <1554143899-4124-1-git-send-email-stefan.wahren@i2se.com>
On 01-04-19, 20:38, Stefan Wahren wrote:
> The commit af19b7ce76ba ("mmc: bcm2835: Avoid possible races on
> data requests") introduces a possible circular locking dependency,
> which is triggered by swapping to the sdhost interface.
>
> So instead of reintroduce the race condition again, we could also
> avoid this situation by using GFP_NOWAIT for the allocation of the
> DMA buffer descriptors.
Applied, thanks
--
~Vinod
next prev reply other threads:[~2019-04-23 5:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 18:38 [RFC] dmaengine: bcm2835: Avoid GFP_KERNEL in device_prep_slave_sg Stefan Wahren
2019-04-23 5:11 ` Vinod Koul [this message]
2019-04-23 5:11 ` [PATCH RFC] " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423051109.GE28103@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=florian.kauer@koalo.de \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox