From: Vinod Koul <vkoul@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: dmaengine@vger.kernel.org
Subject: [V3] dmaengine: axi-dmac: Don't check the number of frames for alignment
Date: Wed, 24 Apr 2019 11:08:51 +0530 [thread overview]
Message-ID: <20190424053851.GL28103@vkoul-mobl> (raw)
On 26-03-19, 16:05, Alexandru Ardelean wrote:
> In 2D transfers (for the AXI DMAC), the number of frames (numf) represents
> Y_LENGTH, and the length of a frame is X_LENGTH. 2D transfers are useful
> for video transfers where screen resolutions ( X * Y ) are typically
> aligned for X, but not for Y.
>
> There is no requirement for Y_LENGTH to be aligned to the bus-width (or
> anything), and this is also true for AXI DMAC.
>
> Checking the Y_LENGTH for alignment causes false errors when initiating DMA
> transfers. This change fixes this by checking only that the Y_LENGTH is
> non-zero.
Applied, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: dmaengine@vger.kernel.org
Subject: Re: [PATCH V3] dmaengine: axi-dmac: Don't check the number of frames for alignment
Date: Wed, 24 Apr 2019 11:08:51 +0530 [thread overview]
Message-ID: <20190424053851.GL28103@vkoul-mobl> (raw)
Message-ID: <20190424053851.BIwMReAURDkccjn3MzT325DK21AGwF8cszl-Zzr0kqA@z> (raw)
In-Reply-To: <20190326140520.28475-1-alexandru.ardelean@analog.com>
On 26-03-19, 16:05, Alexandru Ardelean wrote:
> In 2D transfers (for the AXI DMAC), the number of frames (numf) represents
> Y_LENGTH, and the length of a frame is X_LENGTH. 2D transfers are useful
> for video transfers where screen resolutions ( X * Y ) are typically
> aligned for X, but not for Y.
>
> There is no requirement for Y_LENGTH to be aligned to the bus-width (or
> anything), and this is also true for AXI DMAC.
>
> Checking the Y_LENGTH for alignment causes false errors when initiating DMA
> transfers. This change fixes this by checking only that the Y_LENGTH is
> non-zero.
Applied, thanks
--
~Vinod
next prev reply other threads:[~2019-04-24 5:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 14:05 [V3] dmaengine: axi-dmac: Don't check the number of frames for alignment Alexandru Ardelean
2019-04-24 5:38 ` Vinod Koul [this message]
2019-04-24 5:38 ` [PATCH V3] " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424053851.GL28103@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox