* [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe()
@ 2019-09-22 8:48 Markus Elfring
2019-10-09 7:46 ` Ludovic Desroches
2019-10-14 7:53 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2019-09-22 8:48 UTC (permalink / raw)
To: dmaengine, linux-arm-kernel, Dan Williams, Ludovic Desroches,
Vinod Koul
Cc: LKML, kernel-janitors, Nicolas Ferre
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 22 Sep 2019 10:37:31 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/dma/at_xdmac.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index b58ac720d9a1..f71c9f77d405 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1957,21 +1957,16 @@ static int atmel_xdmac_resume(struct device *dev)
static int at_xdmac_probe(struct platform_device *pdev)
{
- struct resource *res;
struct at_xdmac *atxdmac;
int irq, size, nr_channels, i, ret;
void __iomem *base;
u32 reg;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EINVAL;
-
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe()
2019-09-22 8:48 [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe() Markus Elfring
@ 2019-10-09 7:46 ` Ludovic Desroches
2019-10-14 7:53 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2019-10-09 7:46 UTC (permalink / raw)
To: Markus Elfring
Cc: dmaengine, linux-arm-kernel, Dan Williams, Vinod Koul, LKML,
kernel-janitors, Nicolas Ferre
On Sun, Sep 22, 2019 at 10:48:20AM +0200, Markus Elfring wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 22 Sep 2019 10:37:31 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
> ---
> drivers/dma/at_xdmac.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index b58ac720d9a1..f71c9f77d405 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1957,21 +1957,16 @@ static int atmel_xdmac_resume(struct device *dev)
>
> static int at_xdmac_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct at_xdmac *atxdmac;
> int irq, size, nr_channels, i, ret;
> void __iomem *base;
> u32 reg;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -EINVAL;
> -
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe()
2019-09-22 8:48 [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe() Markus Elfring
2019-10-09 7:46 ` Ludovic Desroches
@ 2019-10-14 7:53 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-10-14 7:53 UTC (permalink / raw)
To: Markus Elfring
Cc: dmaengine, linux-arm-kernel, Dan Williams, Ludovic Desroches,
LKML, kernel-janitors, Nicolas Ferre
On 22-09-19, 10:48, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 22 Sep 2019 10:37:31 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-14 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-22 8:48 [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe() Markus Elfring
2019-10-09 7:46 ` Ludovic Desroches
2019-10-14 7:53 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox