DMA Engine development
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Viresh Kumar <vireshk@kernel.org>, dmaengine@vger.kernel.org
Subject: Re: [PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional
Date: Mon, 14 Oct 2019 13:51:28 +0530	[thread overview]
Message-ID: <20191014082128.GN2654@vkoul-mobl> (raw)
In-Reply-To: <20190924085116.83683-1-andriy.shevchenko@linux.intel.com>

On 24-09-19, 11:51, Andy Shevchenko wrote:
> On some platforms the clock can be fixed rate, always running one and
> there is no need to do anything with it.
> 
> In order to support those platforms, switch to use optional clock.
> 
> Fixes: f8d9ddbc2851 ("Enable iDMA 32-bit on Intel Elkhart Lake")

My script complained the Fixes doesnt match, you seem to have omitted
the subsystem and driver name tags from this line.

I have fixed that and applied

> Depends-on: 60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/dma/dw/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index 6a94f22b6637..bffc79a620ae 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -66,7 +66,7 @@ static int dw_probe(struct platform_device *pdev)
>  
>  	data->chip = chip;
>  
> -	chip->clk = devm_clk_get(chip->dev, "hclk");
> +	chip->clk = devm_clk_get_optional(chip->dev, "hclk");
>  	if (IS_ERR(chip->clk))
>  		return PTR_ERR(chip->clk);
>  	err = clk_prepare_enable(chip->clk);
> -- 
> 2.23.0

-- 
~Vinod

  parent reply	other threads:[~2019-10-14  8:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  8:51 [PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional Andy Shevchenko
2019-09-24 11:52 ` Viresh Kumar
2019-10-14  8:21 ` Vinod Koul [this message]
2019-10-14  9:16   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014082128.GN2654@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox