[PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional

[PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional

[Andy Shevchenko]

On some platforms the clock can be fixed rate, always running one and
there is no need to do anything with it.

In order to support those platforms, switch to use optional clock.

Fixes: f8d9ddbc2851 ("Enable iDMA 32-bit on Intel Elkhart Lake")
Depends-on: 60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/dw/platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
index 6a94f22b6637..bffc79a620ae 100644
--- a/drivers/dma/dw/platform.c
+++ b/drivers/dma/dw/platform.c
@@ -66,7 +66,7 @@ static int dw_probe(struct platform_device *pdev)
 
 	data->chip = chip;
 
-	chip->clk = devm_clk_get(chip->dev, "hclk");
+	chip->clk = devm_clk_get_optional(chip->dev, "hclk");
 	if (IS_ERR(chip->clk))
 		return PTR_ERR(chip->clk);
 	err = clk_prepare_enable(chip->clk);
-- 
2.23.0

Re: [PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional

[Viresh Kumar]

On 24-09-19, 11:51, Andy Shevchenko wrote:
> On some platforms the clock can be fixed rate, always running one and
> there is no need to do anything with it.
> 
> In order to support those platforms, switch to use optional clock.
> 
> Fixes: f8d9ddbc2851 ("Enable iDMA 32-bit on Intel Elkhart Lake")
> Depends-on: 60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/dma/dw/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Re: [PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional

[Vinod Koul]

On 24-09-19, 11:51, Andy Shevchenko wrote:
> On some platforms the clock can be fixed rate, always running one and
> there is no need to do anything with it.
> 
> In order to support those platforms, switch to use optional clock.
> 
> Fixes: f8d9ddbc2851 ("Enable iDMA 32-bit on Intel Elkhart Lake")

My script complained the Fixes doesnt match, you seem to have omitted
the subsystem and driver name tags from this line.

I have fixed that and applied

> Depends-on: 60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/dma/dw/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index 6a94f22b6637..bffc79a620ae 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -66,7 +66,7 @@ static int dw_probe(struct platform_device *pdev)
>  
>  	data->chip = chip;
>  
> -	chip->clk = devm_clk_get(chip->dev, "hclk");
> +	chip->clk = devm_clk_get_optional(chip->dev, "hclk");
>  	if (IS_ERR(chip->clk))
>  		return PTR_ERR(chip->clk);
>  	err = clk_prepare_enable(chip->clk);
> -- 
> 2.23.0

-- 
~Vinod

Re: [PATCH v1] dmaengine: dw: platform: Mark 'hclk' clock optional

[Viresh Kumar]

On 14-10-19, 13:51, Vinod Koul wrote:
> On 24-09-19, 11:51, Andy Shevchenko wrote:
> > On some platforms the clock can be fixed rate, always running one and
> > there is no need to do anything with it.
> > 
> > In order to support those platforms, switch to use optional clock.
> > 
> > Fixes: f8d9ddbc2851 ("Enable iDMA 32-bit on Intel Elkhart Lake")
> 
> My script complained the Fixes doesnt match, you seem to have omitted
> the subsystem and driver name tags from this line.

Better to automate getting these tags the way Documentation says.

Keep following in your gitconfig file:

[pretty]
        fixes = Fixes: %h (\"%s\")
        onelin = commit %h (\"%s\")

and then you can do:

git log --pretty=fixes OR --pretty=onelin

to get the tags in correct format.

-- 
viresh