* Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure [not found] ` <3d5497d8-7275-1461-8b59-b3695838be45@broadcom.com> @ 2019-09-27 4:08 ` Rayagonda Kokatanur 2019-10-14 8:30 ` Vinod Koul 0 siblings, 1 reply; 2+ messages in thread From: Rayagonda Kokatanur @ 2019-09-27 4:08 UTC (permalink / raw) To: Vinod Koul Cc: Dan Williams, dmaengine, Linux Kernel Mailing List, BCM Kernel Feedback, Ray Jui Hi Vinod, Did you get chance to review this fix? Best regards, Rayagonda On Thu, Jan 10, 2019 at 11:06 PM Ray Jui <ray.jui@broadcom.com> wrote: > > > > On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote: > > Fix kernel NULL pointer dereference error when mbox_request_channel() > > fails to allocate channel. > > > > Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox channel") > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > > --- > > drivers/dma/bcm-sba-raid.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c > > index 72878ac5c78d..77ae74663a45 100644 > > --- a/drivers/dma/bcm-sba-raid.c > > +++ b/drivers/dma/bcm-sba-raid.c > > @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev) > > sba->mchan = mbox_request_channel(&sba->client, 0); > > if (IS_ERR(sba->mchan)) { > > ret = PTR_ERR(sba->mchan); > > - goto fail_free_mchan; > > + goto fail_exit; > > } > > > > /* Find-out underlying mailbox device */ > > @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev) > > sba_freeup_channel_resources(sba); > > fail_free_mchan: > > mbox_free_channel(sba->mchan); > > +fail_exit: > > return ret; > > } > > > > > > Looks good to me. > > Reviewed-by: Ray Jui <ray.jui@broadcom.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure 2019-09-27 4:08 ` [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure Rayagonda Kokatanur @ 2019-10-14 8:30 ` Vinod Koul 0 siblings, 0 replies; 2+ messages in thread From: Vinod Koul @ 2019-10-14 8:30 UTC (permalink / raw) To: Rayagonda Kokatanur Cc: Vinod Koul, Dan Williams, dmaengine, Linux Kernel Mailing List, BCM Kernel Feedback, Ray Jui Hi Rayagonda, On 27-09-19, 09:38, Rayagonda Kokatanur wrote: > Hi Vinod, > > Did you get chance to review this fix? Please do *not* top post And on your question, sorry this is not in my queue somehow, please rebase and repost > > Best regards, > Rayagonda > > > On Thu, Jan 10, 2019 at 11:06 PM Ray Jui <ray.jui@broadcom.com> wrote: > > > > > > > > On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote: > > > Fix kernel NULL pointer dereference error when mbox_request_channel() > > > fails to allocate channel. > > > > > > Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox channel") > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > > > --- > > > drivers/dma/bcm-sba-raid.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c > > > index 72878ac5c78d..77ae74663a45 100644 > > > --- a/drivers/dma/bcm-sba-raid.c > > > +++ b/drivers/dma/bcm-sba-raid.c > > > @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev) > > > sba->mchan = mbox_request_channel(&sba->client, 0); > > > if (IS_ERR(sba->mchan)) { > > > ret = PTR_ERR(sba->mchan); > > > - goto fail_free_mchan; > > > + goto fail_exit; > > > } > > > > > > /* Find-out underlying mailbox device */ > > > @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev) > > > sba_freeup_channel_resources(sba); > > > fail_free_mchan: > > > mbox_free_channel(sba->mchan); > > > +fail_exit: > > > return ret; > > > } > > > > > > > > > > Looks good to me. > > > > Reviewed-by: Ray Jui <ray.jui@broadcom.com> -- ~Vinod ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1547100464-7020-1-git-send-email-rayagonda.kokatanur@broadcom.com>
[not found] ` <3d5497d8-7275-1461-8b59-b3695838be45@broadcom.com>
2019-09-27 4:08 ` [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure Rayagonda Kokatanur
2019-10-14 8:30 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox