* [PATCH] dmaengine: ti: k3-udma: Update rchan_oes_offset for am654 SYSFW ABI 3.0
@ 2020-08-31 9:10 Peter Ujfalusi
2020-09-03 7:24 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2020-08-31 9:10 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, dan.j.williams, linux-kernel, lokeshvutla, nm
SYSFW ABI 3.0 has changed the rchan_oes_offset value for am654 to support
SR2.
Since the kernel now needs SYSFW API 3.0 to work because the merged irqchip
update, we need to also update the am654 rchan_oes_offset.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Vinod,
A series from Lokesh to support sysfw ABI 3.0 and newer is now in mainline
under v5.9-rc3 tag.
With his series Linux can not really boot into a usable state with older sysfw
and the ABI 3.0 have additional changes affecting UDMA on am654:
the rchan_oes_offset number is changed to better align with j72xx and to be able
to support both SR1 and SR2 of am654.
Can you send this patch for -rc4 to fix the regression now in mainline?
The regression is that one can not request TR mode channel to service a
peripheral.
We do not have users upstream depending on this, but I do have out of tree audio
support and cutomers might pick up 5.9 from mainline when it is released.
Thank you,
Peter
drivers/dma/ti/k3-udma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 989998b6e078..9a7048bcf0f1 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -3091,14 +3091,14 @@ static struct udma_match_data am654_main_data = {
.psil_base = 0x1000,
.enable_memcpy_support = true,
.statictr_z_mask = GENMASK(11, 0),
- .rchan_oes_offset = 0x2000,
+ .rchan_oes_offset = 0x200,
};
static struct udma_match_data am654_mcu_data = {
.psil_base = 0x6000,
.enable_memcpy_support = false,
.statictr_z_mask = GENMASK(11, 0),
- .rchan_oes_offset = 0x2000,
+ .rchan_oes_offset = 0x200,
};
static struct udma_match_data j721e_main_data = {
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma: Update rchan_oes_offset for am654 SYSFW ABI 3.0
2020-08-31 9:10 [PATCH] dmaengine: ti: k3-udma: Update rchan_oes_offset for am654 SYSFW ABI 3.0 Peter Ujfalusi
@ 2020-09-03 7:24 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-09-03 7:24 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: dmaengine, dan.j.williams, linux-kernel, lokeshvutla, nm
On 31-08-20, 12:10, Peter Ujfalusi wrote:
> SYSFW ABI 3.0 has changed the rchan_oes_offset value for am654 to support
> SR2.
>
> Since the kernel now needs SYSFW API 3.0 to work because the merged irqchip
> update, we need to also update the am654 rchan_oes_offset.
Applied to fixes, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-31 9:10 [PATCH] dmaengine: ti: k3-udma: Update rchan_oes_offset for am654 SYSFW ABI 3.0 Peter Ujfalusi
2020-09-03 7:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox