* [PATCH] dmaengine: zx: remove redundant irqsave in hardIRQ
@ 2020-09-12 9:40 Barry Song
2020-09-18 7:00 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Barry Song @ 2020-09-12 9:40 UTC (permalink / raw)
To: dmaengine
Cc: linuxarm, Barry Song, Jun Nie, Shawn Guo, Dan Williams,
Vinod Koul
Running in hardIRQ context, disabling IRQ is redundant.
Cc: Jun Nie <jun.nie@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
drivers/dma/zx_dma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
index 5fe2e8b9a7b8..b057582b2fac 100644
--- a/drivers/dma/zx_dma.c
+++ b/drivers/dma/zx_dma.c
@@ -285,9 +285,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id)
p = &d->phy[i];
c = p->vchan;
if (c) {
- unsigned long flags;
-
- spin_lock_irqsave(&c->vc.lock, flags);
+ spin_lock(&c->vc.lock);
if (c->cyclic) {
vchan_cyclic_callback(&p->ds_run->vd);
} else {
@@ -295,7 +293,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id)
p->ds_done = p->ds_run;
task = 1;
}
- spin_unlock_irqrestore(&c->vc.lock, flags);
+ spin_unlock(&c->vc.lock);
irq_chan |= BIT(i);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: zx: remove redundant irqsave in hardIRQ
2020-09-12 9:40 [PATCH] dmaengine: zx: remove redundant irqsave in hardIRQ Barry Song
@ 2020-09-18 7:00 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-09-18 7:00 UTC (permalink / raw)
To: Barry Song; +Cc: dmaengine, linuxarm, Jun Nie, Shawn Guo, Dan Williams
On 12-09-20, 21:40, Barry Song wrote:
> Running in hardIRQ context, disabling IRQ is redundant.
>
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-18 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-12 9:40 [PATCH] dmaengine: zx: remove redundant irqsave in hardIRQ Barry Song
2020-09-18 7:00 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox