* [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance
@ 2021-10-21 3:05 Dongliang Mu
2021-10-21 6:57 ` Jon Hunter
2021-10-25 4:36 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dongliang Mu @ 2021-10-21 3:05 UTC (permalink / raw)
To: Laxman Dewangan, Jon Hunter, Vinod Koul, Thierry Reding,
Zhang Qilong
Cc: Dongliang Mu, dmaengine, linux-tegra, linux-kernel
The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using
pm_runtime_resume_and_get to replace open coding") forgets to replace
the pm_runtime_get_sync in the tegra_adma_probe, but removes the
pm_runtime_put_noidle.
Fix this by continuing to replace pm_runtime_get_sync with
pm_runtime_resume_and_get in tegra_adma_probe.
Fixes: 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/dma/tegra210-adma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index b1115a6d1935..d1dff3a29db5 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0)
goto rpm_disable;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance
2021-10-21 3:05 [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance Dongliang Mu
@ 2021-10-21 6:57 ` Jon Hunter
2021-10-25 4:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2021-10-21 6:57 UTC (permalink / raw)
To: Dongliang Mu, Laxman Dewangan, Vinod Koul, Thierry Reding,
Zhang Qilong
Cc: dmaengine, linux-tegra, linux-kernel
On 21/10/2021 04:05, Dongliang Mu wrote:
> The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using
> pm_runtime_resume_and_get to replace open coding") forgets to replace
> the pm_runtime_get_sync in the tegra_adma_probe, but removes the
> pm_runtime_put_noidle.
>
> Fix this by continuing to replace pm_runtime_get_sync with
> pm_runtime_resume_and_get in tegra_adma_probe.
>
> Fixes: 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> drivers/dma/tegra210-adma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..d1dff3a29db5 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
>
> pm_runtime_enable(&pdev->dev);
>
> - ret = pm_runtime_get_sync(&pdev->dev);
> + ret = pm_runtime_resume_and_get(&pdev->dev);
> if (ret < 0)
> goto rpm_disable;
>
>
Thanks!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance
2021-10-21 3:05 [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance Dongliang Mu
2021-10-21 6:57 ` Jon Hunter
@ 2021-10-25 4:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-10-25 4:36 UTC (permalink / raw)
To: Dongliang Mu
Cc: Laxman Dewangan, Jon Hunter, Thierry Reding, Zhang Qilong,
dmaengine, linux-tegra, linux-kernel
On 21-10-21, 11:05, Dongliang Mu wrote:
> The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using
> pm_runtime_resume_and_get to replace open coding") forgets to replace
> the pm_runtime_get_sync in the tegra_adma_probe, but removes the
> pm_runtime_put_noidle.
>
> Fix this by continuing to replace pm_runtime_get_sync with
> pm_runtime_resume_and_get in tegra_adma_probe.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 4:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-21 3:05 [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance Dongliang Mu
2021-10-21 6:57 ` Jon Hunter
2021-10-25 4:36 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox