public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.Li@nxp.com>
To: lznuaa@gmail.com, vkoul@kernel.org
Cc: vladimir.zapolskiy@linaro.org, gustavo.pimentel@synopsys.com,
	herve.codina@bootlin.com, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches
Date: Wed, 15 Jun 2022 08:36:21 -0500	[thread overview]
Message-ID: <20220615133621.28027-1-Frank.Li@nxp.com> (raw)
In-Reply-To: <20220610100700.2295522-1-vladimir.zapolskiy@linaro.org>

On Fri, Jun 10, 2022 at 05:49:36PM +0530, Vinod Koul wrote:
> On 10-06-22, 13:07, Vladimir Zapolskiy wrote:
> > After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> > 64bit access") two branches under macro conditional become identical,
> > thus the code can be simplified without any functional change.
> 
> Applied, thanks

@vinod:
	I am very strang!
	why you pick this patch, not pick one this one
	https://www.spinics.net/lists/dmaengine/msg29735.html
	
	both patch do the exactly the same works.

	Any no any feedback about patches 
	https://www.spinics.net/lists/dmaengine/msg29913.html.
	which already review 12 round and test at three difference platform.
	And at least 3 person working on these patches. 

	At least https://www.spinics.net/lists/dmaengine/msg29914.html is cleanup
	And only two lines change.

	At begin, I think you don't care dw_edma at all. 
	But you pick this patch. 

	I am quite confused.

best regards
Frank Li

> 
> -- 
> ~Vinod
> 

  parent reply	other threads:[~2022-06-15 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 10:07 [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches Vladimir Zapolskiy
2022-06-10 10:55 ` Herve Codina
2022-06-10 12:19 ` Vinod Koul
2022-06-15 13:36 ` Frank Li [this message]
2022-06-16 13:56   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220615133621.28027-1-Frank.Li@nxp.com \
    --to=frank.li@nxp.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=herve.codina@bootlin.com \
    --cc=lznuaa@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox