Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches

[Vinod Koul <vkoul@kernel.org>]

On 15-06-22, 08:36, Frank Li wrote:
> On Fri, Jun 10, 2022 at 05:49:36PM +0530, Vinod Koul wrote:
> > On 10-06-22, 13:07, Vladimir Zapolskiy wrote:
> > > After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> > > 64bit access") two branches under macro conditional become identical,
> > > thus the code can be simplified without any functional change.
> > 
> > Applied, thanks
> 
> @vinod:
> 	I am very strang!
> 	why you pick this patch, not pick one this one
> 	https://www.spinics.net/lists/dmaengine/msg29735.html

Maybe it was on top of the queue for me..

> 	
> 	both patch do the exactly the same works.
> 
> 	Any no any feedback about patches 
> 	https://www.spinics.net/lists/dmaengine/msg29913.html.
> 	which already review 12 round and test at three difference platform.
> 	And at least 3 person working on these patches. 

People can be busy, due to travel/work etc, pls have patience with
reviews. FWIW, I have picked this already

> 
> 	At least https://www.spinics.net/lists/dmaengine/msg29914.html is cleanup
> 	And only two lines change.
> 
> 	At begin, I think you don't care dw_edma at all. 
> 	But you pick this patch. 

Based on my bandwidth, I will pick patches, I dont pick during or before
merge window... It is unfair to say I dont care about a specific driver.
Smaller changes are quick to review and do the needful, larger ones need
more time for review...

-- 
~Vinod