public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes
@ 2022-11-13 20:33 Thomas Gleixner
  2022-11-13 20:34 ` [patch 05/10] dmaengine: idxd: Remove linux/msi.h include Thomas Gleixner
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Thomas Gleixner @ 2022-11-13 20:33 UTC (permalink / raw)
  To: LKML
  Cc: Marc Zyngier, Lee Jones, Damien Le Moal, linux-ide, James Smart,
	Dick Kennedy, James E.J. Bottomley, Martin K. Petersen,
	linux-scsi, Stuart Yoder, Laurentiu Tudor, Fenghua Yu, Dave Jiang,
	Vinod Koul, dmaengine, Ioana Ciornei, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, Simon Horman,
	oss-drivers, Roy Pledge, Diana Craciun, Alex Williamson,
	Cornelia Huck, kvm, Joerg Roedel, Will Deacon, Robin Murphy,
	iommu

While working on per device MSI domains I noticed that quite some files
include linux/msi.h just because.

The top level comment in the header file clearly says:

  Regular device drivers have no business with any of these functions....

and actually none of the drivers needs anything from msi.h.

The series is not depending on anything so the individual patches can be
picked up by the relevant maintainers. I'll mop up the leftovers close to
the merge window.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [patch 05/10] dmaengine: idxd: Remove linux/msi.h include
  2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
@ 2022-11-13 20:34 ` Thomas Gleixner
  2022-11-13 22:29   ` Vinod Koul
  2022-11-15  3:00 ` [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes patchwork-bot+netdevbpf
  2022-11-26  3:27 ` Martin K. Petersen
  2 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2022-11-13 20:34 UTC (permalink / raw)
  To: LKML; +Cc: Marc Zyngier, Fenghua Yu, Dave Jiang, Vinod Koul, dmaengine

Nothing in this file needs anything from linux/msi.h

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/idxd/device.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -7,7 +7,6 @@
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include <linux/dmaengine.h>
 #include <linux/irq.h>
-#include <linux/msi.h>
 #include <uapi/linux/idxd.h>
 #include "../dmaengine.h"
 #include "idxd.h"


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch 05/10] dmaengine: idxd: Remove linux/msi.h include
  2022-11-13 20:34 ` [patch 05/10] dmaengine: idxd: Remove linux/msi.h include Thomas Gleixner
@ 2022-11-13 22:29   ` Vinod Koul
  0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2022-11-13 22:29 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: LKML, Marc Zyngier, Fenghua Yu, Dave Jiang, dmaengine

On 13-11-22, 21:34, Thomas Gleixner wrote:
> Nothing in this file needs anything from linux/msi.h

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes
  2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
  2022-11-13 20:34 ` [patch 05/10] dmaengine: idxd: Remove linux/msi.h include Thomas Gleixner
@ 2022-11-15  3:00 ` patchwork-bot+netdevbpf
  2022-11-26  3:27 ` Martin K. Petersen
  2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-15  3:00 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: linux-kernel, maz, lee, damien.lemoal, linux-ide, james.smart,
	dick.kennedy, jejb, martin.petersen, linux-scsi, stuyoder,
	laurentiu.tudor, fenghua.yu, dave.jiang, vkoul, dmaengine,
	ioana.ciornei, davem, edumazet, kuba, pabeni, netdev,
	simon.horman, oss-drivers, Roy.Pledge, diana.craciun,
	alex.williamson, cohuck, kvm, joro, will, robin.murphy, iommu

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 13 Nov 2022 21:33:54 +0100 (CET) you wrote:
> While working on per device MSI domains I noticed that quite some files
> include linux/msi.h just because.
> 
> The top level comment in the header file clearly says:
> 
>   Regular device drivers have no business with any of these functions....
> 
> [...]

Here is the summary with links:
  - [06/10] net: dpaa2: Remove linux/msi.h includes
    https://git.kernel.org/netdev/net-next/c/515e5fb6a95e
  - [07/10] net: nfp: Remove linux/msi.h includes
    https://git.kernel.org/netdev/net-next/c/5fd66a0b3bb4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes
  2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
  2022-11-13 20:34 ` [patch 05/10] dmaengine: idxd: Remove linux/msi.h include Thomas Gleixner
  2022-11-15  3:00 ` [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes patchwork-bot+netdevbpf
@ 2022-11-26  3:27 ` Martin K. Petersen
  2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-11-26  3:27 UTC (permalink / raw)
  To: Thomas Gleixner, LKML
  Cc: Martin K . Petersen, Fenghua Yu, oss-drivers, James Smart,
	Cornelia Huck, dmaengine, Paolo Abeni, Will Deacon, Lee Jones,
	Vinod Koul, Jakub Kicinski, Robin Murphy, Roy Pledge,
	Damien Le Moal, Ioana Ciornei, iommu, Joerg Roedel,
	Alex Williamson, netdev, kvm, James E.J. Bottomley, Marc Zyngier,
	Diana Craciun, Simon Horman, Stuart Yoder, David S. Miller,
	Dick Kennedy, linux-scsi, Dave Jiang, linux-ide, Eric Dumazet,
	Laurentiu Tudor

On Sun, 13 Nov 2022 21:33:54 +0100 (CET), Thomas Gleixner wrote:

> While working on per device MSI domains I noticed that quite some files
> include linux/msi.h just because.
> 
> The top level comment in the header file clearly says:
> 
>   Regular device drivers have no business with any of these functions....
> 
> [...]

Applied to 6.2/scsi-queue, thanks!

[03/10] scsi: lpfc: Remove linux/msi.h include
        https://git.kernel.org/mkp/scsi/c/cdd9344e00b4

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-26  3:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-13 20:33 [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes Thomas Gleixner
2022-11-13 20:34 ` [patch 05/10] dmaengine: idxd: Remove linux/msi.h include Thomas Gleixner
2022-11-13 22:29   ` Vinod Koul
2022-11-15  3:00 ` [patch 00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes patchwork-bot+netdevbpf
2022-11-26  3:27 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox