* [PATCH] dmaengine: idxd: Remove the unused function set_completion_address()
@ 2022-12-12 3:35 Jiapeng Chong
2022-12-12 15:32 ` Dave Jiang
2022-12-28 6:59 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-12-12 3:35 UTC (permalink / raw)
To: fenghua.yu
Cc: dave.jiang, vkoul, dmaengine, linux-kernel, Jiapeng Chong,
Abaci Robot
The function set_completion_address is defined in the dma.c file, but not
called elsewhere, so remove this unused function.
drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/dma/idxd/dma.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
index e0874cb4721c..eb35ca313684 100644
--- a/drivers/dma/idxd/dma.c
+++ b/drivers/dma/idxd/dma.c
@@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags)
*desc_flags |= IDXD_OP_FLAG_RCI;
}
-static inline void set_completion_address(struct idxd_desc *desc,
- u64 *compl_addr)
-{
- *compl_addr = desc->compl_dma;
-}
-
static inline void idxd_prep_desc_common(struct idxd_wq *wq,
struct dsa_hw_desc *hw, char opcode,
u64 addr_f1, u64 addr_f2, u64 len,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove the unused function set_completion_address()
2022-12-12 3:35 [PATCH] dmaengine: idxd: Remove the unused function set_completion_address() Jiapeng Chong
@ 2022-12-12 15:32 ` Dave Jiang
2022-12-28 6:59 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2022-12-12 15:32 UTC (permalink / raw)
To: Jiapeng Chong, fenghua.yu; +Cc: vkoul, dmaengine, linux-kernel, Abaci Robot
On 12/11/2022 8:35 PM, Jiapeng Chong wrote:
> The function set_completion_address is defined in the dma.c file, but not
> called elsewhere, so remove this unused function.
>
> drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Thanks for the cleanup
> ---
> drivers/dma/idxd/dma.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
> index e0874cb4721c..eb35ca313684 100644
> --- a/drivers/dma/idxd/dma.c
> +++ b/drivers/dma/idxd/dma.c
> @@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags)
> *desc_flags |= IDXD_OP_FLAG_RCI;
> }
>
> -static inline void set_completion_address(struct idxd_desc *desc,
> - u64 *compl_addr)
> -{
> - *compl_addr = desc->compl_dma;
> -}
> -
> static inline void idxd_prep_desc_common(struct idxd_wq *wq,
> struct dsa_hw_desc *hw, char opcode,
> u64 addr_f1, u64 addr_f2, u64 len,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove the unused function set_completion_address()
2022-12-12 3:35 [PATCH] dmaengine: idxd: Remove the unused function set_completion_address() Jiapeng Chong
2022-12-12 15:32 ` Dave Jiang
@ 2022-12-28 6:59 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-12-28 6:59 UTC (permalink / raw)
To: Jiapeng Chong
Cc: fenghua.yu, dave.jiang, dmaengine, linux-kernel, Abaci Robot
On 12-12-22, 11:35, Jiapeng Chong wrote:
> The function set_completion_address is defined in the dma.c file, but not
> called elsewhere, so remove this unused function.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-28 7:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-12 3:35 [PATCH] dmaengine: idxd: Remove the unused function set_completion_address() Jiapeng Chong
2022-12-12 15:32 ` Dave Jiang
2022-12-28 6:59 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox