[PATCH 1/2] dmaengine: ste_dma40: use correct print specfier for resource_size_t

[PATCH 1/2] dmaengine: ste_dma40: use correct print specfier for resource_size_t

[Vinod Koul]

We should use %pR for printing resource_size_t, so update that fixing
the warning:

drivers/dma/ste_dma40.c:3556:25: warning: format specifies type 'unsigned int'
but the argument has type 'resource_size_t' (aka 'unsigned long long') [-Wformat]

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 5a1a3b9c19dd ("dmaengine: ste_dma40: Get LCPA SRAM from SRAM node")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/ste_dma40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index c30d00a78eed..56c839241a53 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3542,8 +3542,8 @@ static int __init d40_probe(struct platform_device *pdev)
 	}
 	base->lcpa_size = resource_size(&res_lcpa);
 	base->phy_lcpa = res_lcpa.start;
-	dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
-		 (u32)base->phy_lcpa, base->lcpa_size);
+	dev_info(dev, "found LCPA SRAM at 0x%08x, size %pR\n",
+		 (u32)base->phy_lcpa, &base->lcpa_size);
 
 	/* We make use of ESRAM memory for this. */
 	val = readl(base->virtbase + D40_DREG_LCPA);
-- 
2.40.1

[PATCH 2/2] dmaengine: ste_dma40: fix typo in enum documentation

[Vinod Koul]

s/40_command/d40_command to fix the below warning reported:

drivers/dma/ste_dma40.c:151: warning: expecting prototype for enum 40_command.
Prototype was for enum d40_command instead

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/ste_dma40.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 56c839241a53..2246a604256e 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -136,7 +136,7 @@ static const struct stedma40_chan_cfg dma40_memcpy_conf_log = {
 };
 
 /**
- * enum 40_command - The different commands and/or statuses.
+ * enum d40_command - The different commands and/or statuses.
  *
  * @D40_DMA_STOP: DMA channel command STOP or status STOPPED,
  * @D40_DMA_RUN: The DMA channel is RUNNING of the command RUN.
-- 
2.40.1

Re: [PATCH 1/2] dmaengine: ste_dma40: use correct print specfier for resource_size_t

[Linus Walleij]

On Wed, May 17, 2023 at 8:44 AM Vinod Koul <vkoul@kernel.org> wrote:

> We should use %pR for printing resource_size_t, so update that fixing
> the warning:
>
> drivers/dma/ste_dma40.c:3556:25: warning: format specifies type 'unsigned int'
> but the argument has type 'resource_size_t' (aka 'unsigned long long') [-Wformat]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 5a1a3b9c19dd ("dmaengine: ste_dma40: Get LCPA SRAM from SRAM node")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Sorry for missing this.

Yours,
Linus Walleij

Re: [PATCH 2/2] dmaengine: ste_dma40: fix typo in enum documentation

[Linus Walleij]

On Wed, May 17, 2023 at 8:44 AM Vinod Koul <vkoul@kernel.org> wrote:

> s/40_command/d40_command to fix the below warning reported:
>
> drivers/dma/ste_dma40.c:151: warning: expecting prototype for enum 40_command.
> Prototype was for enum d40_command instead
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij