* [PATCH] dmaengine: fsl-edma: Remove unnecessary print function dev_err()
@ 2023-08-24 2:34 Jiapeng Chong
2023-08-24 3:13 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-08-24 2:34 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, linux-kernel, Jiapeng Chong, Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
./drivers/dma/fsl-edma-main.c:234:3-10: line 234 is redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6208
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/dma/fsl-edma-main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 63d48d046f04..d493dddd55b1 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -230,10 +230,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
/* request channel irq */
fsl_chan->txirq = platform_get_irq(pdev, i);
- if (fsl_chan->txirq < 0) {
- dev_err(&pdev->dev, "Can't get chan %d's irq.\n", i);
+ if (fsl_chan->txirq < 0)
return -EINVAL;
- }
ret = devm_request_irq(&pdev->dev, fsl_chan->txirq,
fsl_edma3_tx_handler, IRQF_SHARED,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dmaengine: fsl-edma: Remove unnecessary print function dev_err()
2023-08-24 2:34 [PATCH] dmaengine: fsl-edma: Remove unnecessary print function dev_err() Jiapeng Chong
@ 2023-08-24 3:13 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2023-08-24 3:13 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: vkoul, dmaengine, linux-kernel, Abaci Robot
On Thu, Aug 24, 2023 at 10:34:17AM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/dma/fsl-edma-main.c:234:3-10: line 234 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6208
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/fsl-edma-main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 63d48d046f04..d493dddd55b1 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -230,10 +230,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
>
> /* request channel irq */
> fsl_chan->txirq = platform_get_irq(pdev, i);
> - if (fsl_chan->txirq < 0) {
> - dev_err(&pdev->dev, "Can't get chan %d's irq.\n", i);
> + if (fsl_chan->txirq < 0)
> return -EINVAL;
> - }
>
> ret = devm_request_irq(&pdev->dev, fsl_chan->txirq,
> fsl_edma3_tx_handler, IRQF_SHARED,
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-24 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 2:34 [PATCH] dmaengine: fsl-edma: Remove unnecessary print function dev_err() Jiapeng Chong
2023-08-24 3:13 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox