[PATCH] dmaengine: xilinx: xdma: Workaround truncation compilation error

[PATCH] dmaengine: xilinx: xdma: Workaround truncation compilation error

[Vinod Koul]

Increase length to be copied to be large enough to overcome the
following compilation error. The buf is large enough for this purpose.

drivers/dma/xilinx/xilinx_dpdma.c: In function ‘xilinx_dpdma_debugfs_desc_done_irq_read’:
drivers/dma/xilinx/xilinx_dpdma.c:313:39: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
  313 |         snprintf(buf, out_str_len, "%d",
      |                                       ^
drivers/dma/xilinx/xilinx_dpdma.c:313:9: note: ‘snprintf’ output between 2 and 6 bytes into a destination of size 5
  313 |         snprintf(buf, out_str_len, "%d",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  314 |                  dpdma_debugfs.xilinx_dpdma_irq_done_count);
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index 69587d85a7cd..b82815e64d24 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -309,7 +309,7 @@ static ssize_t xilinx_dpdma_debugfs_desc_done_irq_read(char *buf)
 
 	out_str_len = strlen(XILINX_DPDMA_DEBUGFS_UINT16_MAX_STR);
 	out_str_len = min_t(size_t, XILINX_DPDMA_DEBUGFS_READ_MAX_SIZE,
-			    out_str_len);
+			    out_str_len + 1);
 	snprintf(buf, out_str_len, "%d",
 		 dpdma_debugfs.xilinx_dpdma_irq_done_count);
 
-- 
2.43.0

Re: [PATCH] dmaengine: xilinx: xdma: Workaround truncation compilation error

[Lizhi Hou]

Hi Vinod,

This fix should be xilinx_dpdma driver. (dmaengine: xilinx: xilinx_dpdma)

Thanks,

Lizhi

On 12/22/23 01:40, Vinod Koul wrote:
> Increase length to be copied to be large enough to overcome the
> following compilation error. The buf is large enough for this purpose.
>
> drivers/dma/xilinx/xilinx_dpdma.c: In function ‘xilinx_dpdma_debugfs_desc_done_irq_read’:
> drivers/dma/xilinx/xilinx_dpdma.c:313:39: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
>    313 |         snprintf(buf, out_str_len, "%d",
>        |                                       ^
> drivers/dma/xilinx/xilinx_dpdma.c:313:9: note: ‘snprintf’ output between 2 and 6 bytes into a destination of size 5
>    313 |         snprintf(buf, out_str_len, "%d",
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    314 |                  dpdma_debugfs.xilinx_dpdma_irq_done_count);
>        |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>   drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 69587d85a7cd..b82815e64d24 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -309,7 +309,7 @@ static ssize_t xilinx_dpdma_debugfs_desc_done_irq_read(char *buf)
>   
>   	out_str_len = strlen(XILINX_DPDMA_DEBUGFS_UINT16_MAX_STR);
>   	out_str_len = min_t(size_t, XILINX_DPDMA_DEBUGFS_READ_MAX_SIZE,
> -			    out_str_len);
> +			    out_str_len + 1);
>   	snprintf(buf, out_str_len, "%d",
>   		 dpdma_debugfs.xilinx_dpdma_irq_done_count);
>