* [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'
@ 2024-05-16 13:32 linux
2024-05-16 14:49 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: linux @ 2024-05-16 13:32 UTC (permalink / raw)
To: vkoul; +Cc: linux-arm-msm, dmaengine, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'gpi_desc' seems like it was never used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/dma/qcom/gpi.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 1c93864e0e4d..639ab304db9b 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -476,12 +476,6 @@ struct gpi_dev {
struct gpii *gpiis;
};
-struct reg_info {
- char *name;
- u32 offset;
- u32 val;
-};
-
struct gchan {
struct virt_dma_chan vc;
u32 chid;
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'
2024-05-16 13:32 [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc' linux
@ 2024-05-16 14:49 ` Frank Li
2024-05-16 15:25 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2024-05-16 14:49 UTC (permalink / raw)
To: linux; +Cc: vkoul, linux-arm-msm, dmaengine, linux-kernel
On Thu, May 16, 2024 at 02:32:11PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'gpi_desc' seems like it was never used.
> Remove it.
code change show 'reg_info', not 'gpi_desc'. You need make sure that it
really is not used, not "seems like".
'struct reg_info' is never used, so remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/dma/qcom/gpi.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 1c93864e0e4d..639ab304db9b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -476,12 +476,6 @@ struct gpi_dev {
> struct gpii *gpiis;
> };
>
> -struct reg_info {
> - char *name;
> - u32 offset;
> - u32 val;
> -};
> -
> struct gchan {
> struct virt_dma_chan vc;
> u32 chid;
> --
> 2.45.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'
2024-05-16 14:49 ` Frank Li
@ 2024-05-16 15:25 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-05-16 15:25 UTC (permalink / raw)
To: Frank Li; +Cc: vkoul, linux-arm-msm, dmaengine, linux-kernel
* Frank Li (Frank.li@nxp.com) wrote:
> On Thu, May 16, 2024 at 02:32:11PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'gpi_desc' seems like it was never used.
> > Remove it.
>
> code change show 'reg_info', not 'gpi_desc'. You need make sure that it
> really is not used, not "seems like".
Oops that was a cut-and-paste when I did the commit on the name.
It was build tested.
V2 coming along now.
Dave
> 'struct reg_info' is never used, so remove it.
>
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > drivers/dma/qcom/gpi.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > index 1c93864e0e4d..639ab304db9b 100644
> > --- a/drivers/dma/qcom/gpi.c
> > +++ b/drivers/dma/qcom/gpi.c
> > @@ -476,12 +476,6 @@ struct gpi_dev {
> > struct gpii *gpiis;
> > };
> >
> > -struct reg_info {
> > - char *name;
> > - u32 offset;
> > - u32 val;
> > -};
> > -
> > struct gchan {
> > struct virt_dma_chan vc;
> > u32 chid;
> > --
> > 2.45.0
> >
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-16 15:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 13:32 [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc' linux
2024-05-16 14:49 ` Frank Li
2024-05-16 15:25 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox