* [PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions
@ 2026-03-16 22:16 Marek Vasut
2026-03-17 11:27 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2026-03-16 22:16 UTC (permalink / raw)
To: dmaengine
Cc: Marek Vasut, Michal Simek, Radhey Shyam Pandey, Rahul Navale,
Sasha Levin, Suraj Gupta, Thomas Gessler, Vinod Koul,
linux-arm-kernel, linux-kernel
Unlike chan->direction , struct dma_device .directions field is a
bitfield. Turn chan->direction into a bitfield to make it compatible
with struct dma_device .directions .
Fixes: 7e01511443c3 ("dmaengine: xilinx_dma: Set dma_device directions")
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Michal Simek <michal.simek@amd.com>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: Rahul Navale <rahul.navale@ifm.com>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Suraj Gupta <suraj.gupta2@amd.com>
Cc: Thomas Gessler <thomas.gessler@brueckmann-gmbh.de>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/dma/xilinx/xilinx_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 7f240fdfe8bb1..6e8e348973a9e 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -3045,7 +3045,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
return -EINVAL;
}
- xdev->common.directions |= chan->direction;
+ xdev->common.directions |= BIT(chan->direction);
/* Request the interrupt */
chan->irq = of_irq_get(node, chan->tdest);
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions
2026-03-16 22:16 [PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions Marek Vasut
@ 2026-03-17 11:27 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2026-03-17 11:27 UTC (permalink / raw)
To: dmaengine, Marek Vasut
Cc: Michal Simek, Radhey Shyam Pandey, Rahul Navale, Sasha Levin,
Suraj Gupta, Thomas Gessler, linux-arm-kernel, linux-kernel
On Mon, 16 Mar 2026 23:16:54 +0100, Marek Vasut wrote:
> Unlike chan->direction , struct dma_device .directions field is a
> bitfield. Turn chan->direction into a bitfield to make it compatible
> with struct dma_device .directions .
>
>
Applied, thanks!
[1/1] dmaengine: xilinx: xilinx_dma: Fix dma_device directions
commit: e9cc95397bb7da13fe8a5b53a2f23cfaf9018ade
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-17 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-16 22:16 [PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions Marek Vasut
2026-03-17 11:27 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox